Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41303/?format=api
{ "id": 41303, "url": "http://patchwork.dpdk.org/api/patches/41303/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1529419046-95906-1-git-send-email-ido@cgstowernetworks.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529419046-95906-1-git-send-email-ido@cgstowernetworks.com", "date": "2018-06-19T14:37:25", "name": "[v2,1/2] net/pcap: multiple queues fix", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "13ba5a9eedfd9d49d5561c43252e378816346c7f", "submitter": { "id": 1047, "url": "http://patchwork.dpdk.org/api/people/1047/?format=api", "name": "Ido Goshen", "email": "ido@cgstowernetworks.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1529419046-95906-1-git-send-email-ido@cgstowernetworks.com/mbox/", "series": [ { "id": 172, "url": "http://patchwork.dpdk.org/api/series/172/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=172", "date": "2018-06-19T14:37:25", "name": "[v2,1/2] net/pcap: multiple queues fix", "version": 2, "mbox": "http://patchwork.dpdk.org/series/172/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41303/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41303/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8021F1B435;\n\tWed, 20 Jun 2018 00:56:01 +0200 (CEST)", "from EUR02-HE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr10133.outbound.protection.outlook.com [40.107.1.133])\n\tby dpdk.org (Postfix) with ESMTP id 854AA4C96;\n\tTue, 19 Jun 2018 16:38:07 +0200 (CEST)", "from ubuntu.localdomain (5.144.48.231) by\n\tVI1PR0901MB1439.eurprd09.prod.outlook.com (2603:10a6:800:8d::7) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.863.19;\n\tTue, 19 Jun 2018 14:38:04 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=cgstowernetworks.onmicrosoft.com; s=selector1-cgstowernetworks-com; \n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=fvqdsnNvyHsTqargmNibv0lCJVkY0H8Knptvfe3t0tk=;\n\tb=ZtsagUJUGgj++XqUXYcuFEPae/0dBdmceVMnE++XD3TuuiByyps1Sj18RVVcdMrm09asfbxI5tlNrdJ7Wk57ezOwDD2ISCu0tBDGz8e/eRrCE5tpe8qiUs8ChP5kkz2tFI3aSWoFsnm3kaGm/HqOBSopggN17N/gBb4Oiz+kzlA=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Ido@cgstowernetworks.com; ", "From": "ido goshen <ido@cgstowernetworks.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org,\n\tido goshen <ido@cgstowernetworks.com>,\n\tstable@dpdk.org", "Date": "Tue, 19 Jun 2018 17:37:25 +0300", "Message-Id": "<1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>", "X-Mailer": "git-send-email 1.9.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[5.144.48.231]", "X-ClientProxiedBy": "LO2P265CA0190.GBRP265.PROD.OUTLOOK.COM\n\t(2603:10a6:600:a::34) To VI1PR0901MB1439.eurprd09.prod.outlook.com\n\t(2603:10a6:800:8d::7)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "07e17506-8d8b-4301-cc94-08d5d5f244b7", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:VI1PR0901MB1439; ", "X-Microsoft-Exchange-Diagnostics": [ "1; VI1PR0901MB1439;\n\t3:HE0C7qWt5FZn1dEjrjKzqTGu35t3ogqEbQH49KTBX6w058PUcU2JfhwRIehAIBwi9eY4J539LQHyvdZDZ0xgXggcd32043EdMOjbpI9WD3hQ9bDX1wa0ZKXg7NVK3FGuce4dDPbYJU+6KepsmJmFbrSFvEcOT6qOCH7bqWWr4LXRQ6/39tA/xdjWauiii5v8rJP6LA57MnTZVev6c3SCbjnoC8fV13if3tmJkVJXKwHsLP8Y7W90PxjiX0zFxiCI;\n\t25:KQVK8ppOHfM78sIX07BJGg3dYluIV2nCegHThx1zU7lthpWbN2sRc3ZeTrDeJPVnw0ta72HL3vCxQwY9v5/EoCj4oy6ar62Nu0edYZ+Lm9A5U1gN+8woowFN702b20LR5uNgKZppInLw15Ah0RrrMqW9rTX2LfY0vguAADLqqtGnAK7jvh9BQnvFJPJNd7InMTnlkb7OTLB00O33IUTjcDSPxqnYFaKgDLhc04POn7S+VCouW64jSzuyLojRQ3T4pYxfiDgBQIha0Oe6kzGAdndtSWK21hUHLKMcZd7oV3RcIwZbPfAjfsldPPp5l5oXy+xc3DZcOZKD0I3HhcP2+w==;\n\t31:wxx8fDEKEwmnlZmrMa8l4lRJLqhsANtRHq+E5iJgtro7DYX53REgc1Tubf2LWQCjwwTZ/0xvfSyrYR7UHCVJ+pGXV9gr8oIAY3jEF1K4u83LFfRghTkhTQOeqFKuKRalNiN+frK2Qv10eZk78qk1q+GV7hPvLxRSIJktj+nana+Is97xB+bTwA6GxoIC/cmDttqRwk0WxtZ9ai1hERlC+QtAZl0h950iTBlX4twPN3Y=", "1; VI1PR0901MB1439;\n\t4:g7QKSnN8+9vfBG14t7y1FVo6miD8dYHi19P++m9KcAnUzqdTvttX6qbNfA3hzfI8Mw+3jYkppKIry3Ik+sy6tQFrcXjnVRazgZ6ayJlVQHosm/GfhE4YB59jNfnovCoeJ3+RQMmqRR38m6xijioXrfGVK/r9uLmkqVR1kI/BJUSE7nemVWVUov/fIirNCi37hvJydrA7kjshfWgYntJqtHMY3MN6QhctRUN941a4MgLXPVcT7kqlbtDfpNMUXJutZLwJfoZiqT6S8u5aK3lvdw==", "=?us-ascii?Q?1; VI1PR0901MB1439;\n\t23:0rZd2ODZ/vCMfLJHDSykwPEPeuWQWnxJYssc0/l?=\n\t7xplMS/XS6VOh4QuQkyucDwW9i6CTi4Wwh0zVgNoX418rpcS/u9BBg52jTvC+9kHxSpaCiBaScrp+fyDNTXDBdg589ygn+B4hc3j9Kjw2oeuDJ9oUsvbtauD1kg3nBKUEFZTtiOdY3rYz8rlc7mycStcRnPGsueLa4DNd4ugUzqm1aPrXqeuPNn1V3bkdq+Ym+RS2nabHFGhO88rMasGxxpw5k8fi5pCup+jrwESVJ0SuG3d1c6pQEfQ8ZG3vUSmx4zkuIf1Wdkxfe0kpZO579+GOV6u2IK3qYwpQUfCEdN07cplTpjd0rh3pECkVxpPMJrGIEjcPuUhjhvj4SfFjj8oFqzr5xJjgOAZAu+S7d73o9rSXYqbcAxhzggefD+nZeGQ1lzFBA0Eoa08bqWsH54hwF+vay0A3jGrxW1pTg2Q+A99W6lQJykAVtzAYAFJXTD78WpkapX5XhW5c7fhABViBqRgXSlBIiWOJo9ZnEZG+Da4J2mHWfXN9Od8I8MswTQfZBxofuZk7D2GOL0EzCgYkJgGDaduY7mw9nqKSGyA168KE1zF1K9BkUhym70wU0E5QJBaOcE7A+cH4uixL/RPs5HebyWLo/FdCqZIhMybheNzaqE6vxcR+KNAF5+x5d9b/xFu7XmX218y+pCp4hpxXvDitu7t4yw/4biOJuaIWHD/heyvg6XdWuELWjaR9XpuetDxoQ0h69edPqGTanaoDEuG8I3DIErFv6O5uoRQ1MXIN+zHHM3IoXCQvYNSXCFzKlIi1ZJz3+NV2aOHz+n0cJyfu3gmEW4IVm0fTuXR/hIAdys0cJe4fVNw5VyVyBgw9kmG/2gDxWaG9wRk0CXYB5hND3nvBqZ1JrF7am9tKQIRnOn6/TOIkZRf1g7ley+gb8+3RFSh+hsJkjr5m/8X8ZcbOUIdgaE67mqZKxF3SdPWDD9Pgytx63lhRsJGVIubDnoSdCaW2suX2nvd3SucXhPohUroCIF1mPuEn6gGIDxH8PZWSU+HqCnzVpShri0UNaWxJAgvs8nS4yRgDfO13y4AWLureFCoUrsJfITT3RYCQ0ffQTwgP11CrkiDtMcXg4u84A615wiKTbLnVnm1lLgLGmt/xbJPwWuE/IdDgvUHZgIfNaOJutCKS5saEHKfQCSiYA/KAQxECBPSYIn1djLnC/YxrHyPvPMOo/o31Uw==", "1; VI1PR0901MB1439;\n\t6:b2HsW2QG8nn0Ai5MeHWftnESSrbCDyZxT+g/XWeplL016cNWAylvmWe2OkOguR3B44z3RTuJezf1/UtGu7Ip8hrExzuf/sjNHzM4+5F9xFFeveTS95YPcdh7SPIdMjS9T1aDvWcunR7TxOgcDT7VWnd5SIJ0niiefFoiLqpmPE8EJoGmBslyMWFCQ3ifcz85l2okuC1bUb6dZFqGGSpjsX5Php4PcJ17L6gu//XMJopmoU/fwM8wYi/kAGuV1t4/sbJdpeyQJW7F+BaEGjE1clU1++ZMDzYf7RwGLyXAyTa56olf+W26IBnb66SXhTr3v0oa9zmRuySj2KsU4kS3es9P7NpXOtAcJ/gdncXOblTknW85yjz9MmmNlycjgqa0rzvO6FwpNp1Ddf32lkakBASIqp9zJ3KGAocZ264sAIl3zPOquuHUrzTrN5BPsRHb5F1MQuUG/P4vkOE6XKrfJg==;\n\t5:X8Zp3jZQYmdkMWa9zc9fIBUSw12n74DgRbEzjaIfxVW8dSHUwq9ENbNEIGJ4zYB3hwqhGCeXLsRWMYE60j6ASY117pvQZfManLVp2OLX2qlOT9y0mIS1D+sIOXPV2EslDRvsZiwEAzNCowIMJwE1jgn6LfJ8CrKOpb8pt5gWL4k=;\n\t24:jf6N7Ep8WuglUThc9ptLWOoeH5n+mSrpks7HCn+7bvNn437Um+PFHkO9IG7C8egjtKOoHtF558xQ4r8E+xKkgW5s3PKPNsicVy+voEgLgyM=", "1; VI1PR0901MB1439;\n\t7:zvS6qlYDpzjXcO/VolYnm0PqpYK7hzhjYa21xqG65OIjbrzLN2AQSVFm46O9092yXThTPP/6EODXdzh2gBLVNlxvZO24lbG0unSpWhy79fN0kFlYfaWPYzHBTayV/UCMF7P6482JFMjhuTBcysMO9dpsaoAVKOA4wztsIIJtQr7tol+pLUN4MSj5MHorHEZ65pdSKka6SzjP0J6EMtN9DaEUClHuRSsPplImyjze79FlQDLzP8lLJH5W6ma7l7CD" ], "X-MS-TrafficTypeDiagnostic": "VI1PR0901MB1439:", "X-Microsoft-Antispam-PRVS": "<VI1PR0901MB14399971657F9F519F9BFC8ED6700@VI1PR0901MB1439.eurprd09.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(3002001)(10201501046)(149027)(150027)(6041310)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);\n\tSRVR:VI1PR0901MB1439; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0901MB1439; ", "X-Forefront-PRVS": "07083FF734", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10019020)(39840400004)(366004)(39380400002)(396003)(376002)(346002)(199004)(189003)(48376002)(86362001)(316002)(305945005)(51416003)(16586007)(53936002)(52116002)(486006)(476003)(2616005)(956004)(50466002)(478600001)(71446004)(72206003)(80792005)(106356001)(25786009)(8936002)(97736004)(4326008)(81166006)(105586002)(8676002)(81156014)(386003)(6506007)(26005)(186003)(16526019)(2906002)(7736002)(6916009)(5660300001)(66066001)(6666003)(36756003)(50226002)(6116002)(3846002)(68736007)(47776003)(6512007)(6486002)(86152003)(37156001);\n\tDIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR0901MB1439; H:ubuntu.localdomain;\n\tFPR:; \n\tSPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: cgstowernetworks.com does not\n\tdesignate permitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "iuexML23l3prgvO4fR2+evN7BLo7KiBYJh0mRZXJxgl/FWkfGvBXcuUi1V314viyTHy/MquFTWSg38S/8xLproZ0D41z/tFqKcloJYaY4/KqqfNX1lnow03EPPaPKCAbTn7hX+RvfN4hMFqZCGm7hkWDXujn+mZIjzaZCs8DKkxrMb6y3Fpejw2xgI9TdIoH3u6cbwuFxzTcyPC9kKVFpUkUDSL14JBvRYfldG/xXnIPsUsIH1SaIiEP2weIgLXDVGsWlS5U9HK3q/KvIuB0o3MhT1oHtlUlo1Z4q7abZyhcrZhKJu6sKjjXjo7ftX6k", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "cgstowernetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "19 Jun 2018 14:38:04.7772\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "07e17506-8d8b-4301-cc94-08d5d5f244b7", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fc9e9498-07e8-4b82-b4cf-365bba23cbbf", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VI1PR0901MB1439", "X-Mailman-Approved-At": "Wed, 20 Jun 2018 00:55:58 +0200", "Subject": "[dpdk-dev] [PATCH v2 1/2] net/pcap: multiple queues fix", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 4c173302c307 (\"pcap: add new driver\")\nCc: stable@dpdk.org\n\nChange open_rx/tx_pcap/iface functions to open only a single pcap/dumper\nand not loop num_of_queue times\nThe num_of_queue loop is already acheived by the caller rte_kvargs_process\n\nFixes:\n1. Opens N requested pcaps/dumpers instead of N^2\n2. Leak of pcap/dumper's which are being overwritten by\n the sequential calls to open_rx/tx_pcap/iface functions\n3. Use the filename/iface args per queue and not just the last one\n that overwrites the previous names\n\nSigned-off-by: ido goshen <ido@cgstowernetworks.com>\n---\nv2:\n* fix num of queues check\n---\n drivers/net/pcap/rte_eth_pcap.c | 86 +++++++++++++++++------------------------\n 1 file changed, 36 insertions(+), 50 deletions(-)", "diff": "diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c\nindex 6bd4a7d..b4f81ac 100644\n--- a/drivers/net/pcap/rte_eth_pcap.c\n+++ b/drivers/net/pcap/rte_eth_pcap.c\n@@ -665,19 +665,19 @@ struct pmd_devargs {\n static int\n open_rx_pcap(const char *key, const char *value, void *extra_args)\n {\n-\tunsigned int i;\n \tconst char *pcap_filename = value;\n \tstruct pmd_devargs *rx = extra_args;\n \tpcap_t *pcap = NULL;\n \n-\tfor (i = 0; i < rx->num_of_queue; i++) {\n-\t\tif (open_single_rx_pcap(pcap_filename, &pcap) < 0)\n-\t\t\treturn -1;\n+\tif (rx->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)\n+\t\treturn -1;\n+\tif (open_single_rx_pcap(pcap_filename, &pcap) < 0)\n+\t\treturn -1;\n \n-\t\trx->queue[i].pcap = pcap;\n-\t\trx->queue[i].name = pcap_filename;\n-\t\trx->queue[i].type = key;\n-\t}\n+\trx->queue[rx->num_of_queue].pcap = pcap;\n+\trx->queue[rx->num_of_queue].name = pcap_filename;\n+\trx->queue[rx->num_of_queue].type = key;\n+\trx->num_of_queue++;\n \n \treturn 0;\n }\n@@ -689,19 +689,19 @@ struct pmd_devargs {\n static int\n open_tx_pcap(const char *key, const char *value, void *extra_args)\n {\n-\tunsigned int i;\n \tconst char *pcap_filename = value;\n \tstruct pmd_devargs *dumpers = extra_args;\n \tpcap_dumper_t *dumper;\n \n-\tfor (i = 0; i < dumpers->num_of_queue; i++) {\n-\t\tif (open_single_tx_pcap(pcap_filename, &dumper) < 0)\n-\t\t\treturn -1;\n+\tif (dumpers->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)\n+\t\treturn -1;\n+\tif (open_single_tx_pcap(pcap_filename, &dumper) < 0)\n+\t\treturn -1;\n \n-\t\tdumpers->queue[i].dumper = dumper;\n-\t\tdumpers->queue[i].name = pcap_filename;\n-\t\tdumpers->queue[i].type = key;\n-\t}\n+\tdumpers->queue[dumpers->num_of_queue].dumper = dumper;\n+\tdumpers->queue[dumpers->num_of_queue].name = pcap_filename;\n+\tdumpers->queue[dumpers->num_of_queue].type = key;\n+\tdumpers->num_of_queue++;\n \n \treturn 0;\n }\n@@ -732,18 +732,18 @@ struct pmd_devargs {\n static inline int\n open_rx_iface(const char *key, const char *value, void *extra_args)\n {\n-\tunsigned int i;\n \tconst char *iface = value;\n \tstruct pmd_devargs *rx = extra_args;\n \tpcap_t *pcap = NULL;\n \n-\tfor (i = 0; i < rx->num_of_queue; i++) {\n-\t\tif (open_single_iface(iface, &pcap) < 0)\n-\t\t\treturn -1;\n-\t\trx->queue[i].pcap = pcap;\n-\t\trx->queue[i].name = iface;\n-\t\trx->queue[i].type = key;\n-\t}\n+\tif (rx->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)\n+\t\treturn -1;\n+\tif (open_single_iface(iface, &pcap) < 0)\n+\t\treturn -1;\n+\trx->queue[rx->num_of_queue].pcap = pcap;\n+\trx->queue[rx->num_of_queue].name = iface;\n+\trx->queue[rx->num_of_queue].type = key;\n+\trx->num_of_queue++;\n \n \treturn 0;\n }\n@@ -754,18 +754,18 @@ struct pmd_devargs {\n static int\n open_tx_iface(const char *key, const char *value, void *extra_args)\n {\n-\tunsigned int i;\n \tconst char *iface = value;\n \tstruct pmd_devargs *tx = extra_args;\n \tpcap_t *pcap;\n \n-\tfor (i = 0; i < tx->num_of_queue; i++) {\n-\t\tif (open_single_iface(iface, &pcap) < 0)\n-\t\t\treturn -1;\n-\t\ttx->queue[i].pcap = pcap;\n-\t\ttx->queue[i].name = iface;\n-\t\ttx->queue[i].type = key;\n-\t}\n+\tif (tx->num_of_queue >= RTE_PMD_PCAP_MAX_QUEUES)\n+\t\treturn -1;\n+\tif (open_single_iface(iface, &pcap) < 0)\n+\t\treturn -1;\n+\ttx->queue[tx->num_of_queue].pcap = pcap;\n+\ttx->queue[tx->num_of_queue].name = iface;\n+\ttx->queue[tx->num_of_queue].type = key;\n+\ttx->num_of_queue++;\n \n \treturn 0;\n }\n@@ -958,15 +958,8 @@ struct pmd_devargs {\n \t * We check whether we want to open a RX stream from a real NIC or a\n \t * pcap file\n \t */\n-\tpcaps.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG);\n-\tif (pcaps.num_of_queue)\n-\t\tis_rx_pcap = 1;\n-\telse\n-\t\tpcaps.num_of_queue = rte_kvargs_count(kvlist,\n-\t\t\t\tETH_PCAP_RX_IFACE_ARG);\n-\n-\tif (pcaps.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)\n-\t\tpcaps.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;\n+\tis_rx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_RX_PCAP_ARG) ? 1 : 0;\n+\tpcaps.num_of_queue = 0;\n \n \tif (is_rx_pcap)\n \t\tret = rte_kvargs_process(kvlist, ETH_PCAP_RX_PCAP_ARG,\n@@ -982,15 +975,8 @@ struct pmd_devargs {\n \t * We check whether we want to open a TX stream to a real NIC or a\n \t * pcap file\n \t */\n-\tdumpers.num_of_queue = rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG);\n-\tif (dumpers.num_of_queue)\n-\t\tis_tx_pcap = 1;\n-\telse\n-\t\tdumpers.num_of_queue = rte_kvargs_count(kvlist,\n-\t\t\t\tETH_PCAP_TX_IFACE_ARG);\n-\n-\tif (dumpers.num_of_queue > RTE_PMD_PCAP_MAX_QUEUES)\n-\t\tdumpers.num_of_queue = RTE_PMD_PCAP_MAX_QUEUES;\n+\tis_tx_pcap = rte_kvargs_count(kvlist, ETH_PCAP_TX_PCAP_ARG) ? 1 : 0;\n+\tdumpers.num_of_queue = 0;\n \n \tif (is_tx_pcap)\n \t\tret = rte_kvargs_process(kvlist, ETH_PCAP_TX_PCAP_ARG,\n", "prefixes": [ "v2", "1/2" ] }