Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41398,
    "url": "http://patchwork.dpdk.org/api/patches/41398/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180622133633.3476-1-remy.horton@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180622133633.3476-1-remy.horton@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180622133633.3476-1-remy.horton@intel.com",
    "date": "2018-06-22T13:36:33",
    "name": "[v1] examples/ipsec-secgw: fix use of unsupported RSS offloads",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "781b5559f367766df3de76cf7cdb4b3596162fd3",
    "submitter": {
        "id": 326,
        "url": "http://patchwork.dpdk.org/api/people/326/?format=api",
        "name": "Remy Horton",
        "email": "remy.horton@intel.com"
    },
    "delegate": {
        "id": 22,
        "url": "http://patchwork.dpdk.org/api/users/22/?format=api",
        "username": "pdelarag",
        "first_name": "Pablo",
        "last_name": "de Lara Guarch",
        "email": "pablo.de.lara.guarch@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180622133633.3476-1-remy.horton@intel.com/mbox/",
    "series": [
        {
            "id": 209,
            "url": "http://patchwork.dpdk.org/api/series/209/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=209",
            "date": "2018-06-22T13:36:33",
            "name": "[v1] examples/ipsec-secgw: fix use of unsupported RSS offloads",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/209/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41398/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/41398/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52C5E1BA5B;\n\tFri, 22 Jun 2018 15:37:42 +0200 (CEST)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 1F84E1B920\n\tfor <dev@dpdk.org>; Fri, 22 Jun 2018 15:37:40 +0200 (CEST)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jun 2018 06:36:37 -0700",
            "from rhorton-mobl1.ger.corp.intel.com (HELO FC23.ir.intel.com)\n\t([163.33.230.75])\n\tby fmsmga002.fm.intel.com with ESMTP; 22 Jun 2018 06:36:36 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,257,1526367600\"; d=\"scan'208\";a=\"60140623\"",
        "From": "Remy Horton <remy.horton@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Akhil Goyal <akhil.goyal@nxp.com>, Radu Nicolau <radu.nicolau@intel.com>",
        "Date": "Fri, 22 Jun 2018 14:36:33 +0100",
        "Message-Id": "<20180622133633.3476-1-remy.horton@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH v1] examples/ipsec-secgw: fix use of unsupported\n\tRSS offloads",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since commit aa1a6d87f15d (\"ethdev: force RSS offload rules again\")\na check that requested RSS offloads are supported by a PMD is\nenforced, whereas in the past asking for unsupported offloads would\nnot result in an error. This patch changes the IPSec gateway sample\nso that it only requests modes that are supported rather than\nfailing to start up.\n\nFixes: d299106e8e31 (\"examples/ipsec-secgw: add IPsec sample application\")\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n examples/ipsec-secgw/ipsec-secgw.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c\nindex a5da8b2..d247d5f 100644\n--- a/examples/ipsec-secgw/ipsec-secgw.c\n+++ b/examples/ipsec-secgw/ipsec-secgw.c\n@@ -1566,6 +1566,11 @@ port_init(uint16_t portid)\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)\n \t\tlocal_port_conf.txmode.offloads |=\n \t\t\tDEV_TX_OFFLOAD_MBUF_FAST_FREE;\n+\n+\t/* Only request RSS offloads the NIC supports. */\n+\tlocal_port_conf.rx_adv_conf.rss_conf.rss_hf &=\n+\t\tdev_info.flow_type_rss_offloads;\n+\n \tret = rte_eth_dev_configure(portid, nb_rx_queue, nb_tx_queue,\n \t\t\t&local_port_conf);\n \tif (ret < 0)\n",
    "prefixes": [
        "v1"
    ]
}