Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41415,
    "url": "http://patchwork.dpdk.org/api/patches/41415/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180622143147.5716-1-kevin.laatz@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180622143147.5716-1-kevin.laatz@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180622143147.5716-1-kevin.laatz@intel.com",
    "date": "2018-06-22T14:31:47",
    "name": "[v2] examples/ip_pipeline: add link show to the cli",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "6302cf7910601e6a50fec1dd8a2b66f15b152ee6",
    "submitter": {
        "id": 921,
        "url": "http://patchwork.dpdk.org/api/people/921/?format=api",
        "name": "Kevin Laatz",
        "email": "kevin.laatz@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patchwork.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180622143147.5716-1-kevin.laatz@intel.com/mbox/",
    "series": [
        {
            "id": 211,
            "url": "http://patchwork.dpdk.org/api/series/211/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=211",
            "date": "2018-06-22T14:31:47",
            "name": "[v2] examples/ip_pipeline: add link show to the cli",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/211/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41415/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/41415/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E64BB1BAB5;\n\tFri, 22 Jun 2018 16:32:04 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 32F3F1BAA7\n\tfor <dev@dpdk.org>; Fri, 22 Jun 2018 16:32:03 +0200 (CEST)",
            "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jun 2018 07:32:00 -0700",
            "from silpixa00397517.ir.intel.com (HELO\n\tsilpixa00397517.ger.corp.intel.com) ([10.237.222.54])\n\tby orsmga001.jf.intel.com with ESMTP; 22 Jun 2018 07:31:59 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,257,1526367600\"; d=\"scan'208\";a=\"66815857\"",
        "From": "Kevin Laatz <kevin.laatz@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "jasvinder.singh@intel.com, cristian.dumitrescu@intel.com,\n\tKevin Laatz <kevin.laatz@intel.com>",
        "Date": "Fri, 22 Jun 2018 15:31:47 +0100",
        "Message-Id": "<20180622143147.5716-1-kevin.laatz@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "In-Reply-To": "<20180608163053.37891-1-kevin.laatz@intel.com>",
        "References": "<20180608163053.37891-1-kevin.laatz@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v2] examples/ip_pipeline: add link show to the cli",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add the functionality to track links in the application. This enables the\nuser to print the name, mac address and statistics for each link\nin the application.\n\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nAcked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\n\n---\nv2:\n  - Implemeted API to iterate through the linked list\n  - Printing tidy up\n  - Removed unnecessary checks\n---\n examples/ip_pipeline/cli.c  | 91 +++++++++++++++++++++++++++++++++++++++++++++\n examples/ip_pipeline/link.c |  6 +++\n examples/ip_pipeline/link.h |  3 ++\n 3 files changed, 100 insertions(+)",
    "diff": "diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c\nindex c9587f5..27c9844 100644\n--- a/examples/ip_pipeline/cli.c\n+++ b/examples/ip_pipeline/cli.c\n@@ -9,6 +9,7 @@\n \n #include <rte_common.h>\n #include <rte_cycles.h>\n+#include <rte_ethdev.h>\n \n #include \"cli.h\"\n #include \"kni.h\"\n@@ -237,6 +238,91 @@ cmd_link(char **tokens,\n \t}\n }\n \n+/* Print the link stats and info */\n+static void\n+print_link_info(struct link *link, char *out, size_t out_size)\n+{\n+\tstruct rte_eth_stats stats;\n+\tstruct ether_addr mac_addr;\n+\tstruct rte_eth_link eth_link;\n+\tuint16_t mtu;\n+\n+\tmemset(&stats, 0, sizeof(stats));\n+\trte_eth_stats_get(link->port_id, &stats);\n+\n+\trte_eth_macaddr_get(link->port_id, &mac_addr);\n+\trte_eth_link_get(link->port_id, &eth_link);\n+\trte_eth_dev_get_mtu(link->port_id, &mtu);\n+\n+\tsnprintf(out, out_size,\n+\t\t\"\\n\"\n+\t\t\"%s: flags=<%s> mtu %u\\n\"\n+\t\t\"\\tether %02X:%02X:%02X:%02X:%02X:%02X rxqueues %u txqueues %u\\n\"\n+\t\t\"\\tport# %u  speed %u Mbps\\n\"\n+\t\t\"\\tRX packets %\" PRIu64\"  bytes %\" PRIu64\"\\n\"\n+\t\t\"\\tRX errors %\" PRIu64\"  missed %\" PRIu64\"  no-mbuf %\" PRIu64\"\\n\"\n+\t\t\"\\tTX packets %\" PRIu64\"  bytes %\" PRIu64\"\\n\"\n+\t\t\"\\tTX errors %\" PRIu64\"\\n\",\n+\t\tlink->name,\n+\t\teth_link.link_status == 0 ? \"DOWN\" : \"UP\",\n+\t\tmtu,\n+\t\tmac_addr.addr_bytes[0], mac_addr.addr_bytes[1],\n+\t\tmac_addr.addr_bytes[2], mac_addr.addr_bytes[3],\n+\t\tmac_addr.addr_bytes[4], mac_addr.addr_bytes[5],\n+\t\tlink->n_rxq,\n+\t\tlink->n_txq,\n+\t\tlink->port_id,\n+\t\teth_link.link_speed,\n+\t\tstats.ipackets,\n+\t\tstats.ibytes,\n+\t\tstats.ierrors,\n+\t\tstats.imissed,\n+\t\tstats.rx_nombuf,\n+\t\tstats.opackets,\n+\t\tstats.obytes,\n+\t\tstats.oerrors);\n+}\n+\n+/*\n+ * link show [<link_name>]\n+ */\n+static void\n+cmd_link_show(char **tokens, uint32_t n_tokens, char *out, size_t out_size)\n+{\n+\tstruct link *link;\n+\tchar *link_name;\n+\n+\tif (n_tokens != 2 && n_tokens != 3) {\n+\t\tsnprintf(out, out_size, MSG_ARG_MISMATCH, tokens[0]);\n+\t\treturn;\n+\t}\n+\n+\tif (n_tokens == 2) {\n+\t\tlink = link_next(NULL);\n+\n+\t\twhile (link != NULL) {\n+\t\t\tout_size = out_size - strlen(out);\n+\t\t\tout = &out[strlen(out)];\n+\n+\t\t\tprint_link_info(link, out, out_size);\n+\t\t\tlink = link_next(link);\n+\t\t}\n+\t} else {\n+\t\tout_size = out_size - strlen(out);\n+\t\tout = &out[strlen(out)];\n+\n+\t\tlink_name = tokens[2];\n+\t\tlink = link_find(link_name);\n+\n+\t\tif (link == NULL) {\n+\t\t\tsnprintf(out, out_size, MSG_ARG_INVALID,\n+\t\t\t\t\t\"Link does not exist\");\n+\t\t\treturn;\n+\t\t}\n+\t\tprint_link_info(link, out, out_size);\n+\t}\n+}\n+\n /**\n  * swq <swq_name>\n  *  size <size>\n@@ -4380,6 +4466,11 @@ cli_process(char *in, char *out, size_t out_size)\n \t}\n \n \tif (strcmp(tokens[0], \"link\") == 0) {\n+\t\tif (strcmp(tokens[1], \"show\") == 0) {\n+\t\t\tcmd_link_show(tokens, n_tokens, out, out_size);\n+\t\t\treturn;\n+\t\t}\n+\n \t\tcmd_link(tokens, n_tokens, out, out_size);\n \t\treturn;\n \t}\ndiff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c\nindex b8a431f..28a46d2 100644\n--- a/examples/ip_pipeline/link.c\n+++ b/examples/ip_pipeline/link.c\n@@ -36,6 +36,12 @@ link_find(const char *name)\n \treturn NULL;\n }\n \n+struct link *\n+link_next(struct link *link)\n+{\n+\treturn (link == NULL) ? TAILQ_FIRST(&link_list) : TAILQ_NEXT(link, node);\n+}\n+\n static struct rte_eth_conf port_conf_default = {\n \t.link_speeds = 0,\n \t.rxmode = {\ndiff --git a/examples/ip_pipeline/link.h b/examples/ip_pipeline/link.h\nindex 37d3dc4..34ff114 100644\n--- a/examples/ip_pipeline/link.h\n+++ b/examples/ip_pipeline/link.h\n@@ -30,6 +30,9 @@ link_init(void);\n struct link *\n link_find(const char *name);\n \n+struct link *\n+link_next(struct link *link);\n+\n struct link_params_rss {\n \tuint32_t queue_id[LINK_RXQ_RSS_MAX];\n \tuint32_t n_queues;\n",
    "prefixes": [
        "v2"
    ]
}