Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41427/?format=api
{ "id": 41427, "url": "http://patchwork.dpdk.org/api/patches/41427/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1529788834-18717-1-git-send-email-rasesh.mody@cavium.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529788834-18717-1-git-send-email-rasesh.mody@cavium.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529788834-18717-1-git-send-email-rasesh.mody@cavium.com", "date": "2018-06-23T21:20:31", "name": "[1/3] net/qede: fix unicast MAC address handling in VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "b7645b2690647155701f38d18f88190ac58e95f9", "submitter": { "id": 569, "url": "http://patchwork.dpdk.org/api/people/569/?format=api", "name": "Mody, Rasesh", "email": "rasesh.mody@cavium.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1529788834-18717-1-git-send-email-rasesh.mody@cavium.com/mbox/", "series": [ { "id": 214, "url": "http://patchwork.dpdk.org/api/series/214/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=214", "date": "2018-06-23T21:20:31", "name": "[1/3] net/qede: fix unicast MAC address handling in VF", "version": 1, "mbox": "http://patchwork.dpdk.org/series/214/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41427/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41427/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D65981BB42;\n\tSat, 23 Jun 2018 23:20:49 +0200 (CEST)", "from NAM04-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr700081.outbound.protection.outlook.com [40.107.70.81])\n\tby dpdk.org (Postfix) with ESMTP id 52B2B1BB3E;\n\tSat, 23 Jun 2018 23:20:48 +0200 (CEST)", "from cavium.com (198.186.0.2) by\n\tBL0PR07MB4017.namprd07.prod.outlook.com (2603:10b6:207:4b::19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.884.21; Sat, 23 Jun 2018 21:20:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=hQsWb/82ISFPvodOfaQds1YC81UijClEcfK5nkImbn4=;\n\tb=XIs7aBw+kaEAqOSA73nGeujm+qEwTci6oZ7k84qXnzNI6/SKRz7MsK2xNQjX3MXtKuuirdVe1PP6zRLYCvUhH280/ST9MOGGrNVDsSphGup+jVXEQV7lyGV5Gf6X62oTD1rnGscZTXLUWQaNIfm5Fzf8I8Lxlocc8eme4YnYXmY=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Rasesh.Mody@cavium.com; ", "From": "Rasesh Mody <rasesh.mody@cavium.com>", "To": "dev@dpdk.org", "Cc": "Shahed Shaikh <shahed.shaikh@cavium.com>, ferruh.yigit@intel.com,\n\tDept-EngDPDKDev@cavium.com, stable@dpdk.org", "Date": "Sat, 23 Jun 2018 14:20:31 -0700", "Message-Id": "<1529788834-18717-1-git-send-email-rasesh.mody@cavium.com>", "X-Mailer": "git-send-email 1.7.10.3", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[198.186.0.2]", "X-ClientProxiedBy": "BYAPR04CA0012.namprd04.prod.outlook.com\n\t(2603:10b6:a03:40::25) To BL0PR07MB4017.namprd07.prod.outlook.com\n\t(2603:10b6:207:4b::19)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652020)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600026)(711020)(2017052603328)(7153060)(7193020);\n\tSRVR:BL0PR07MB4017; ", "X-Microsoft-Exchange-Diagnostics": [ "1; BL0PR07MB4017;\n\t3:IGDaY7ESzpMuxJXfov4hnbyUioVu0C1BneT/163xKNVqTqoEKZL1QHyu3EhTBqFJrUVWmAUHy7VoRgQjY4mcf46I5kpgYL7QzjVW8FEfxueA0VQ61q4wB7UGWIb8GoE25RKqbpaH7LamHAeezlkqx6smHGjwCvs1WC8i+FdkVUdN1x0SU0jMCrwbhTYGqJBo+bpGIkxS2QdpVwhBltwNBuvw3VpuztHbW15FVrLeJX96lx1X6MgSK0F6MilY7/IK;\n\t25:B4hfK463JZdh6p7l0rJr/M5klqc6w+1r5D9Ps0hmfZa9WkVzrXEoTRMle5hwz6bfSeo0corTOOCvTKSXvPCjZo2WYa+kTmhMyoAEMgmi4rF2opIzIvN/A6yqNHH5w4KY7GVO0kJHasDUzYeI8Zy4oYPvplUDv+HpLcRh2Op1mCaSnwkTQl8+FgI/OOko+3PSQW+UISUnBw9ocypBhLDqggtsNn6pkQ/oeQOZ/csBc65hkb1qSyzjGd8Z6pvj0nym+q1sMueBMeJuHU+YkJ1tn/5scDaejVUHFxCLpwa4qdcj5AToU5EZuZuFZvnmusav7DTGck79w8Rc9zSkL+MxTA==;\n\t31:cevopkxk4uG9YYmhDMPrCz1f1WkAg8U0DeyzyTHLrYY9OdVe5NCP4J+Bx1/9S7GvknNqtxnuaS7zfwdb8gbSIFBQ7QWo+LsmTaNUHVPz1JqcWcj6uSMwYzUiCSFKRdqad+eX6I9jMqx/jcU29dsgSefOWubTBiSlSGpZXfpiZBAar3N4mr/YClmePXIcfpIsrXSZ+/ZdzrR2YUJMIeZqVxS5WidRSK7ZZrM6SeIgT/4=", "1; BL0PR07MB4017;\n\t20:MMxF1ObX4J0pnNWa8ADWLNH/UDvsStOcCxtSG8EBZqlg/NfMrqwJgz0MUYh2EAqzdeohp7c3nFGwZX1mJKs92KQ8PLjhYOpzdDZiObBdiRCPk15Rw7pJ5YEfsitPxAbt9NfWIqlhPkKJKydfkskZjq6qoAG14FBpheXLwvfOaMhE5lYiicehAJeEhIiohrV7NFjahoNXbK49ANkwNYRLSdvHbAwNuEiYl+TRoZqgDX4mhrwKailVz9Hs1FnN0LldC1ZRv6Ndk2YKQ6HWLjE/mI/qoxU/Pr3jRQSCSr1xN9pbO1xb9YFKaxEgdb6KgH8ZexmpL2Apsio//oiF2z20FgxDRXiETqQDrji+HIMpPt/MHsvS93Q4jlJjxJhfhV54XPb8ohIRhH/Qpm8ueMABXJYfktVO0CtNwuNpP8XLG6H/raxZqSaGjqdsa17FMumphrV3YKayo2Od2FapcvXjxcev9mpOo34oXzmYxsUD10MxAc0da3oDs3jrCDRcFem2;\n\t4:S5RNhQf2mmjK7Bigto3MfD79EbUJVjxacxVLLDnLGPa/K5qaXNKrFTWvnKxPr+UwmECDDn9SIidbprt7fOIemZmO0K1OxpoBoN3fVdVkOqpUatC10vR+WZWahSmKrAOQNuP5GTzb+z8BQGSTNmkj35HXUB81YCmbQihYT3TrFa4LdWrZRYrKCStSyO36yOnlWMJVCif1VgqPrsrtZbQxM7coYMhGAVb8W0Q4aQtztBDeiPwWzpOHFvNNKFVDKTq5zz6x9dydFr1dGwr620uJEg==", "=?us-ascii?Q?1; BL0PR07MB4017;\n\t23:smh5Ig5NN+6B5cKxdSf3UzPncs1VN1TBp5MUh+wm+?=\n\ts+xMaRY46BfMLqBnRxRKikl8v8wOCnpCCZw7U2ap45M2dh1ntA2L3iCDsBPkRIh/g+MBOvaP0vdwqq3oI5nK7Ba450ij1pLZZIs7HlJsdMIqVJwwkL8uxBDXJd2ev720UOlhfpNqne7EgyeO6IoxBq3lHNNJgw2b/SsmemveVInvcNB0J7KZ068JerSttenh3g0Tn9yTV7NNIIEjw8cREgAw6QiHFl5rbCufPhk4fGlHzlCrIfP4RkWl5J2IaAddcbzs+Rj8ok0AoHmLNnohD+LjN0zYj7n0fHecaBGPOWZbhCmK18IQMem8xGRtu7aT43HNOAobFfk9yVbLUw/I3TkZpWTVnLC3GM7IpU55Dhhgzpc9Zm5xX5nrGQOm8kIiu5eO4hV9HKg0XNU+ZgkA7WDh/GFBzfZ4KnBSgt3sxSG/0cszASmeFzua9mQKnCosfTX9AeUb5RCGVb3Wcn/XyRN2dHY7TEwog0iG18JD2eOL8Zh+9vLM8S+cyIpK/Kfv1xdkvWa62YXcB3zuTH+MH+Jr780iOiizDqugwIzBB8Db5TtoTyz20rp0TdywWypc8yS2of///N795cIjAVN91ctOeYkfwGpnHqrf4qTWJJIT+Q6jVYY+YPqCxm6nN+Y/XjIX+hJoYmO//iUev9gRFLg0sgPTpwFBxJ+1hG3JGB78p1XCOAq8xa92pe0DvVxyX9gwtZmMn1impxPWamd+HUs3SfE4t2tYQFD7s/ftR+dqhm+cQVarverkp7zShZEgeTaeGBIbGVSRx/yiXVyLfbMTZZcsIKT3+UIm/EFK7NUZMPaxhE0UOax67ZIuj51ud/KgR9ws9m9wzDeTaxUjmusL7oRqLD02On6WJOeEs3F3V8spLdsZ4nWE5WhiGxPuezgsuR5CZaVAwwaLv7CZgoLZAZlEDoQXnv/IPqnQ3hnwuoEnJnLRgc80E+v8g68xy0IPmpIVJnCFrwfTg9rNlfaTOOUiemtl/CbP3f9uClQB6cU3gfCDfOMQnAACS523ReJPjblkB5hoz6AkduzJfu1Gw1nd3yD4N8Q37tJInOsSQjNmOocpIPVs+Fzi+TN6RlYseakBvdZlGcvdHUgf5L2D1IKTaHwn0LApE7xlB00NPNI8GYBc93T9IRhwRD4OTy+7boG8YL0qTzlO6EU4orlJ3V7kf+K+1HuX+GPOXCq9786qkXYmuR8unDOppl8sLAxxIUTsTrjLhFOpqSS36Ky4uBo+BAED8Ifz9ihvNfE+1Jkna8k3VD2UJFMIUwMkTp2F8PRplKDus5Yqxy82zcxp7gRHBX2PKG414xyGe44olmDCEj/4XqYh8nccrAH/iY=", "1; BL0PR07MB4017;\n\t6:EhlvRwd4lraUHBjF4DjaH6pOwTEDhyDLn3Uic1J+Vk4Hf/fEKvjJOJPnw245FyALObXl8D+riAc5a9v0DA+2Q2duMEMBYnoBNjB29YFZIx9i6TUBhmQpqcmq2cKUnJc6rgnfaEnvVDY0Ps0bZJ7WMFfUV/EGk1AtDhOl70HLVMvKua+REwS8WyTi7DHJXcVqGGBkxv5axYGnPyWoyqy4wqbtHosugz3Ef9VWV9A+Kv7rmd2JU0VudJMS+P9dtx0zVFpjNox+kNLFLYXNy8egxNoTdAP/OTBTvGT9zsGWtcEDCsYat66+zwvtEaGWMLj2C8FdYrOnF01hH045azcLeMf0x4cci1ysM1PIRyR8tATAJUwAX+k+m6pdWtbzLXjcqss3DOGxRuSvIJgd7tVM8P+r7uyq+s/80eYErjNDD9IsMs1/st6yGSiLVpbZ125LJjmqbs1UKvXxFKhhJcgphg==;\n\t5:syd6x0ubiXBhitLmFVK/l7fxSxsp/UgNqEWigRRJkHpLc3VCxJduS6NEEnbOVFPot9LXgq7l7+2Bddq5/oAVpUakXtEOi7lbeZQAD6NpfZ6jp2QyhY61yRwxhuHEX0I8y058X35XLPPaUB7ANUdl23Q9eg5QCDenxYG4RS9ITQw=;\n\t24:v82cl5hxwCTgSBDSm5ehbYFRMTXyeNLhQjWR+az+L+Zda1M/VxlQ/sPwHs+zfren/TFN57sjclf/5I2s2FrVpYmxLoXZAYNLje7nB2zV5Ks=", "1; BL0PR07MB4017;\n\t7:Se5AgDoeSe0FztcdVxZ2u1M4AOlNZ6IdISGFVSO3LyNOyHsZilTHEvJ+ciM/CLC64juoC1qCW4xtGtxwyyirqjacPzc7ABtzLNwTHj+Soy/va2q2RsOmffg3vANGlpbD4TfipZBmqknQBVJxCDw9BQBXP82Ih4xFZpn/zdQBwJv0cPum3cR1cDUM4EJFuQ4Vx+lQlPDKJMvIqc03jYwRLUOOLYtSrpeP6ZI8Rxs0oji8PHHNpzQYEoLxBrPDBloi" ], "X-MS-TrafficTypeDiagnostic": "BL0PR07MB4017:", "X-Microsoft-Antispam-PRVS": "<BL0PR07MB401774F9BF6CCDE2A3E3D2789F740@BL0PR07MB4017.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:;", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231254)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016);\n\tSRVR:BL0PR07MB4017; BCL:0; PCL:0; RULEID:; SRVR:BL0PR07MB4017; ", "X-Forefront-PRVS": "07126E493C", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(979002)(366004)(396003)(346002)(39850400004)(376002)(39380400002)(189003)(199004)(16586007)(97736004)(2351001)(72206003)(21086003)(316002)(105586002)(2906002)(50466002)(25786009)(48376002)(478600001)(81166006)(86362001)(3846002)(81156014)(6116002)(2361001)(106356001)(8936002)(8676002)(7736002)(55016002)(305945005)(36756003)(26005)(66066001)(44832011)(186003)(50226002)(486006)(69596002)(59450400001)(386003)(53936002)(16526019)(956004)(2616005)(4720700003)(476003)(68736007)(6666003)(6916009)(5660300001)(51416003)(4326008)(7696005)(47776003)(52116002)(969003)(989001)(999001)(1009001)(1019001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BL0PR07MB4017; H:cavium.com; FPR:;\n\tSPF:None; \n\tLANG:en; PTR:InfoNoRecords; MX:1; A:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "wnrSddvQqjSJTuE1Sr9npTK2yf8KaNMzcAzQm5W4LbDHc1vei56e3bVO5FWogeehoqE3c858XTtaAo5KgXPNAG1UIq8ckmOB/PTlYEVpleghN7lXJdutLvRhM2cLpy1waXSs/drag//Oc1Qwu3/Mu/Qc5l7OWTRUW3arv9GVy1BmWl7TEGOPEmDnTwTU8zd7dnoEAp1aR92RwQk+yO3zJtVQkC4q63DE+w/ob0aeVxwDzxq0QCJEzJHn9nzxeeoWiJ1yoLAOfMH/+1E/cbynrYfZTWbhArmoxyF90JHaOGtQt89MrQbv6K1xPCh8l2ig++25Spg5PCwktl4/XGLsuA0i70YID5jrki1eXGcfpcg=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "cavium.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Jun 2018 21:20:44.6651\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d3bfbae4-2b2f-40f2-fed9-08d5d94f2ec1", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BL0PR07MB4017", "Subject": "[dpdk-dev] [PATCH 1/3] net/qede: fix unicast MAC address handling\n\tin VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Shahed Shaikh <shahed.shaikh@cavium.com>\n\nWe did not register unicast mac configuration handlers\nfor VF causing failure in bonding of VFs.\n\nAlso, mac_addr_set operation requires mac_remove followed\nby mad_add.\n\nFixes: 86a2265e59d7 (\"qede: add SRIOV support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>\n---\n drivers/net/qede/qede_ethdev.c | 17 ++++++++++++++---\n 1 file changed, 14 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex 7a63d05..1cae474 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -957,7 +957,11 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev)\n \tstruct ecore_filter_ucast ucast;\n \tint re;\n \n+\tif (!is_valid_assigned_ether_addr(mac_addr))\n+\t\treturn -EINVAL;\n+\n \tqede_set_ucast_cmn_params(&ucast);\n+\tucast.opcode = ECORE_FILTER_ADD;\n \tucast.type = ECORE_FILTER_MAC;\n \tether_addr_copy(mac_addr, (struct ether_addr *)&ucast.mac);\n \tre = (int)qede_mac_int_ops(eth_dev, &ucast, 1);\n@@ -979,6 +983,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev)\n \t\treturn;\n \t}\n \n+\tif (!is_valid_assigned_ether_addr(ð_dev->data->mac_addrs[index]))\n+\t\treturn;\n+\n \tqede_set_ucast_cmn_params(&ucast);\n \tucast.opcode = ECORE_FILTER_REMOVE;\n \tucast.type = ECORE_FILTER_MAC;\n@@ -1002,8 +1009,9 @@ static int qede_del_mcast_filters(struct rte_eth_dev *eth_dev)\n \t\treturn -EPERM;\n \t}\n \n-\tqede_mac_addr_add(eth_dev, mac_addr, 0, 0);\n-\treturn 0;\n+\tqede_mac_addr_remove(eth_dev, 0);\n+\n+\treturn qede_mac_addr_add(eth_dev, mac_addr, 0, 0);\n }\n \n static void qede_config_accept_any_vlan(struct qede_dev *qdev, bool flg)\n@@ -3024,6 +3032,9 @@ int qede_dev_filter_ctrl(struct rte_eth_dev *eth_dev,\n \t.mtu_set = qede_set_mtu,\n \t.udp_tunnel_port_add = qede_udp_dst_port_add,\n \t.udp_tunnel_port_del = qede_udp_dst_port_del,\n+\t.mac_addr_add = qede_mac_addr_add,\n+\t.mac_addr_remove = qede_mac_addr_remove,\n+\t.mac_addr_set = qede_mac_addr_set,\n };\n \n static void qede_update_pf_params(struct ecore_dev *edev)\n@@ -3188,7 +3199,7 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)\n \t\t\t\t\t\tECORE_LEADING_HWFN(edev),\n \t\t\t\t\t\tvf_mac,\n \t\t\t\t\t\t&is_mac_forced);\n-\t\t\tif (is_mac_exist && is_mac_forced) {\n+\t\t\tif (is_mac_exist) {\n \t\t\t\tDP_INFO(edev, \"VF macaddr received from PF\\n\");\n \t\t\t\tether_addr_copy((struct ether_addr *)&vf_mac,\n \t\t\t\t\t\tð_dev->data->mac_addrs[0]);\n", "prefixes": [ "1/3" ] }