Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41505/?format=api
{ "id": 41505, "url": "http://patchwork.dpdk.org/api/patches/41505/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1529976254-72268-1-git-send-email-wei.zhao1@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1529976254-72268-1-git-send-email-wei.zhao1@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1529976254-72268-1-git-send-email-wei.zhao1@intel.com", "date": "2018-06-26T01:24:14", "name": "[v2] net/ixgbe: fix Tx check descriptor status APIs error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d91d82810495164d8e2850ed0ce6a7e7dfb1742d", "submitter": { "id": 495, "url": "http://patchwork.dpdk.org/api/people/495/?format=api", "name": "Zhao1, Wei", "email": "wei.zhao1@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1529976254-72268-1-git-send-email-wei.zhao1@intel.com/mbox/", "series": [ { "id": 228, "url": "http://patchwork.dpdk.org/api/series/228/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=228", "date": "2018-06-26T01:24:14", "name": "[v2] net/ixgbe: fix Tx check descriptor status APIs error", "version": 2, "mbox": "http://patchwork.dpdk.org/series/228/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41505/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 000632C38;\n\tTue, 26 Jun 2018 03:45:11 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 5AFD02C19;\n\tTue, 26 Jun 2018 03:45:10 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2018 18:45:09 -0700", "from dpdk6.bj.intel.com ([172.16.182.94])\n\tby orsmga008.jf.intel.com with ESMTP; 25 Jun 2018 18:45:07 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,272,1526367600\"; d=\"scan'208\";a=\"52231957\"", "From": "Wei Zhao <wei.zhao1@intel.com>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, qi.z.zhang@intel.com, olivier.matz@6wind.com,\n\tstable@dpdk.org, Wei Zhao <wei.zhao1@intel.com>", "Date": "Tue, 26 Jun 2018 09:24:14 +0800", "Message-Id": "<1529976254-72268-1-git-send-email-wei.zhao1@intel.com>", "X-Mailer": "git-send-email 2.7.5", "In-Reply-To": "<1529656727-40207-1-git-send-email-wei.zhao1@intel.com>", "References": "<1529656727-40207-1-git-send-email-wei.zhao1@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/ixgbe: fix Tx check descriptor status\n\tAPIs error", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is an issue involve RS bit set rule in ixgbe.\nLet us take function ixgbe_xmit_pkts_vec () as an example,\nin this function RS bit will be set for descriptor with index\ntxq->tx_next_rs, and also descriptor free function\nixgbe_tx_free_bufs() also check RS bit for descriptor with index\ntxq->tx_next_rs, This is perfect ok. Let us take an example,\nif app set tx_rs_thresh = 32 and nb_desc = 512, then ixgbe PMD code\nwill init txq->tx_next_rs = 31 in function ixgbe_reset_tx_queue when\ntx queue setup. And also txq->tx_next_rs will be update as 63, 95\nand so on. But, in the function ixgbe_dev_tx_descriptor_status(),\nthe RS bit to check is \" desc = ((desc + txq->tx_rs_thresh - 1) /\ntxq->tx_rs_thresh) * txq-tx_rs_thresh\", which is 32 ,64, 96 and so on.\nSo, they are all wrong! In tx function of ixgbe_xmit_pkts_simple,\nthe RS bit rule is also the same, it also set index 31 ,64, 95.\nwe need to correct it.\n\nFixes: a2919e13d95e (\"net/ixgbe: implement descriptor status API\")\n\nSigned-off-by: Wei Zhao <wei.zhao1@intel.com>\n\n---\n\nv2:\n-add not support case for this feature\n---\n drivers/net/ixgbe/ixgbe_rxtx.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 3e13d26..087657c 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -3145,16 +3145,20 @@ ixgbe_dev_tx_descriptor_status(void *tx_queue, uint16_t offset)\n \tif (unlikely(offset >= txq->nb_tx_desc))\n \t\treturn -EINVAL;\n \n+\tif (rte_eth_devices[txq->port_id].tx_pkt_burst ==\n+\t\tixgbe_xmit_pkts)\n+\t\treturn -ENOTSUP;\n+\n \tdesc = txq->tx_tail + offset;\n+\tif (desc >= txq->nb_tx_desc)\n+\t\tdesc -= txq->nb_tx_desc;\n \t/* go to next desc that has the RS bit */\n-\tdesc = ((desc + txq->tx_rs_thresh - 1) / txq->tx_rs_thresh) *\n-\t\ttxq->tx_rs_thresh;\n-\tif (desc >= txq->nb_tx_desc) {\n+\tdesc = (desc / txq->tx_rs_thresh + 1) *\n+\t\t\ttxq->tx_rs_thresh - 1;\n+\tif (desc >= txq->nb_tx_desc)\n \t\tdesc -= txq->nb_tx_desc;\n-\t\tif (desc >= txq->nb_tx_desc)\n-\t\t\tdesc -= txq->nb_tx_desc;\n-\t}\n \n+\tdesc = txq->sw_ring[desc].last_id;\n \tstatus = &txq->tx_ring[desc].wb.status;\n \tif (*status & rte_cpu_to_le_32(IXGBE_ADVTXD_STAT_DD))\n \t\treturn RTE_ETH_TX_DESC_DONE;\n", "prefixes": [ "v2" ] }