Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41506/?format=api
{ "id": 41506, "url": "http://patchwork.dpdk.org/api/patches/41506/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180626021048.79280-1-roy.fan.zhang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180626021048.79280-1-roy.fan.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180626021048.79280-1-roy.fan.zhang@intel.com", "date": "2018-06-26T02:10:48", "name": "[v2] crypto/virtio: fix iv physical address", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c03e299ef8ae18332557ddc2e7d3508369763640", "submitter": { "id": 304, "url": "http://patchwork.dpdk.org/api/people/304/?format=api", "name": "Fan Zhang", "email": "roy.fan.zhang@intel.com" }, "delegate": { "id": 22, "url": "http://patchwork.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180626021048.79280-1-roy.fan.zhang@intel.com/mbox/", "series": [ { "id": 229, "url": "http://patchwork.dpdk.org/api/series/229/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=229", "date": "2018-06-26T02:10:48", "name": "[v2] crypto/virtio: fix iv physical address", "version": 2, "mbox": "http://patchwork.dpdk.org/series/229/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41506/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41506/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 938D52E81;\n\tTue, 26 Jun 2018 04:20:01 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 8AAAF2C15;\n\tTue, 26 Jun 2018 04:19:58 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Jun 2018 19:19:56 -0700", "from silpixa00398673.ir.intel.com (HELO\n\tsilpixa00398673.ger.corp.intel.com) ([10.237.223.54])\n\tby fmsmga005.fm.intel.com with ESMTP; 25 Jun 2018 19:19:55 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,272,1526367600\"; d=\"scan'208\";a=\"240260136\"", "From": "Fan Zhang <roy.fan.zhang@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, jianjay.zhou@huawei.com, stable@dpdk.org", "Date": "Tue, 26 Jun 2018 03:10:48 +0100", "Message-Id": "<20180626021048.79280-1-roy.fan.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20180614110257.10967-1-roy.fan.zhang@intel.com>", "References": "<20180614110257.10967-1-roy.fan.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] crypto/virtio: fix iv physical address", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The physical address of IV required by Virtio was computed using\ncrypto operations' physical address plus the offset. However not\nall crypto ops will have physical address field initialized and\ncompute it runtimely is costly. This patch fixes this problem by\nadding iv field in virtio_crypto_op_cookie and does a memcpy of\niv instead.\n\nFixes: 82adb12a1fce (\"crypto/virtio: support burst enqueue/dequeue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Fan Zhang <roy.fan.zhang@intel.com>\n---\n\nv2:\n- change max iv size to 16\n- use branch to avoid unnecessary memcpy\n\n drivers/crypto/virtio/virtio_cryptodev.c | 6 ++++++\n drivers/crypto/virtio/virtio_cryptodev.h | 3 +++\n drivers/crypto/virtio/virtio_rxtx.c | 14 +++++++++++++-\n 3 files changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c\nindex df88953f6..6ffa7619c 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.c\n+++ b/drivers/crypto/virtio/virtio_cryptodev.c\n@@ -1223,6 +1223,12 @@ virtio_crypto_sym_pad_op_ctrl_req(\n \t/* Get cipher xform from crypto xform chain */\n \tcipher_xform = virtio_crypto_get_cipher_xform(xform);\n \tif (cipher_xform) {\n+\t\tif (cipher_xform->iv.length > VIRTIO_CRYPTO_MAX_IV_SIZE) {\n+\t\t\tVIRTIO_CRYPTO_SESSION_LOG_ERR(\n+\t\t\t\t\"cipher IV cannot longer than %u\",\n+\t\t\t\tVIRTIO_CRYPTO_MAX_IV_SIZE);\n+\t\t\treturn -1;\n+\t\t}\n \t\tif (is_chainned)\n \t\t\tret = virtio_crypto_sym_pad_cipher_param(\n \t\t\t\t&ctrl->u.sym_create_session.u.chain.para\ndiff --git a/drivers/crypto/virtio/virtio_cryptodev.h b/drivers/crypto/virtio/virtio_cryptodev.h\nindex e402c0309..0fd7b722e 100644\n--- a/drivers/crypto/virtio/virtio_cryptodev.h\n+++ b/drivers/crypto/virtio/virtio_cryptodev.h\n@@ -16,6 +16,8 @@\n \n #define NUM_ENTRY_VIRTIO_CRYPTO_OP 7\n \n+#define VIRTIO_CRYPTO_MAX_IV_SIZE 16\n+\n extern uint8_t cryptodev_virtio_driver_id;\n \n enum virtio_crypto_cmd_id {\n@@ -29,6 +31,7 @@ struct virtio_crypto_op_cookie {\n \tstruct virtio_crypto_op_data_req data_req;\n \tstruct virtio_crypto_inhdr inhdr;\n \tstruct vring_desc desc[NUM_ENTRY_VIRTIO_CRYPTO_OP];\n+\tuint8_t iv[VIRTIO_CRYPTO_MAX_IV_SIZE];\n };\n \n /*\ndiff --git a/drivers/crypto/virtio/virtio_rxtx.c b/drivers/crypto/virtio/virtio_rxtx.c\nindex 450392843..4f695f3e6 100644\n--- a/drivers/crypto/virtio/virtio_rxtx.c\n+++ b/drivers/crypto/virtio/virtio_rxtx.c\n@@ -203,6 +203,8 @@ virtqueue_crypto_sym_enqueue_xmit(\n \tuint16_t req_data_len = sizeof(struct virtio_crypto_op_data_req);\n \tuint32_t indirect_vring_addr_offset = req_data_len +\n \t\tsizeof(struct virtio_crypto_inhdr);\n+\tuint32_t indirect_iv_addr_offset = indirect_vring_addr_offset +\n+\t\t\tsizeof(struct vring_desc) * NUM_ENTRY_VIRTIO_CRYPTO_OP;\n \tstruct rte_crypto_sym_op *sym_op = cop->sym;\n \tstruct virtio_crypto_session *session =\n \t\t(struct virtio_crypto_session *)get_session_private_data(\n@@ -259,7 +261,17 @@ virtqueue_crypto_sym_enqueue_xmit(\n \n \t/* indirect vring: iv of cipher */\n \tif (session->iv.length) {\n-\t\tdesc[idx].addr = cop->phys_addr + session->iv.offset;\n+\t\tif (cop->phys_addr)\n+\t\t\tdesc[idx].addr = cop->phys_addr + session->iv.offset;\n+\t\telse {\n+\t\t\trte_memcpy(crypto_op_cookie->iv,\n+\t\t\t\t\trte_crypto_op_ctod_offset(cop,\n+\t\t\t\t\tuint8_t *, session->iv.offset),\n+\t\t\t\t\tsession->iv.length);\n+\t\t\tdesc[idx].addr = indirect_op_data_req_phys_addr +\n+\t\t\t\tindirect_iv_addr_offset;\n+\t\t}\n+\n \t\tdesc[idx].len = session->iv.length;\n \t\tdesc[idx++].flags = VRING_DESC_F_NEXT;\n \t}\n", "prefixes": [ "v2" ] }