Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41552/?format=api
{ "id": 41552, "url": "http://patchwork.dpdk.org/api/patches/41552/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180626113807.67100-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180626113807.67100-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180626113807.67100-1-ferruh.yigit@intel.com", "date": "2018-06-26T11:38:07", "name": "[v3] kni: fix build with gcc 8.1", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "f3daf175a1e6b6a87a904e275e64a6fb1920597b", "submitter": { "id": 324, "url": "http://patchwork.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180626113807.67100-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 237, "url": "http://patchwork.dpdk.org/api/series/237/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=237", "date": "2018-06-26T11:38:07", "name": "[v3] kni: fix build with gcc 8.1", "version": 3, "mbox": "http://patchwork.dpdk.org/series/237/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41552/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/41552/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C9D9A1B51B;\n\tTue, 26 Jun 2018 12:38:40 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 44C031B4D0;\n\tTue, 26 Jun 2018 12:38:37 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 03:38:37 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby fmsmga007.fm.intel.com with ESMTP; 26 Jun 2018 03:38:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"49979389\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org, stephen@networkplumber.org, pablo.de.lara.guarch@intel.com,\n\tstable@dpdk.org", "Date": "Tue, 26 Jun 2018 12:38:07 +0100", "Message-Id": "<20180626113807.67100-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<07e4d536-edd6-292d-5adb-c05793731623@intel.com>", "References": "<07e4d536-edd6-292d-5adb-c05793731623@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3] kni: fix build with gcc 8.1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is\nenabled.\n\nbuild error:\nIn function ‘strncpy’,\n inlined from ‘igb_get_drvinfo’ at\n .../dpdk/build/build/kernel/linux/kni/igb_ethtool.c:814:2:\n .../include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output\n may be truncated copying 31 bytes from a string of length 42\n [-Werror=stringop-truncation]\n return __builtin_strncpy(p, q, size);\n ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\nFixed by using strlcpy instead of strncpy.\n\nadapter->fw_version size kept same because of\nc3698192940c (\"kni: fix build with gcc 7.1\")\n\nAlso next line strncpy usage replaced with strlcpy while arround.\n\nFixes: c3698192940c (\"kni: fix build with gcc 7.1\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\nv2:\n* used strlcpy instead of strncpy\n* Updated strncpy usage in next line to strlcpy too\n* Added fixes line\n\nv3:\n* fix patch syntax corrupted during send\n---\n kernel/linux/kni/ethtool/igb/igb_ethtool.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/kernel/linux/kni/ethtool/igb/igb_ethtool.c b/kernel/linux/kni/ethtool/igb/igb_ethtool.c\nindex 064528bcf..002f75c48 100644\n--- a/kernel/linux/kni/ethtool/igb/igb_ethtool.c\n+++ b/kernel/linux/kni/ethtool/igb/igb_ethtool.c\n@@ -811,9 +811,10 @@ static void igb_get_drvinfo(struct net_device *netdev,\n \tstrncpy(drvinfo->driver, igb_driver_name, sizeof(drvinfo->driver) - 1);\n \tstrncpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version) - 1);\n \n-\tstrncpy(drvinfo->fw_version, adapter->fw_version,\n-\t\tsizeof(drvinfo->fw_version) - 1);\n-\tstrncpy(drvinfo->bus_info, pci_name(adapter->pdev), sizeof(drvinfo->bus_info) -1);\n+\tstrlcpy(drvinfo->fw_version, adapter->fw_version,\n+\t\tsizeof(drvinfo->fw_version));\n+\tstrlcpy(drvinfo->bus_info, pci_name(adapter->pdev),\n+\t\tsizeof(drvinfo->bus_info));\n \tdrvinfo->n_stats = IGB_STATS_LEN;\n \tdrvinfo->testinfo_len = IGB_TEST_LEN;\n \tdrvinfo->regdump_len = igb_get_regs_len(netdev);\n", "prefixes": [ "v3" ] }