Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41572,
    "url": "http://patchwork.dpdk.org/api/patches/41572/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530019540-27680-1-git-send-email-alejandro.lucero@netronome.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1530019540-27680-1-git-send-email-alejandro.lucero@netronome.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1530019540-27680-1-git-send-email-alejandro.lucero@netronome.com",
    "date": "2018-06-26T13:25:40",
    "name": "net/nfp: avoid sysfs resource file access",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9243580cf2a6a34765a5f1d3f2f348c748d39792",
    "submitter": {
        "id": 270,
        "url": "http://patchwork.dpdk.org/api/people/270/?format=api",
        "name": "Alejandro Lucero",
        "email": "alejandro.lucero@netronome.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530019540-27680-1-git-send-email-alejandro.lucero@netronome.com/mbox/",
    "series": [
        {
            "id": 243,
            "url": "http://patchwork.dpdk.org/api/series/243/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=243",
            "date": "2018-06-26T13:25:40",
            "name": "net/nfp: avoid sysfs resource file access",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/243/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41572/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/41572/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7666D1B5C5;\n\tTue, 26 Jun 2018 15:26:08 +0200 (CEST)",
            "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id 42CC51B5C5\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 15:26:07 +0200 (CEST)",
            "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw5QDPeNC027720 for <dev@dpdk.org>; Tue, 26 Jun 2018 14:25:40 +0100",
            "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w5QDPeBS027719\n\tfor dev@dpdk.org; Tue, 26 Jun 2018 14:25:40 +0100"
        ],
        "From": "Alejandro Lucero <alejandro.lucero@netronome.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 26 Jun 2018 14:25:40 +0100",
        "Message-Id": "<1530019540-27680-1-git-send-email-alejandro.lucero@netronome.com>",
        "X-Mailer": "git-send-email 1.9.1",
        "Subject": "[dpdk-dev] [PATCH] net/nfp: avoid sysfs resource file access",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Getting the bar size is required for NFP CPP interface configuration.\nHowever, this information can be obtained from the VFIO or UIO driver\ninstead of accessing the sysfs resource file.\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c | 27 +++++----------------------\n 1 file changed, 5 insertions(+), 22 deletions(-)",
    "diff": "diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\nindex 2a1ec96..b0beb8d 100644\n--- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n+++ b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c\n@@ -762,33 +762,16 @@ struct nfp6000_area_priv {\n }\n \n static int\n-nfp6000_set_barsz(struct nfp_pcie_user *desc)\n+nfp6000_set_barsz(struct rte_pci_device *dev, struct nfp_pcie_user *desc)\n {\n-\tchar tmp_str[80];\n-\tunsigned long start, end, flags, tmp;\n-\tint i;\n-\tFILE *fp;\n-\n-\tsnprintf(tmp_str, sizeof(tmp_str), \"%s/%s/resource\", PCI_DEVICES,\n-\t\t desc->busdev);\n-\n-\tfp = fopen(tmp_str, \"r\");\n-\tif (!fp)\n-\t\treturn -1;\n+\tunsigned long tmp;\n+\tint i = 0;\n \n-\tif (fscanf(fp, \"0x%lx 0x%lx 0x%lx\", &start, &end, &flags) == 0) {\n-\t\tprintf(\"error reading resource file for bar size\\n\");\n-\t\tfclose(fp);\n-\t\treturn -1;\n-\t}\n+\ttmp = dev->mem_resource[0].len;\n \n-\tif (fclose(fp) == -1)\n-\t\treturn -1;\n-\n-\ttmp = (end - start) + 1;\n-\ti = 0;\n \twhile (tmp >>= 1)\n \t\ti++;\n+\n \tdesc->barsz = i;\n \treturn 0;\n }\n",
    "prefixes": []
}