Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41574/?format=api
{ "id": 41574, "url": "http://patchwork.dpdk.org/api/patches/41574/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530027372-24233-1-git-send-email-jia.guo@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530027372-24233-1-git-send-email-jia.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530027372-24233-1-git-send-email-jia.guo@intel.com", "date": "2018-06-26T15:36:09", "name": "[V3,1/4] bus/pci: handle device hot unplug", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d3f8d100b08eddea87efce970d1e87b9964fc436", "submitter": { "id": 507, "url": "http://patchwork.dpdk.org/api/people/507/?format=api", "name": "Guo, Jia", "email": "jia.guo@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530027372-24233-1-git-send-email-jia.guo@intel.com/mbox/", "series": [ { "id": 245, "url": "http://patchwork.dpdk.org/api/series/245/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=245", "date": "2018-06-26T15:36:09", "name": "[V3,1/4] bus/pci: handle device hot unplug", "version": 3, "mbox": "http://patchwork.dpdk.org/series/245/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41574/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41574/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C2F961BAE4;\n\tTue, 26 Jun 2018 17:38:28 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 170BD1B90B\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 17:38:26 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 08:38:26 -0700", "from jeffguo-z170x-ud5.sh.intel.com (HELO localhost.localdomain)\n\t([10.67.104.10])\n\tby orsmga008.jf.intel.com with ESMTP; 26 Jun 2018 08:38:22 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"52398082\"", "From": "Jeff Guo <jia.guo@intel.com>", "To": "stephen@networkplumber.org, bruce.richardson@intel.com,\n\tferruh.yigit@intel.com, konstantin.ananyev@intel.com,\n\tgaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,\n\tmotih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,\n\tqi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com", "Cc": "jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,\n\tjia.guo@intel.com, helin.zhang@intel.com", "Date": "Tue, 26 Jun 2018 23:36:09 +0800", "Message-Id": "<1530027372-24233-1-git-send-email-jia.guo@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1498711073-42917-1-git-send-email-jia.guo@intel.com>", "References": "<1498711073-42917-1-git-send-email-jia.guo@intel.com>", "Subject": "[dpdk-dev] [PATCH V3 1/4] bus/pci: handle device hot unplug", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When a hardware device is removed physically or the software disables\nit, the hot unplug occur. App need to call ether dev API to detach the\ndevice, to unplug the device at the bus level and make access to the device\ninvalid. But the problem is that, the removal of the device from the\nsoftware lists is not going to be instantaneous, at this time if the data\npath still read/write the device, it will cause MMIO error and result of\nthe app crash out. So a hot unplug handle mechanism need to guaranty app\nwill not crash out when hot unplug device.\n\nTo handle device hot unplug is bus-specific behavior, this patch introduces\na bus ops so that each kind of bus can implement its own logic. Further,\nthis patch implements the ops for PCI bus: remap a dummy memory to avoid\nbus read/write error.\n\nSigned-off-by: Jeff Guo <jia.guo@intel.com>\n---\nv3->v2:\nchange bus ops name to bus_hotplug_handler.\n---\n drivers/bus/pci/pci_common.c | 34 +++++++++++++++++++++++++++++++++\n drivers/bus/pci/pci_common_uio.c | 33 ++++++++++++++++++++++++++++++++\n drivers/bus/pci/private.h | 12 ++++++++++++\n lib/librte_eal/common/include/rte_bus.h | 14 ++++++++++++++\n 4 files changed, 93 insertions(+)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 7215aae..e607d08 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -473,6 +473,39 @@ pci_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,\n }\n \n static int\n+pci_hotplug_handler(struct rte_device *dev)\n+{\n+\tstruct rte_pci_device *pdev = NULL;\n+\tint ret = 0;\n+\n+\tpdev = RTE_DEV_TO_PCI(dev);\n+\tif (!pdev)\n+\t\treturn -1;\n+\n+\t/* remap resources for devices */\n+\tswitch (pdev->kdrv) {\n+\tcase RTE_KDRV_VFIO:\n+#ifdef VFIO_PRESENT\n+\t\t/* TODO */\n+\t\tret = -1;\n+#endif\n+\t\tbreak;\n+\tcase RTE_KDRV_IGB_UIO:\n+\tcase RTE_KDRV_UIO_GENERIC:\n+\tcase RTE_KDRV_NIC_UIO:\n+\t\tret = pci_uio_remap_resource(pdev);\n+\t\tbreak;\n+\tdefault:\n+\t\tRTE_LOG(DEBUG, EAL,\n+\t\t\t\"Not managed by a supported kernel driver, skipped\\n\");\n+\t\tret = -1;\n+\t\tbreak;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int\n pci_plug(struct rte_device *dev)\n {\n \treturn pci_probe_all_drivers(RTE_DEV_TO_PCI(dev));\n@@ -502,6 +535,7 @@ struct rte_pci_bus rte_pci_bus = {\n \t\t.unplug = pci_unplug,\n \t\t.parse = pci_parse,\n \t\t.get_iommu_class = rte_pci_get_iommu_class,\n+\t\t.hotplug_handler = pci_hotplug_handler,\n \t},\n \t.device_list = TAILQ_HEAD_INITIALIZER(rte_pci_bus.device_list),\n \t.driver_list = TAILQ_HEAD_INITIALIZER(rte_pci_bus.driver_list),\ndiff --git a/drivers/bus/pci/pci_common_uio.c b/drivers/bus/pci/pci_common_uio.c\nindex 54bc20b..7ea73db 100644\n--- a/drivers/bus/pci/pci_common_uio.c\n+++ b/drivers/bus/pci/pci_common_uio.c\n@@ -146,6 +146,39 @@ pci_uio_unmap(struct mapped_pci_resource *uio_res)\n \t}\n }\n \n+/* remap the PCI resource of a PCI device in anonymous virtual memory */\n+int\n+pci_uio_remap_resource(struct rte_pci_device *dev)\n+{\n+\tint i;\n+\tvoid *map_address;\n+\n+\tif (dev == NULL)\n+\t\treturn -1;\n+\n+\t/* Remap all BARs */\n+\tfor (i = 0; i != PCI_MAX_RESOURCE; i++) {\n+\t\t/* skip empty BAR */\n+\t\tif (dev->mem_resource[i].phys_addr == 0)\n+\t\t\tcontinue;\n+\t\tmap_address = mmap(dev->mem_resource[i].addr,\n+\t\t\t\t(size_t)dev->mem_resource[i].len,\n+\t\t\t\tPROT_READ | PROT_WRITE,\n+\t\t\t\tMAP_PRIVATE | MAP_ANONYMOUS | MAP_FIXED, -1, 0);\n+\t\tif (map_address == MAP_FAILED) {\n+\t\t\tRTE_LOG(ERR, EAL,\n+\t\t\t\t\"Cannot remap resource for device %s\\n\",\n+\t\t\t\tdev->name);\n+\t\t\treturn -1;\n+\t\t}\n+\t\tRTE_LOG(INFO, EAL,\n+\t\t\t\"Successful remap resource for device %s\\n\",\n+\t\t\tdev->name);\n+\t}\n+\n+\treturn 0;\n+}\n+\n static struct mapped_pci_resource *\n pci_uio_find_resource(struct rte_pci_device *dev)\n {\ndiff --git a/drivers/bus/pci/private.h b/drivers/bus/pci/private.h\nindex 88fa587..5551506 100644\n--- a/drivers/bus/pci/private.h\n+++ b/drivers/bus/pci/private.h\n@@ -173,6 +173,18 @@ void pci_uio_free_resource(struct rte_pci_device *dev,\n \t\tstruct mapped_pci_resource *uio_res);\n \n /**\n+ * Remap the PCI resource of a PCI device in anonymous virtual memory.\n+ *\n+ * @param dev\n+ * Point to the struct rte pci device.\n+ * @return\n+ * - On success, zero.\n+ * - On failure, a negative value.\n+ */\n+int\n+pci_uio_remap_resource(struct rte_pci_device *dev);\n+\n+/**\n * Map device memory to uio resource\n *\n * This function is private to EAL.\ndiff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h\nindex eb9eded..6507f24 100644\n--- a/lib/librte_eal/common/include/rte_bus.h\n+++ b/lib/librte_eal/common/include/rte_bus.h\n@@ -168,6 +168,19 @@ typedef int (*rte_bus_unplug_t)(struct rte_device *dev);\n typedef int (*rte_bus_parse_t)(const char *name, void *addr);\n \n /**\n+ * Implementation a specific hot plug handler, which is responsible\n+ * for handle the failure when hot remove the device, guaranty the system\n+ * would not crash in the case.\n+ * @param dev\n+ *\tPointer of the device structure.\n+ *\n+ * @return\n+ *\t0 on success.\n+ *\t!0 on error.\n+ */\n+typedef int (*rte_bus_hotplug_handler_t)(struct rte_device *dev);\n+\n+/**\n * Bus scan policies\n */\n enum rte_bus_scan_mode {\n@@ -211,6 +224,7 @@ struct rte_bus {\n \trte_bus_parse_t parse; /**< Parse a device name */\n \tstruct rte_bus_conf conf; /**< Bus configuration */\n \trte_bus_get_iommu_class_t get_iommu_class; /**< Get iommu class */\n+\trte_bus_hotplug_handler_t hotplug_handler; /**< handle hot plug on bus */\n };\n \n /**\n", "prefixes": [ "V3", "1/4" ] }