Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41580,
    "url": "http://patchwork.dpdk.org/api/patches/41580/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/153002995700.22089.6499516015793208840.stgit@T460/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<153002995700.22089.6499516015793208840.stgit@T460>",
    "list_archive_url": "https://inbox.dpdk.org/dev/153002995700.22089.6499516015793208840.stgit@T460",
    "date": "2018-06-26T16:19:17",
    "name": "[v1,2/5] vhost: make message handling functions prepare the reply",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b69e1148f0c2bc727c0b61b9270b000a454a660c",
    "submitter": {
        "id": 1062,
        "url": "http://patchwork.dpdk.org/api/people/1062/?format=api",
        "name": "Nikolay Nikolaev",
        "email": "nicknickolaev@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "http://patchwork.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/153002995700.22089.6499516015793208840.stgit@T460/mbox/",
    "series": [
        {
            "id": 246,
            "url": "http://patchwork.dpdk.org/api/series/246/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=246",
            "date": "2018-06-26T16:19:02",
            "name": "vhost_user.c code cleanup",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/246/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41580/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/41580/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0D5071BB37;\n\tTue, 26 Jun 2018 18:19:21 +0200 (CEST)",
            "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 4C52D1B901\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 18:19:19 +0200 (CEST)",
            "by mail-wm0-f65.google.com with SMTP id u18-v6so2488102wmc.1\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 09:19:19 -0700 (PDT)",
            "from [127.0.1.1] ([82.146.27.14]) by smtp.gmail.com with ESMTPSA id\n\tn10-v6sm2973138wrs.64.2018.06.26.09.19.17\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 26 Jun 2018 09:19:18 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=subject:from:to:cc:date:message-id:in-reply-to:references\n\t:user-agent:mime-version:content-transfer-encoding;\n\tbh=of+2Ji+OknmxObvfuCoPCYZwA7RB2jj3EFPLZN0ePgY=;\n\tb=O3w0fyCJYfuoPcBK+lvvzV5iDsB4B7SgkJcuKmKQ6AD/JZVWznDwHnHt53FzbC4EK+\n\tOCZAOZFiMvx1FFGcJlXCJIsuahosidneRk5bUZskW1aJseg4QoYZ1MtkX4U1K26ll/+i\n\tr5XiiOW05xJE9qIC2YgRJ11xC0bApqOwtubUlwSDPeqBofFBWBLRl3HmqnZwI4ZJUkXI\n\toTM4MG3qlcu4f032mgpEH2/kviHswf3Dzu8LEFrim8mdkUQRnW5POO6nUQEkyIUFDQwK\n\tRsFSYa/5uXvmXjA+7H2+4Bsikb7m1Y/uriJJFPJ95rIjKXrmykDyul+zvBr9QCrkYrx8\n\tOFKw==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:subject:from:to:cc:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=of+2Ji+OknmxObvfuCoPCYZwA7RB2jj3EFPLZN0ePgY=;\n\tb=Bkkvyvh/8H4jaylGeilOpScxHZQcuR2GA1UpV3Sp47cSbTqsEvAUtIRe5xfq6DWQ4l\n\tYz1/ICqCJ5y0PsCuwqjMe0SiHEretDE6/q7ZYAhC2xj0qqVDTrURMxfGaQbtXutcWxHh\n\tMJ+ZQH3klVXeqzG4TtQr+eBRCxl4PMntjkJH2tn2rg6NJEP975Exo/z+oNKGXO0Fg6Xx\n\tgI9P2nQwvh/3KFauzL28IkCmKQ3gMuwNyLBJ9Jz+PJ8p92NwJbPHcc6OS9aDiduC8TDs\n\tUlEhEmJXQXHsFD51IJIAvRKHuayNKvvmPQfcACuz6ALV+95NgO6x4Fps4kCwi7AAbhYw\n\tja8A==",
        "X-Gm-Message-State": "APt69E3oVMNxFIIfYEc5tCkjvTmFNEBnsGAa4C3DOJUJPnLJSMVJS211\n\tUy7ti7vzJeJgUkEsVyhc6A3X0Qme",
        "X-Google-Smtp-Source": "AAOMgpfYKWRzTpeT7NMn/4Z3Gnx6TneolTs8wr2kGT/q7JjmesKkNG5rhj/PXxdKnIeBXL3j/PDznA==",
        "X-Received": "by 2002:a1c:6b56:: with SMTP id\n\tg83-v6mr2191407wmc.143.1530029958757; \n\tTue, 26 Jun 2018 09:19:18 -0700 (PDT)",
        "From": "Nikolay Nikolaev <nicknickolaev@gmail.com>",
        "To": "maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Tue, 26 Jun 2018 19:19:17 +0300",
        "Message-ID": "<153002995700.22089.6499516015793208840.stgit@T460>",
        "In-Reply-To": "<153002988259.22089.8523468795459281187.stgit@T460>",
        "References": "<153002988259.22089.8523468795459281187.stgit@T460>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "Subject": "[dpdk-dev] [PATCH v1 2/5] vhost: make message handling functions\n\tprepare the reply",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "As VhostUserMsg structure is resued to generate the reply, move the\nrelevant fields update into the respective message handling functions.\n\nSigned-off-by: Nikolay Nikolaev <nicknickolaev@gmail.com>\n---\n lib/librte_vhost/vhost_user.c |   26 ++++++++++++++++----------\n 1 file changed, 16 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 9b5598871..1bc3d1629 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -146,11 +146,15 @@ vhost_user_reset_owner(struct virtio_net *dev)\n  * The features that we support are requested.\n  */\n static uint64_t\n-vhost_user_get_features(struct virtio_net *dev)\n+vhost_user_get_features(struct virtio_net *dev, VhostUserMsg *msg)\n {\n \tuint64_t features = 0;\n \n \trte_vhost_driver_get_features(dev->ifname, &features);\n+\n+\tmsg->payload.u64 = features;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn features;\n }\n \n@@ -158,11 +162,15 @@ vhost_user_get_features(struct virtio_net *dev)\n  * The queue number that we support are requested.\n  */\n static uint32_t\n-vhost_user_get_queue_num(struct virtio_net *dev)\n+vhost_user_get_queue_num(struct virtio_net *dev, VhostUserMsg *msg)\n {\n \tuint32_t queue_num = 0;\n \n \trte_vhost_driver_get_queue_num(dev->ifname, &queue_num);\n+\n+\tmsg->payload.u64 = (uint64_t)queue_num;\n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn queue_num;\n }\n \n@@ -1022,6 +1030,8 @@ vhost_user_get_vring_base(struct virtio_net *dev,\n \trte_free(vq->batch_copy_elems);\n \tvq->batch_copy_elems = NULL;\n \n+\tmsg->size = sizeof(msg->payload.state);\n+\n \treturn 0;\n }\n \n@@ -1144,6 +1154,8 @@ vhost_user_set_log_base(struct virtio_net *dev, VhostUserMsg *msg)\n \tdev->log_base = dev->log_addr + off;\n \tdev->log_size = size;\n \n+\tmsg->size = sizeof(msg->payload.u64);\n+\n \treturn 0;\n }\n \n@@ -1557,8 +1569,7 @@ vhost_user_msg_handler(int vid, int fd)\n \n \tswitch (msg.request.master) {\n \tcase VHOST_USER_GET_FEATURES:\n-\t\tmsg.payload.u64 = vhost_user_get_features(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_features(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_FEATURES:\n@@ -1588,9 +1599,6 @@ vhost_user_msg_handler(int vid, int fd)\n \n \tcase VHOST_USER_SET_LOG_BASE:\n \t\tvhost_user_set_log_base(dev, &msg);\n-\n-\t\t/* it needs a reply */\n-\t\tmsg.size = sizeof(msg.payload.u64);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \tcase VHOST_USER_SET_LOG_FD:\n@@ -1610,7 +1618,6 @@ vhost_user_msg_handler(int vid, int fd)\n \n \tcase VHOST_USER_GET_VRING_BASE:\n \t\tvhost_user_get_vring_base(dev, &msg);\n-\t\tmsg.size = sizeof(msg.payload.state);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n@@ -1628,8 +1635,7 @@ vhost_user_msg_handler(int vid, int fd)\n \t\tbreak;\n \n \tcase VHOST_USER_GET_QUEUE_NUM:\n-\t\tmsg.payload.u64 = (uint64_t)vhost_user_get_queue_num(dev);\n-\t\tmsg.size = sizeof(msg.payload.u64);\n+\t\tvhost_user_get_queue_num(dev, &msg);\n \t\tsend_vhost_reply(fd, &msg);\n \t\tbreak;\n \n",
    "prefixes": [
        "v1",
        "2/5"
    ]
}