Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41609/?format=api
{ "id": 41609, "url": "http://patchwork.dpdk.org/api/patches/41609/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530034653-28299-4-git-send-email-alejandro.lucero@netronome.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530034653-28299-4-git-send-email-alejandro.lucero@netronome.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530034653-28299-4-git-send-email-alejandro.lucero@netronome.com", "date": "2018-06-26T17:37:30", "name": "[3/6] eal: check hugepages within dma mask range", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6095f7e1b98e1cf0d7e08e67ef6e71d06d630c10", "submitter": { "id": 270, "url": "http://patchwork.dpdk.org/api/people/270/?format=api", "name": "Alejandro Lucero", "email": "alejandro.lucero@netronome.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530034653-28299-4-git-send-email-alejandro.lucero@netronome.com/mbox/", "series": [ { "id": 250, "url": "http://patchwork.dpdk.org/api/series/250/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=250", "date": "2018-06-26T17:37:28", "name": "[1/6] eal: add internal dma mask", "version": 1, "mbox": "http://patchwork.dpdk.org/series/250/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41609/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/41609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 080371BE56;\n\tTue, 26 Jun 2018 19:38:12 +0200 (CEST)", "from netronome.com (host-79-78-33-110.static.as9105.net\n\t[79.78.33.110]) by dpdk.org (Postfix) with ESMTP id D613B1BE3F;\n\tTue, 26 Jun 2018 19:38:04 +0200 (CEST)", "from netronome.com (localhost [127.0.0.1])\n\tby netronome.com (8.14.4/8.14.4/Debian-4.1ubuntu1) with ESMTP id\n\tw5QHbbMF028358; Tue, 26 Jun 2018 18:37:37 +0100", "(from alucero@localhost)\n\tby netronome.com (8.14.4/8.14.4/Submit) id w5QHbbuM028357;\n\tTue, 26 Jun 2018 18:37:37 +0100" ], "From": "Alejandro Lucero <alejandro.lucero@netronome.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, anatoly.burakov@intel.com", "Date": "Tue, 26 Jun 2018 18:37:30 +0100", "Message-Id": "<1530034653-28299-4-git-send-email-alejandro.lucero@netronome.com>", "X-Mailer": "git-send-email 1.9.1", "In-Reply-To": "<1530034653-28299-1-git-send-email-alejandro.lucero@netronome.com>", "References": "<1530034653-28299-1-git-send-email-alejandro.lucero@netronome.com>", "Subject": "[dpdk-dev] [PATCH 3/6] eal: check hugepages within dma mask range", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hugepages get an iova address which could be out of range\nfor devices with addressing limitations. This patch checks\nhugepages are withint the range if dma mask is set by a device.\n\nSigned-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>\n---\n lib/librte_eal/common/eal_private.h | 3 +++\n lib/librte_eal/linuxapp/eal/eal.c | 4 ++++\n 2 files changed, 7 insertions(+)", "diff": "diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h\nindex 462226f..05db535 100644\n--- a/lib/librte_eal/common/eal_private.h\n+++ b/lib/librte_eal/common/eal_private.h\n@@ -224,4 +224,7 @@\n */\n struct rte_bus *rte_bus_find_by_device_name(const char *str);\n \n+/* if dma mask set by a device, check hugepages are not out of range */\n+int rte_eal_memory_dma_mask_check(void);\n+\n #endif /* _EAL_PRIVATE_H_ */\ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 229eec9..eaa9325 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -960,6 +960,10 @@ static void rte_eal_init_alert(const char *msg)\n \t\treturn -1;\n \t}\n \n+\t/* If dma mask set, check hugepages iovas are within the range */\n+\tif (rte_eal_memory_dma_mask_check() < 0)\n+\t\trte_panic(\"iovas out of range\\n\");\n+\n \t/* initialize default service/lcore mappings and start running. Ignore\n \t * -ENOTSUP, as it indicates no service coremask passed to EAL.\n \t */\n", "prefixes": [ "3/6" ] }