Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41646,
    "url": "http://patchwork.dpdk.org/api/patches/41646/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180627091909.22689-1-adrien.mazarguil@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180627091909.22689-1-adrien.mazarguil@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180627091909.22689-1-adrien.mazarguil@6wind.com",
    "date": "2018-06-27T09:20:52",
    "name": "net/mlx5: fix invalid error check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "677979eec8744c511ce9aee884ddf5e4a0244d48",
    "submitter": {
        "id": 165,
        "url": "http://patchwork.dpdk.org/api/people/165/?format=api",
        "name": "Adrien Mazarguil",
        "email": "adrien.mazarguil@6wind.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patchwork.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180627091909.22689-1-adrien.mazarguil@6wind.com/mbox/",
    "series": [
        {
            "id": 257,
            "url": "http://patchwork.dpdk.org/api/series/257/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=257",
            "date": "2018-06-27T09:20:52",
            "name": "net/mlx5: fix invalid error check",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/257/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41646/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/41646/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D9C881BDE1;\n\tWed, 27 Jun 2018 11:21:09 +0200 (CEST)",
            "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 25B4F1BDCD\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 11:21:09 +0200 (CEST)",
            "by mail-wm0-f65.google.com with SMTP id v16-v6so4955025wmv.5\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 02:21:09 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\t14-v6sm5124647wmh.8.2018.06.27.02.21.07\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 02:21:08 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition;\n\tbh=aLBlDjyS5LwDQaZiwwwbIkRNApVTKTI/oO6PcJmhR7g=;\n\tb=xO+NeYguOnVlwNAR+y+2s+gCMoc20Gdh/rEOo2NyJpNdJQQiJtFUiMBwvRcNY0b7vl\n\tPH8cWEfM2Tknr5hW+fT0pgZXlpG2IOBhTNHQ6B1pEBNKXItFmpdu1nRPSxVXUF//vwMS\n\tMVe9P/ignUG/jte3ngxQDs/VBumhZY+tUB9Wa7Pxinr0u1WHYJyX8mNLP1o8UVE3g0g7\n\tjgNVc0n0UyTB+BjBIbIaj937K9NuhLSyXZwHi1wB8g+6g4QaAaMzrAjP0PP3CJdo1wjW\n\tgMNNBghsjBiA3bIoPnCvD2k4GUJbOpPdaWmJYV6xnNeqEuzPxoNUwkvEcBh3APjTMVD5\n\t24FQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition;\n\tbh=aLBlDjyS5LwDQaZiwwwbIkRNApVTKTI/oO6PcJmhR7g=;\n\tb=BfGhiWSgV0PIGW1Tq0Pb2rI43fcem84tOCTaKZeubjU9mEMpDwcZx8NoVVmVGQFsbk\n\tOeoi+6QJcD7ZlYI8lfHVrqYTP3VLHOzBCNUzuGc6rAXfX++S0ePqhKR9QRLG/7ye/bAW\n\tnQL4XgF0fBOoeSWEGYx2n47NZLCJU6E+Pu6HV5CU0zVIh0iG6ITz4NgO/w8HVFrUqvxU\n\tZBH30xA5QdQHXbRXoMdMLmgx3u5e9ctqzvLZFdmhhT2M90yLYantJjP2qCm0/raZm4SQ\n\th/KAHfrt+gorWRKdVgkw8Ka+gfJ/qeZ7wV0K+oMc1sOuzQcW7ehKX2FqDutKeFZJZuRY\n\tks9Q==",
        "X-Gm-Message-State": "APt69E3TUv7UP6IRbv0wBPlY0Ao3Maq7GWVNYnVPJQNVLWjUPHcoDba2\n\t3vpixnmYsKs9Lse2rj6+ooH55w==",
        "X-Google-Smtp-Source": "AAOMgpceJ9s2NtqNU57qHGjPPleVzojjIFLUy8To0O8lnY2/LlRgdEtiLQfwo9xz9XcT3m9J665NXw==",
        "X-Received": "by 2002:a1c:7141:: with SMTP id\n\tm62-v6mr4165621wmc.157.1530091268917; \n\tWed, 27 Jun 2018 02:21:08 -0700 (PDT)",
        "Date": "Wed, 27 Jun 2018 11:20:52 +0200",
        "From": "Adrien Mazarguil <adrien.mazarguil@6wind.com>",
        "To": "Shahaf Shuler <shahafs@mellanox.com>",
        "Cc": "dev@dpdk.org, Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,\n\tstable@dpdk.org",
        "Message-ID": "<20180627091909.22689-1-adrien.mazarguil@6wind.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=us-ascii",
        "Content-Disposition": "inline",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix invalid error check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Since its return type is unsigned, if_nametoindex() returns 0 in case of\nerror, never -1.\n\nFixes: ccdcba53a3f4 (\"net/mlx5: use Netlink to add/remove MAC addresses\")\nCc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\nCc: stable@dpdk.org\n\nSigned-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>\n---\n drivers/net/mlx5/mlx5_ethdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c\nindex 90488af33..ebe5cb6e3 100644\n--- a/drivers/net/mlx5/mlx5_ethdev.c\n+++ b/drivers/net/mlx5/mlx5_ethdev.c\n@@ -192,13 +192,13 @@ int\n mlx5_ifindex(const struct rte_eth_dev *dev)\n {\n \tchar ifname[IF_NAMESIZE];\n-\tint ret;\n+\tunsigned int ret;\n \n \tret = mlx5_get_ifname(dev, &ifname);\n \tif (ret)\n \t\treturn ret;\n \tret = if_nametoindex(ifname);\n-\tif (ret == -1) {\n+\tif (ret == 0) {\n \t\trte_errno = errno;\n \t\treturn -rte_errno;\n \t}\n",
    "prefixes": []
}