Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41663/?format=api
{ "id": 41663, "url": "http://patchwork.dpdk.org/api/patches/41663/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180627055031.24394-1-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180627055031.24394-1-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180627055031.24394-1-pablo.de.lara.guarch@intel.com", "date": "2018-06-27T05:50:30", "name": "[1/2] compressdev: replace mbuf scatter gather flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b6990dbcc5083dff8b3bdeae4e98221df2d1d9cd", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patchwork.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180627055031.24394-1-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 265, "url": "http://patchwork.dpdk.org/api/series/265/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=265", "date": "2018-06-27T05:50:30", "name": "[1/2] compressdev: replace mbuf scatter gather flag", "version": 1, "mbox": "http://patchwork.dpdk.org/series/265/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41663/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41663/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8FA881BE70;\n\tWed, 27 Jun 2018 15:56:13 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id ECE7D1BE66\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 15:56:11 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jun 2018 06:56:10 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga008.fm.intel.com with ESMTP; 27 Jun 2018 06:56:09 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,279,1526367600\"; d=\"scan'208\";a=\"50956690\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "fiona.trahe@intel.com, ashish.gupta@caviumnetworks.com,\n\tlee.daly@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 27 Jun 2018 06:50:30 +0100", "Message-Id": "<20180627055031.24394-1-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "Subject": "[dpdk-dev] [PATCH 1/2] compressdev: replace mbuf scatter gather flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current mbuf scatter gatter feature flag is\ntoo ambiguous, as it is not clear if input and/or output\nbuffers can be scatter gather mbufs or not.\n\nTherefore, three new flags will replace this flag:\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT\n- RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT\n\nNote that out-of-place flat buffers is supported by default\nand in-place is not supported by the library.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n doc/guides/rel_notes/release_18_08.rst | 6 ++++++\n lib/librte_compressdev/rte_comp.c | 8 ++++++--\n lib/librte_compressdev/rte_comp.h | 30 ++++++++++++++++++++----------\n 3 files changed, 32 insertions(+), 12 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex bc0124295..1fc38418a 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -60,6 +60,12 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* compressdev: Feature flag ``RTE_COMP_FF_MBUF_SCATTER_GATHER`` is\n+ replaced with the following more explicit flags:\n+ - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT``\n+ - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_SGL_IN_FB_OUT``\n+ - ``RTE_CRYPTODEV_FF_OUT_OF_PLACE_FB_IN_SGL_OUT``\n+\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c\nindex d596ba872..ea7692ae7 100644\n--- a/lib/librte_compressdev/rte_comp.c\n+++ b/lib/librte_compressdev/rte_comp.c\n@@ -14,8 +14,12 @@ rte_comp_get_feature_name(uint64_t flag)\n \t\treturn \"STATEFUL_COMPRESSION\";\n \tcase RTE_COMP_FF_STATEFUL_DECOMPRESSION:\n \t\treturn \"STATEFUL_DECOMPRESSION\";\n-\tcase RTE_COMP_FF_MBUF_SCATTER_GATHER:\n-\t\treturn \"MBUF_SCATTER_GATHER\";\n+\tcase RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT:\n+\t\treturn \"OUT_OF_PLACE_SGL_IN_SGL_OUT\";\n+\tcase RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT:\n+\t\treturn \"OUT_OF_PLACE_SGL_IN_FB_OUT\";\n+\tcase RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT:\n+\t\treturn \"OUT_OF_PLACE_FB_IN_SGL_OUT\";\n \tcase RTE_COMP_FF_MULTI_PKT_CHECKSUM:\n \t\treturn \"MULTI_PKT_CHECKSUM\";\n \tcase RTE_COMP_FF_ADLER32_CHECKSUM:\ndiff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h\nindex 5b513c77e..3ce6a80e1 100644\n--- a/lib/librte_compressdev/rte_comp.h\n+++ b/lib/librte_compressdev/rte_comp.h\n@@ -30,23 +30,33 @@ extern \"C\" {\n /**< Stateful compression is supported */\n #define RTE_COMP_FF_STATEFUL_DECOMPRESSION\t(1ULL << 1)\n /**< Stateful decompression is supported */\n-#define\tRTE_COMP_FF_MBUF_SCATTER_GATHER\t\t(1ULL << 2)\n-/**< Scatter-gather mbufs are supported */\n-#define RTE_COMP_FF_ADLER32_CHECKSUM\t\t(1ULL << 3)\n+#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_SGL_OUT\t(1ULL << 2)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are\n+ * supported in input and output\n+ */\n+#define RTE_COMP_FF_OUT_OF_PLACE_SGL_IN_FB_OUT\t(1ULL << 3)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in input, but only flat buffers (FB) are supported in output\n+ */\n+#define RTE_COMP_FF_OUT_OF_PLACE_FB_IN_SGL_OUT\t(1ULL << 4)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in output, but only flat buffers (FB) are supported in input\n+ */\n+#define RTE_COMP_FF_ADLER32_CHECKSUM\t\t(1ULL << 5)\n /**< Adler-32 Checksum is supported */\n-#define RTE_COMP_FF_CRC32_CHECKSUM\t\t(1ULL << 4)\n+#define RTE_COMP_FF_CRC32_CHECKSUM\t\t(1ULL << 6)\n /**< CRC32 Checksum is supported */\n-#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM\t(1ULL << 5)\n+#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM\t(1ULL << 7)\n /**< Adler-32/CRC32 Checksum is supported */\n-#define RTE_COMP_FF_MULTI_PKT_CHECKSUM\t\t(1ULL << 6)\n+#define RTE_COMP_FF_MULTI_PKT_CHECKSUM\t\t(1ULL << 8)\n /**< Generation of checksum across multiple stateless packets is supported */\n-#define RTE_COMP_FF_SHA1_HASH\t\t\t(1ULL << 7)\n+#define RTE_COMP_FF_SHA1_HASH\t\t\t(1ULL << 9)\n /**< SHA1 Hash is supported */\n-#define RTE_COMP_FF_SHA2_SHA256_HASH\t\t(1ULL << 8)\n+#define RTE_COMP_FF_SHA2_SHA256_HASH\t\t(1ULL << 10)\n /**< SHA256 Hash of SHA2 family is supported */\n-#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS\t(1ULL << 9)\n+#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS\t(1ULL << 11)\n /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is supported */\n-#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM\t(1ULL << 10)\n+#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM\t(1ULL << 12)\n /**< Private xforms created by the PMD can be shared\n * across multiple stateless operations. If not set, then app needs\n * to create as many priv_xforms as it expects to have stateless\n", "prefixes": [ "1/2" ] }