Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41676/?format=api
http://patchwork.dpdk.org/api/patches/41676/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/3c8d9a28a2627c3bde7eaa1a059704c9cca50f1e.1530111623.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3c8d9a28a2627c3bde7eaa1a059704c9cca50f1e.1530111623.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3c8d9a28a2627c3bde7eaa1a059704c9cca50f1e.1530111623.git.nelio.laranjeiro@6wind.com", "date": "2018-06-27T15:07:35", "name": "[v2,03/20] net/mlx5: replace verbs priorities by flow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2a2b6c628bf8e77c42824d1ef498fc4461fde766", "submitter": { "id": 243, "url": "http://patchwork.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patchwork.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/3c8d9a28a2627c3bde7eaa1a059704c9cca50f1e.1530111623.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 268, "url": "http://patchwork.dpdk.org/api/series/268/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=268", "date": "2018-06-27T15:07:32", "name": "net/mlx5: flow rework", "version": 2, "mbox": "http://patchwork.dpdk.org/series/268/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41676/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/41676/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EB8741BFA6;\n\tWed, 27 Jun 2018 17:07:39 +0200 (CEST)", "from mail-wr0-f193.google.com (mail-wr0-f193.google.com\n\t[209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 259EF1BF9C\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:37 +0200 (CEST)", "by mail-wr0-f193.google.com with SMTP id f16-v6so2408810wrm.3\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:37 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.35\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:36 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=60xI5M+vRxd4EpeGx71HPnAEEJfS/TUlZpd0pfrPlP0=;\n\tb=TZ5ix9TjogwO3JCYTO8/H5NFn4nrbgCV3Y/DBL5kHN9ZKhmU/UqGC3UJL5e05/NiRp\n\tK0fgIdjSzBjh+EZc/5jLGUuexyk/wUUuNJjx9gIr1grOnOy90H9ngzpRcNMgprLzEn6X\n\tlEFmeG+nOhGkXGnKdciU6ja8b7ItiT1hgAIg6DG9q0pXLk4j2WKMfUhjoY4QT6SKLbIb\n\t9ezn8fklGI3ws33s/4NoaQxSJtUOYsIT0D5nbCnzZdiETORoLeGrn9h3q6t5y2gt9nh9\n\t45DnwbwmNmFHoWJpEULfGe46mkD3cfC+4tdo6mG8CmXmjl0pn/RAYa/HBkSW6OsUZRCC\n\tcL4w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=60xI5M+vRxd4EpeGx71HPnAEEJfS/TUlZpd0pfrPlP0=;\n\tb=Gp49/7BcRfv1h8BKDH69X3E6lZR/+DpDdH/syjovx1E/TnNwph9GO4XQ07ezOuzq9d\n\tDFyRB72P1SB/Ps7JsxcM8JbenhaUJJJDsHjMytx7zAeLPgx/XCORv0jAt2EIRZkenMty\n\tUkjG9Ay3960avRr4DyyhWrF5exwRL9nB+xCpdDFtftadwYaLIs0hyBezSK65Xozw91BU\n\tm7m7dfqnJS9jZrqvR0E95bxgfOkwRSY+T/7vtdQFed1j2wlpdOVx9ydnnWak2QgoVRho\n\tS+wfQTMqUpYpphEXsRdJvOxBIjoz4+VWYGrgbUTdZjOO7o8F4fvhYnwWubNF4aHFANba\n\t83VQ==", "X-Gm-Message-State": "APt69E1EKY8RRjfQRqtimQINtZ404c2iqhimuAK7UXSzCPqQekJaooqX\n\tjITahpIMNj6oucau4PB1EjrgnmiYlg==", "X-Google-Smtp-Source": "AAOMgpfidZOhevN8HAVvdxMXSyjopUsLfi7C5hECsMqCe/4SRXjJUIfGOv6hvu/bfD/56Z81JTzYPQ==", "X-Received": "by 2002:adf:9148:: with SMTP id\n\tj66-v6mr5739976wrj.118.1530112056547; \n\tWed, 27 Jun 2018 08:07:36 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>", "Date": "Wed, 27 Jun 2018 17:07:35 +0200", "Message-Id": "<3c8d9a28a2627c3bde7eaa1a059704c9cca50f1e.1530111623.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 03/20] net/mlx5: replace verbs priorities by\n\tflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previous work introduce verbs priorities, whereas the PMD is making\ntranslation between Flow priority into Verbs. Rename this to make more\nsense on what the PMD has to translate.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5.c | 15 ++++-----------\n drivers/net/mlx5/mlx5.h | 4 ++--\n drivers/net/mlx5/mlx5_flow.c | 22 +++++++++++-----------\n 3 files changed, 17 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c\nindex aba6c1f9f..c3c8dffae 100644\n--- a/drivers/net/mlx5/mlx5.c\n+++ b/drivers/net/mlx5/mlx5.c\n@@ -703,7 +703,6 @@ mlx5_dev_spawn_one(struct rte_device *dpdk_dev,\n \tunsigned int tunnel_en = 0;\n \tunsigned int mpls_en = 0;\n \tunsigned int swp = 0;\n-\tunsigned int verb_priorities = 0;\n \tunsigned int mprq = 0;\n \tunsigned int mprq_min_stride_size_n = 0;\n \tunsigned int mprq_max_stride_size_n = 0;\n@@ -1100,16 +1099,10 @@ mlx5_dev_spawn_one(struct rte_device *dpdk_dev,\n \t/* Store device configuration on private structure. */\n \tpriv->config = config;\n \t/* Supported Verbs flow priority number detection. */\n-\tif (verb_priorities == 0) {\n-\t\terr = mlx5_verbs_max_prio(eth_dev);\n-\t\tif (err < 0) {\n-\t\t\tDRV_LOG(ERR, \"port %u wrong Verbs flow priorities\",\n-\t\t\t\teth_dev->data->port_id);\n-\t\t\tgoto error;\n-\t\t}\n-\t\tverb_priorities = err;\n-\t}\n-\tpriv->config.max_verbs_prio = verb_priorities;\n+\terr = mlx5_flow_priorities(eth_dev);\n+\tif (err < 0)\n+\t\tgoto error;\n+\tpriv->config.flow_prio = err;\n \t/*\n \t * Once the device is added to the list of memory event\n \t * callback, its global MR cache table cannot be expanded\ndiff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h\nindex 11aa0932f..ed8c1c9a2 100644\n--- a/drivers/net/mlx5/mlx5.h\n+++ b/drivers/net/mlx5/mlx5.h\n@@ -114,7 +114,7 @@ struct mlx5_dev_config {\n \t\tunsigned int min_rxqs_num;\n \t\t/* Rx queue count threshold to enable MPRQ. */\n \t} mprq; /* Configurations for Multi-Packet RQ. */\n-\tunsigned int max_verbs_prio; /* Number of Verb flow priorities. */\n+\tunsigned int flow_prio; /* Number of flow priorities. */\n \tunsigned int tso_max_payload_sz; /* Maximum TCP payload for TSO. */\n \tunsigned int ind_table_max_size; /* Maximum indirection table size. */\n \tint txq_inline; /* Maximum packet size for inlining. */\n@@ -309,7 +309,7 @@ int mlx5_traffic_restart(struct rte_eth_dev *dev);\n \n /* mlx5_flow.c */\n \n-int mlx5_verbs_max_prio(struct rte_eth_dev *dev);\n+int mlx5_flow_priorities(struct rte_eth_dev *dev);\n void mlx5_flow_print(struct rte_flow *flow);\n int mlx5_flow_validate(struct rte_eth_dev *dev,\n \t\t const struct rte_flow_attr *attr,\ndiff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 8b5b695d4..5d3bc183d 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -82,11 +82,11 @@ struct ibv_spec_header {\n * Pointer to Ethernet device.\n *\n * @return\n- * number of supported Verbs flow priority on success, a negative errno\n- * value otherwise and rte_errno is set.\n+ * number of supported flow priority on success, a negative errno value\n+ * otherwise and rte_errno is set.\n */\n int\n-mlx5_verbs_max_prio(struct rte_eth_dev *dev)\n+mlx5_flow_priorities(struct rte_eth_dev *dev)\n {\n \tstruct {\n \t\tstruct ibv_flow_attr attr;\n@@ -106,25 +106,25 @@ mlx5_verbs_max_prio(struct rte_eth_dev *dev)\n \t\t},\n \t};\n \tstruct ibv_flow *flow;\n-\tuint32_t verb_priorities;\n \tstruct mlx5_hrxq *drop = mlx5_hrxq_drop_new(dev);\n+\tuint16_t vprio[] = { 8, 16 };\n+\tint i;\n \n \tif (!drop) {\n \t\trte_errno = ENOTSUP;\n \t\treturn -rte_errno;\n \t}\n-\tfor (verb_priorities = 0; 1; verb_priorities++) {\n-\t\tflow_attr.attr.priority = verb_priorities;\n-\t\tflow = mlx5_glue->create_flow(drop->qp,\n-\t\t\t\t\t &flow_attr.attr);\n+\tfor (i = 0; i != RTE_DIM(vprio); i++) {\n+\t\tflow_attr.attr.priority = vprio[i] - 1;\n+\t\tflow = mlx5_glue->create_flow(drop->qp, &flow_attr.attr);\n \t\tif (!flow)\n \t\t\tbreak;\n \t\tclaim_zero(mlx5_glue->destroy_flow(flow));\n \t}\n \tmlx5_hrxq_drop_release(dev, drop);\n \tDRV_LOG(INFO, \"port %u flow maximum priority: %d\",\n-\t\tdev->data->port_id, verb_priorities);\n-\treturn verb_priorities;\n+\t\tdev->data->port_id, vprio[i]);\n+\treturn vprio[i];\n }\n \n /**\n@@ -318,7 +318,7 @@ mlx5_ctrl_flow_vlan(struct rte_eth_dev *dev,\n \tstruct priv *priv = dev->data->dev_private;\n \tconst struct rte_flow_attr attr = {\n \t\t.ingress = 1,\n-\t\t.priority = priv->config.max_verbs_prio - 1,\n+\t\t.priority = priv->config.flow_prio - 1,\n \t};\n \tstruct rte_flow_item items[] = {\n \t\t{\n", "prefixes": [ "v2", "03/20" ] }{ "id": 41676, "url": "