Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 41682,
    "url": "http://patchwork.dpdk.org/api/patches/41682/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7693b4973a8e683972895820d6db36aa7b12a404.1530111623.git.nelio.laranjeiro@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<7693b4973a8e683972895820d6db36aa7b12a404.1530111623.git.nelio.laranjeiro@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/7693b4973a8e683972895820d6db36aa7b12a404.1530111623.git.nelio.laranjeiro@6wind.com",
    "date": "2018-06-27T15:07:40",
    "name": "[v2,08/20] net/mlx5: add flow IPv4 item",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "0cace919088240f916ecc6feed9092c79827fa9a",
    "submitter": {
        "id": 243,
        "url": "http://patchwork.dpdk.org/api/people/243/?format=api",
        "name": "Nélio Laranjeiro",
        "email": "nelio.laranjeiro@6wind.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patchwork.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7693b4973a8e683972895820d6db36aa7b12a404.1530111623.git.nelio.laranjeiro@6wind.com/mbox/",
    "series": [
        {
            "id": 268,
            "url": "http://patchwork.dpdk.org/api/series/268/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=268",
            "date": "2018-06-27T15:07:32",
            "name": "net/mlx5: flow rework",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/268/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/41682/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/41682/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFAF31BFCC;\n\tWed, 27 Jun 2018 17:07:52 +0200 (CEST)",
            "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66]) by dpdk.org (Postfix) with ESMTP id F2B9F1BFA9\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:41 +0200 (CEST)",
            "by mail-wm0-f66.google.com with SMTP id p11-v6so5849319wmc.4\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:41 -0700 (PDT)",
            "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:40 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=+Ttfs57J/DFx6/1qOrmmY1w5o1u+vMJHbkJpO+YELK4=;\n\tb=ApGoYUihgBwZvmbN2nYRwaBwzGkz3EBxqoBMu4ONPNxbTImjjvf7+H7V1XNfThwUL+\n\tccvAYRK5msRjL7s7cx81Elj2t1NIAwdNYsW09tC3tc3P79PRfVXZ0Jlb0BQsN1dK9svB\n\tO6LTcCR6dpScHXhJpAv0qIyEJ/y+ZJM1UAaW1DJ/PQawvO5waHaKvFhKgBHkydL+KcJ9\n\tWAFxFbS5iAUSBDX1Dl5eG5H88HtwMnfV0Cg8mMSxODHh54js8bVvQjuKzGRbDfe1Iypd\n\tz27Jpn7EMOIHks0BkZr28OXPCesspMrRgB3ULypfu5Wf5AwD+gLXss1IbNeKzC8b+rxs\n\t4s+g==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=+Ttfs57J/DFx6/1qOrmmY1w5o1u+vMJHbkJpO+YELK4=;\n\tb=QPO3QTTygAcChSzWWjOiHval0ZIFFl4nE6SSb6POMCltm8n8nqClsnFYf3+bu6dqqh\n\tNOmR+r0NV85v9XDqoXLi3JE91Rx9k2vdoYhMXMmq6tZypD+0PaaPMQi85BMc4NFbA9R+\n\t2je2fcE+z4tTGEglcj7gOR4rnLdeShquMp1MzjyfIHxSZyHCzGXSHOWsERw8KSdA+/JX\n\tWnsg90w7/ZZxX9XNhlXDDCjvVz1HPA/LQxsHq5fbvFoo7knG+O0TPeKne7xtj5IqnZYr\n\t8qhfUTydSegtuppNyB3drVOriBM6ralqMc2WzWYeKRlQcfhUIsmzetkmGU17DCshpJmi\n\tUzwA==",
        "X-Gm-Message-State": "APt69E057FXW+Rgg73a5xs6uNJeML5kbC/8H6poTnZ4sitGAef5bwftm\n\tJax10bNKhC+ht08Z32VN9oCaXpk4uA==",
        "X-Google-Smtp-Source": "AAOMgpedtk9euSnpS4mHWSItMYRQjRklWhnB9oFi3vWSDpJyFLg2dzbQ3zFCj+35+zORKGhulTkBlA==",
        "X-Received": "by 2002:a1c:4291:: with SMTP id\n\tk17-v6mr5149609wmi.74.1530112061178; \n\tWed, 27 Jun 2018 08:07:41 -0700 (PDT)",
        "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>",
        "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>",
        "Date": "Wed, 27 Jun 2018 17:07:40 +0200",
        "Message-Id": "<7693b4973a8e683972895820d6db36aa7b12a404.1530111623.git.nelio.laranjeiro@6wind.com>",
        "X-Mailer": "git-send-email 2.18.0",
        "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>",
        "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>",
        "Subject": "[dpdk-dev] [PATCH v2 08/20] net/mlx5: add flow IPv4 item",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 83 ++++++++++++++++++++++++++++++++++++\n 1 file changed, 83 insertions(+)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 6a576ddd9..8e7a0bb5a 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -540,6 +540,86 @@ mlx5_flow_item_vlan(const struct rte_flow_item *item, struct rte_flow *flow,\n \treturn size;\n }\n \n+/**\n+ * Validate IPv4 layer and possibly create the Verbs specification.\n+ *\n+ * @param item[in]\n+ *   Item specification.\n+ * @param flow[in, out]\n+ *   Pointer to flow structure.\n+ * @param flow_size[in]\n+ *   Size in bytes of the available space for to store the flow information.\n+ * @param error\n+ *   Pointer to error structure.\n+ *\n+ * @return\n+ *   size in bytes necessary for the conversion, a negative errno value\n+ *   otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_item_ipv4(const struct rte_flow_item *item, struct rte_flow *flow,\n+\t\t    const size_t flow_size, struct rte_flow_error *error)\n+{\n+\tconst struct rte_flow_item_ipv4 *spec = item->spec;\n+\tconst struct rte_flow_item_ipv4 *mask = item->mask;\n+\tconst struct rte_flow_item_ipv4 nic_mask = {\n+\t\t.hdr = {\n+\t\t\t.src_addr = RTE_BE32(0xffffffff),\n+\t\t\t.dst_addr = RTE_BE32(0xffffffff),\n+\t\t\t.type_of_service = 0xff,\n+\t\t\t.next_proto_id = 0xff,\n+\t\t},\n+\t};\n+\tunsigned int size = sizeof(struct ibv_flow_spec_ipv4_ext);\n+\tstruct ibv_flow_spec_ipv4_ext ipv4 = {\n+\t\t.type = IBV_FLOW_SPEC_IPV4_EXT,\n+\t\t.size = size,\n+\t};\n+\tint ret;\n+\n+\tif (flow->layers & MLX5_FLOW_LAYER_OUTER_L3)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t  item,\n+\t\t\t\t\t  \"multiple L3 layers not supported\");\n+\telse if (flow->layers & MLX5_FLOW_LAYER_OUTER_L4)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t  item,\n+\t\t\t\t\t  \"L3 cannot follow an L4 layer.\");\n+\tif (!mask)\n+\t\tmask = &rte_flow_item_ipv4_mask;\n+\tret = mlx5_flow_item_validate(item, (const uint8_t *)mask,\n+\t\t\t\t      (const uint8_t *)&nic_mask,\n+\t\t\t\t      sizeof(struct rte_flow_item_ipv4), error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\tflow->layers |= MLX5_FLOW_LAYER_OUTER_L3_IPV4;\n+\tif (size > flow_size)\n+\t\treturn size;\n+\tif (spec) {\n+\t\tipv4.val = (struct ibv_flow_ipv4_ext_filter){\n+\t\t\t.src_ip = spec->hdr.src_addr,\n+\t\t\t.dst_ip = spec->hdr.dst_addr,\n+\t\t\t.proto = spec->hdr.next_proto_id,\n+\t\t\t.tos = spec->hdr.type_of_service,\n+\t\t};\n+\t\tipv4.mask = (struct ibv_flow_ipv4_ext_filter){\n+\t\t\t.src_ip = mask->hdr.src_addr,\n+\t\t\t.dst_ip = mask->hdr.dst_addr,\n+\t\t\t.proto = mask->hdr.next_proto_id,\n+\t\t\t.tos = mask->hdr.type_of_service,\n+\t\t};\n+\t\t/* Remove unwanted bits from values. */\n+\t\tipv4.val.src_ip &= ipv4.mask.src_ip;\n+\t\tipv4.val.dst_ip &= ipv4.mask.dst_ip;\n+\t\tipv4.val.proto &= ipv4.mask.proto;\n+\t\tipv4.val.tos &= ipv4.mask.tos;\n+\t}\n+\tmlx5_flow_spec_verbs_add(flow, &ipv4, size);\n+\treturn size;\n+}\n+\n /**\n  * Validate items provided by the user.\n  *\n@@ -576,6 +656,9 @@ mlx5_flow_items(const struct rte_flow_item items[],\n \t\tcase RTE_FLOW_ITEM_TYPE_VLAN:\n \t\t\tret = mlx5_flow_item_vlan(items, flow, remain, error);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_IPV4:\n+\t\t\tret = mlx5_flow_item_ipv4(items, flow, remain, error);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t  RTE_FLOW_ERROR_TYPE_ITEM,\n",
    "prefixes": [
        "v2",
        "08/20"
    ]
}