Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41688/?format=api
{ "id": 41688, "url": "http://patchwork.dpdk.org/api/patches/41688/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/2cb1bee89e0537dd4a8165f5cbce2bb284490b9b.1530111623.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<2cb1bee89e0537dd4a8165f5cbce2bb284490b9b.1530111623.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/2cb1bee89e0537dd4a8165f5cbce2bb284490b9b.1530111623.git.nelio.laranjeiro@6wind.com", "date": "2018-06-27T15:07:46", "name": "[v2,14/20] net/mlx5: remove useless arguments in hrxq API", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "66e1297630a5a7294b114ce703a8271c19b92f81", "submitter": { "id": 243, "url": "http://patchwork.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patchwork.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/2cb1bee89e0537dd4a8165f5cbce2bb284490b9b.1530111623.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 268, "url": "http://patchwork.dpdk.org/api/series/268/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=268", "date": "2018-06-27T15:07:32", "name": "net/mlx5: flow rework", "version": 2, "mbox": "http://patchwork.dpdk.org/series/268/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41688/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/41688/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF97F1BFBC;\n\tWed, 27 Jun 2018 17:08:05 +0200 (CEST)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A2C801BFC6\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:47 +0200 (CEST)", "by mail-wm0-f67.google.com with SMTP id z137-v6so5914256wmc.0\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:47 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.46\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:46 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=rJmJKM5KNHd1jjnS4mDj5P6LiXHzuP1xkVsjfeTRzwI=;\n\tb=YvJCv5/5ybbRQKRZPKQ2ctR+T3yoOCtzrimgRw+VWT1t61fLu08jNwLn2cjKMsAIC+\n\tJJL/UxdkMGyU4Md6ysmOWt6n539iZ1Z9STufGgjlwx+fO6V/zhe7FYtED2u/3MCfFwJA\n\tFAhmm6vSjZQTJf4D1dQs1VAQLPL4DKzekqr4B5Bin3iq1pqWfOoq4364TKO6taJHDGnr\n\td+toPyTJbdlJOehUceOUuilWh3SVj40dHVv5PadU8gMowDnPfwaEfxlmtbV6phwqTd+u\n\t8WvGgWUsfvl+dm60BmHZkjV0LixIxm/QdShxup+BHO3SbnBbOivwMbUsSrcQKnetPzYE\n\tfRhw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=rJmJKM5KNHd1jjnS4mDj5P6LiXHzuP1xkVsjfeTRzwI=;\n\tb=Inxzm/LuiRNJkYjsF87YZw/p7LS+ZpYj9mhhyK7bix7bO6LEwICxIq3XmuXQ1virUv\n\tTevn9zMTXziv0KZF3sbWbjXMoOxAxy0EMdgyNRFhSnTCmoGRcteVH3QhPAf7bK71ATj0\n\tnhG0QMpPc8JwL688gpZLxMjko+5DqikD5NKsiDV+6g/vUXbNS9FZM7DtInvBXbVR6LaW\n\tQ+i3PRulfcr9DUJ3U3w87wyhmuWo8sCOyMMOgRb3XBocFvdCBhu//q7jXGIH65j+aGEP\n\toy1hzkxV0alz1Kbqo8YKkN8c46ghsyLNhiyCpz3i6lCfXDxr4T+CyZ04eYLnO5XaHdI9\n\tv8RA==", "X-Gm-Message-State": "APt69E1Eb8YJeRFHcMDPt6SMathn+4w2WOhxUmer2KomsqcrMsfNFuFo\n\tfCtwmEawZAWH7dm6QbhEx9RQagI+jQ==", "X-Google-Smtp-Source": "AAOMgpehaum7kOtp0s0PE05SsbVQCZa9h2EufuYkDQ6rK2sPda8dpbfneALQi+zMYM87Vuoe+nUlPA==", "X-Received": "by 2002:a1c:c05:: with SMTP id\n\t5-v6mr5587224wmm.117.1530112066768; \n\tWed, 27 Jun 2018 08:07:46 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>", "Date": "Wed, 27 Jun 2018 17:07:46 +0200", "Message-Id": "<2cb1bee89e0537dd4a8165f5cbce2bb284490b9b.1530111623.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 14/20] net/mlx5: remove useless arguments in\n\thrxq API", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RSS level is necessary to had a bit in the hash_fields which is already\nprovided in this API, for the tunnel, it is necessary to request such\nqueue to compute the checksum on the inner most, this last one should\nalways be activated.\n\nSigned-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 4 ++--\n drivers/net/mlx5/mlx5_rxq.c | 39 +++++++++---------------------------\n drivers/net/mlx5/mlx5_rxtx.h | 8 ++------\n 3 files changed, 13 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 08e0a6556..7dda88641 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -1935,13 +1935,13 @@ mlx5_flow_fate_apply(struct rte_eth_dev *dev, struct rte_flow *flow,\n \t\t\t\t\t rss_hash_default_key_len,\n \t\t\t\t\t verbs->hash_fields,\n \t\t\t\t\t (*flow->queue),\n-\t\t\t\t\t flow->rss.queue_num, 0, 0);\n+\t\t\t\t\t flow->rss.queue_num);\n \t\t\tif (!hrxq)\n \t\t\t\thrxq = mlx5_hrxq_new(dev, flow->key,\n \t\t\t\t\t\t rss_hash_default_key_len,\n \t\t\t\t\t\t verbs->hash_fields,\n \t\t\t\t\t\t (*flow->queue),\n-\t\t\t\t\t\t flow->rss.queue_num, 0, 0);\n+\t\t\t\t\t\t flow->rss.queue_num);\n \t\t\tif (!hrxq) {\n \t\t\t\trte_flow_error_set\n \t\t\t\t\t(error, rte_errno,\ndiff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 5f17dce50..8f65e4299 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -1730,10 +1730,6 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev *dev)\n * first queue index will be taken for the indirection table.\n * @param queues_n\n * Number of queues.\n- * @param tunnel\n- * Tunnel type, implies tunnel offloading like inner checksum if available.\n- * @param rss_level\n- * RSS hash on tunnel level.\n *\n * @return\n * The Verbs object initialised, NULL otherwise and rte_errno is set.\n@@ -1742,17 +1738,13 @@ struct mlx5_hrxq *\n mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t const uint8_t *rss_key, uint32_t rss_key_len,\n \t uint64_t hash_fields,\n-\t const uint16_t *queues, uint32_t queues_n,\n-\t uint32_t tunnel, uint32_t rss_level)\n+\t const uint16_t *queues, uint32_t queues_n)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct mlx5_hrxq *hrxq;\n \tstruct mlx5_ind_table_ibv *ind_tbl;\n \tstruct ibv_qp *qp;\n \tint err;\n-#ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT\n-\tstruct mlx5dv_qp_init_attr qp_init_attr = {0};\n-#endif\n \n \tqueues_n = hash_fields ? queues_n : 1;\n \tind_tbl = mlx5_ind_table_ibv_get(dev, queues, queues_n);\n@@ -1767,11 +1759,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\trss_key = rss_hash_default_key;\n \t}\n #ifdef HAVE_IBV_DEVICE_TUNNEL_SUPPORT\n-\tif (tunnel) {\n-\t\tqp_init_attr.comp_mask =\n-\t\t\t\tMLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS;\n-\t\tqp_init_attr.create_flags = MLX5DV_QP_CREATE_TUNNEL_OFFLOADS;\n-\t}\n \tqp = mlx5_glue->dv_create_qp\n \t\t(priv->ctx,\n \t\t &(struct ibv_qp_init_attr_ex){\n@@ -1787,14 +1774,17 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t\t.rx_hash_key = rss_key ?\n \t\t\t\t\t (void *)(uintptr_t)rss_key :\n \t\t\t\t\t rss_hash_default_key,\n-\t\t\t\t.rx_hash_fields_mask = hash_fields |\n-\t\t\t\t\t(tunnel && rss_level > 1 ?\n-\t\t\t\t\t(uint32_t)IBV_RX_HASH_INNER : 0),\n+\t\t\t\t.rx_hash_fields_mask = hash_fields,\n \t\t\t},\n \t\t\t.rwq_ind_tbl = ind_tbl->ind_table,\n \t\t\t.pd = priv->pd,\n \t\t },\n-\t\t &qp_init_attr);\n+\t\t &(struct mlx5dv_qp_init_attr){\n+\t\t\t.comp_mask = (hash_fields & IBV_RX_HASH_INNER) ?\n+\t\t\t\t MLX5DV_QP_INIT_ATTR_MASK_QP_CREATE_FLAGS :\n+\t\t\t\t 0,\n+\t\t\t.create_flags = MLX5DV_QP_CREATE_TUNNEL_OFFLOADS,\n+\t\t });\n #else\n \tqp = mlx5_glue->create_qp_ex\n \t\t(priv->ctx,\n@@ -1828,8 +1818,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n \thrxq->qp = qp;\n \thrxq->rss_key_len = rss_key_len;\n \thrxq->hash_fields = hash_fields;\n-\thrxq->tunnel = tunnel;\n-\thrxq->rss_level = rss_level;\n \tmemcpy(hrxq->rss_key, rss_key, rss_key_len);\n \trte_atomic32_inc(&hrxq->refcnt);\n \tLIST_INSERT_HEAD(&priv->hrxqs, hrxq, next);\n@@ -1855,10 +1843,6 @@ mlx5_hrxq_new(struct rte_eth_dev *dev,\n * first queue index will be taken for the indirection table.\n * @param queues_n\n * Number of queues.\n- * @param tunnel\n- * Tunnel type, implies tunnel offloading like inner checksum if available.\n- * @param rss_level\n- * RSS hash on tunnel level\n *\n * @return\n * An hash Rx queue on success.\n@@ -1867,8 +1851,7 @@ struct mlx5_hrxq *\n mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t const uint8_t *rss_key, uint32_t rss_key_len,\n \t uint64_t hash_fields,\n-\t const uint16_t *queues, uint32_t queues_n,\n-\t uint32_t tunnel, uint32_t rss_level)\n+\t const uint16_t *queues, uint32_t queues_n)\n {\n \tstruct priv *priv = dev->data->dev_private;\n \tstruct mlx5_hrxq *hrxq;\n@@ -1883,10 +1866,6 @@ mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t\t\tcontinue;\n \t\tif (hrxq->hash_fields != hash_fields)\n \t\t\tcontinue;\n-\t\tif (hrxq->tunnel != tunnel)\n-\t\t\tcontinue;\n-\t\tif (hrxq->rss_level != rss_level)\n-\t\t\tcontinue;\n \t\tind_tbl = mlx5_ind_table_ibv_get(dev, queues, queues_n);\n \t\tif (!ind_tbl)\n \t\t\tcontinue;\ndiff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h\nindex 51f7f678b..bb67c32a6 100644\n--- a/drivers/net/mlx5/mlx5_rxtx.h\n+++ b/drivers/net/mlx5/mlx5_rxtx.h\n@@ -157,8 +157,6 @@ struct mlx5_hrxq {\n \tstruct mlx5_ind_table_ibv *ind_table; /* Indirection table. */\n \tstruct ibv_qp *qp; /* Verbs queue pair. */\n \tuint64_t hash_fields; /* Verbs Hash fields. */\n-\tuint32_t tunnel; /* Tunnel type. */\n-\tuint32_t rss_level; /* RSS on tunnel level. */\n \tuint32_t rss_key_len; /* Hash key length in bytes. */\n \tuint8_t rss_key[]; /* Hash key. */\n };\n@@ -274,13 +272,11 @@ void mlx5_ind_table_ibv_drop_release(struct rte_eth_dev *dev,\n struct mlx5_hrxq *mlx5_hrxq_new(struct rte_eth_dev *dev,\n \t\t\t\tconst uint8_t *rss_key, uint32_t rss_key_len,\n \t\t\t\tuint64_t hash_fields,\n-\t\t\t\tconst uint16_t *queues, uint32_t queues_n,\n-\t\t\t\tuint32_t tunnel, uint32_t rss_level);\n+\t\t\t\tconst uint16_t *queues, uint32_t queues_n);\n struct mlx5_hrxq *mlx5_hrxq_get(struct rte_eth_dev *dev,\n \t\t\t\tconst uint8_t *rss_key, uint32_t rss_key_len,\n \t\t\t\tuint64_t hash_fields,\n-\t\t\t\tconst uint16_t *queues, uint32_t queues_n,\n-\t\t\t\tuint32_t tunnel, uint32_t rss_level);\n+\t\t\t\tconst uint16_t *queues, uint32_t queues_n);\n int mlx5_hrxq_release(struct rte_eth_dev *dev, struct mlx5_hrxq *hxrq);\n int mlx5_hrxq_ibv_verify(struct rte_eth_dev *dev);\n struct mlx5_hrxq *mlx5_hrxq_drop_new(struct rte_eth_dev *dev);\n", "prefixes": [ "v2", "14/20" ] }