Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41693/?format=api
http://patchwork.dpdk.org/api/patches/41693/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/dcce366c08a8163ec7f38da6447a70ee72ff72e5.1530111623.git.nelio.laranjeiro@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<dcce366c08a8163ec7f38da6447a70ee72ff72e5.1530111623.git.nelio.laranjeiro@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/dcce366c08a8163ec7f38da6447a70ee72ff72e5.1530111623.git.nelio.laranjeiro@6wind.com", "date": "2018-06-27T15:07:51", "name": "[v2,19/20] net/mlx5: add flow MPLS item", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ea927980ac89d4af959a7f15668edcedc0d941bb", "submitter": { "id": 243, "url": "http://patchwork.dpdk.org/api/people/243/?format=api", "name": "Nélio Laranjeiro", "email": "nelio.laranjeiro@6wind.com" }, "delegate": { "id": 6624, "url": "http://patchwork.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/dcce366c08a8163ec7f38da6447a70ee72ff72e5.1530111623.git.nelio.laranjeiro@6wind.com/mbox/", "series": [ { "id": 268, "url": "http://patchwork.dpdk.org/api/series/268/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=268", "date": "2018-06-27T15:07:32", "name": "net/mlx5: flow rework", "version": 2, "mbox": "http://patchwork.dpdk.org/series/268/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41693/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/41693/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 717AA1C027;\n\tWed, 27 Jun 2018 17:08:14 +0200 (CEST)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68]) by dpdk.org (Postfix) with ESMTP id 74C721BFB3\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 17:07:51 +0200 (CEST)", "by mail-wm0-f68.google.com with SMTP id z13-v6so5887360wma.5\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 08:07:51 -0700 (PDT)", "from laranjeiro-vm.dev.6wind.com\n\t(host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])\n\tby smtp.gmail.com with ESMTPSA id\n\tk17-v6sm4872513wrp.19.2018.06.27.08.07.50\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 27 Jun 2018 08:07:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=PRNbGMzLnw+u8zm2HpUIy0dpaKmm+KntfFVkJ/PR6wU=;\n\tb=r3P78um5b/UV6E3h4D2+qEP0txvIRT9d3vh70Xw/U+bV3W4EsHn62OsoraSaP2usw0\n\tJPPAF8iTaSsD3dux3V09mesnKSfVjJQpJppnDpm9zIvcVioq5EHm3AW9Lb5pCp291k1+\n\t/njHinUn885pTscNWtu7J8qGZBbSQESbJanKjGgh8HEHAPNQyCBmkFWG+Vm2tafVdx7S\n\tZbzTZpnUqH+qAdC7nxO7ZxGrF0EIdr9CMpss2QDs3emk75s4/zg+rzmF+6kyy5xrwiop\n\tCrIjG0x3kAKUGZbUEWZbnG/m05u2xIutFT2t5iaiFOu/jRi9drtwK+oEc1farjz74AaM\n\tn/2g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=PRNbGMzLnw+u8zm2HpUIy0dpaKmm+KntfFVkJ/PR6wU=;\n\tb=Hc6A76vZ7jVXKUjpdAy9cerGwoYBYDTsCZ1JApJTpMfRlS2ehDTo3ox0t/y562yAaD\n\tsLxI2wh44M4xWVK6iSXbkG8d5CLT87nKlVqal2GS2Jxz7wobCT2UnuEOe1LFcVq3mkMk\n\tCThg0gspJ25im+Fb/2v29100tvXdwgi09jGiGYYTe+FMRXzidWbGYSLj0RUacDdrFbi4\n\tb+g4x3oCZL4TRUMnVpva7Ddg1aIfKW/KOQoIO6cpZRLOyR6fgoP908Fh+2JCn36XHPYV\n\tFkkVFOYAZDvYfKJN0wMHD058I9JArKYCffJkkELbEUu9kqiuKrURZ4dEUI6D3HDOr1Ec\n\tBugQ==", "X-Gm-Message-State": "APt69E2xb47QFGtzb6s8ojVg5/7RT8ulTPo84s/EjRFylg46F2kF/PEb\n\tDqNws3dSPJPugmYsBPBLvsBPmjpGAg==", "X-Google-Smtp-Source": "AAOMgpdnrt2fZYdy/HDyZe0y4L4U3QlhNfr3tXzMFa/HhykwcruZ/5qsS2erekbJH8kVP5x/EECBVw==", "X-Received": "by 2002:a1c:7153:: with SMTP id\n\tm80-v6mr5088411wmc.7.1530112070935; \n\tWed, 27 Jun 2018 08:07:50 -0700 (PDT)", "From": "Nelio Laranjeiro <nelio.laranjeiro@6wind.com>", "To": "dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>,\n\tYongseok Koh <yskoh@mellanox.com>", "Date": "Wed, 27 Jun 2018 17:07:51 +0200", "Message-Id": "<dcce366c08a8163ec7f38da6447a70ee72ff72e5.1530111623.git.nelio.laranjeiro@6wind.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "References": "<cover.1527506071.git.nelio.laranjeiro@6wind.com>\n\t<cover.1530111623.git.nelio.laranjeiro@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 19/20] net/mlx5: add flow MPLS item", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 77 +++++++++++++++++++++++++++++++++++-\n 1 file changed, 76 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 636aaabe8..7aa4e6ed5 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -55,6 +55,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;\n #define MLX5_FLOW_LAYER_VXLAN (1u << 12)\n #define MLX5_FLOW_LAYER_VXLAN_GPE (1u << 13)\n #define MLX5_FLOW_LAYER_GRE (1u << 14)\n+#define MLX5_FLOW_LAYER_MPLS (1u << 15)\n \n /* Outer Masks. */\n #define MLX5_FLOW_LAYER_OUTER_L3 \\\n@@ -68,7 +69,7 @@ extern const struct eth_dev_ops mlx5_dev_ops_isolate;\n /* Tunnel masks. */\n #define MLX5_FLOW_LAYER_TUNNEL \\\n \t(MLX5_FLOW_LAYER_VXLAN | MLX5_FLOW_LAYER_VXLAN_GPE | \\\n-\t MLX5_FLOW_LAYER_GRE)\n+\t MLX5_FLOW_LAYER_GRE | MLX5_FLOW_LAYER_MPLS)\n \n /* Inner Masks. */\n #define MLX5_FLOW_LAYER_INNER_L3 \\\n@@ -1589,6 +1590,77 @@ mlx5_flow_item_gre(const struct rte_flow_item *item,\n \treturn size;\n }\n \n+/**\n+ * Validate MPLS layer and possibly create the Verbs specification.\n+ *\n+ * @param dev\n+ * Pointer to Ethernet device.\n+ * @param item[in]\n+ * Item specification.\n+ * @param flow[in, out]\n+ * Pointer to flow structure.\n+ * @param flow_size[in]\n+ * Size in bytes of the available space for to store the flow information.\n+ * @param error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * size in bytes necessary for the conversion, a negative errno value\n+ * otherwise and rte_errno is set.\n+ */\n+static int\n+mlx5_flow_item_mpls(const struct rte_flow_item *item __rte_unused,\n+\t\t struct rte_flow *flow __rte_unused,\n+\t\t const size_t flow_size __rte_unused,\n+\t\t struct rte_flow_error *error)\n+{\n+#ifdef HAVE_IBV_DEVICE_MPLS_SUPPORT\n+\tconst struct rte_flow_item_mpls *spec = item->spec;\n+\tconst struct rte_flow_item_mpls *mask = item->mask;\n+\tunsigned int size = sizeof(struct ibv_flow_spec_mpls);\n+\tstruct ibv_flow_spec_mpls mpls = {\n+\t\t.type = IBV_FLOW_SPEC_MPLS,\n+\t\t.size = size,\n+\t};\n+\tconst uint32_t layers = mlx5_flow_layers(flow);\n+\tint ret;\n+\n+\tif (layers & MLX5_FLOW_LAYER_TUNNEL)\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t\t item,\n+\t\t\t\t\t \"a tunnel is already\"\n+\t\t\t\t\t \" present\");\n+\tif (!mask)\n+\t\tmask = &rte_flow_item_mpls_mask;\n+\tret = mlx5_flow_item_validate\n+\t\t(item, (const uint8_t *)mask,\n+\t\t (const uint8_t *)&rte_flow_item_mpls_mask,\n+\t\t sizeof(struct rte_flow_item_mpls), error);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\tif (spec) {\n+\t\tmemcpy(&mpls.val.label, spec, sizeof(mpls.val.label));\n+\t\tmemcpy(&mpls.mask.label, mask, sizeof(mpls.mask.label));\n+\t\t/* Remove unwanted bits from values. */\n+\t\tmpls.val.label &= mpls.mask.label;\n+\t}\n+\tif (size <= flow_size)\n+\t\tmlx5_flow_spec_verbs_add(flow, &mpls, size);\n+\tmlx5_flow_layers_update(flow, MLX5_FLOW_LAYER_MPLS);\n+\tif (layers & MLX5_FLOW_LAYER_OUTER_L4_UDP)\n+\t\tflow->ptype = RTE_PTYPE_TUNNEL_MPLS_IN_GRE | RTE_PTYPE_L4_UDP;\n+\telse\n+\t\tflow->ptype = RTE_PTYPE_TUNNEL_MPLS_IN_GRE;\n+\treturn size;\n+#endif /* !HAVE_IBV_DEVICE_MPLS_SUPPORT */\n+\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n+\t\t\t\t item,\n+\t\t\t\t \"MPLS is not supported by Verbs, please\"\n+\t\t\t\t \" update.\");\n+}\n+\n /**\n * Validate items provided by the user.\n *\n@@ -1650,6 +1722,9 @@ mlx5_flow_items(struct rte_eth_dev *dev,\n \t\tcase RTE_FLOW_ITEM_TYPE_GRE:\n \t\t\tret = mlx5_flow_item_gre(items, flow, remain, error);\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_MPLS:\n+\t\t\tret = mlx5_flow_item_mpls(items, flow, remain, error);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n", "prefixes": [ "v2", "19/20" ] }{ "id": 41693, "url": "