Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41716/?format=api
http://patchwork.dpdk.org/api/patches/41716/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180627163123.135686-22-jasvinder.singh@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180627163123.135686-22-jasvinder.singh@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180627163123.135686-22-jasvinder.singh@intel.com", "date": "2018-06-27T16:31:21", "name": "[v3,21/23] net/softnic: start and stop function", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "8f95600767f6f52aa011eca90150f04b7360b8ac", "submitter": { "id": 285, "url": "http://patchwork.dpdk.org/api/people/285/?format=api", "name": "Jasvinder Singh", "email": "jasvinder.singh@intel.com" }, "delegate": { "id": 10018, "url": "http://patchwork.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180627163123.135686-22-jasvinder.singh@intel.com/mbox/", "series": [ { "id": 270, "url": "http://patchwork.dpdk.org/api/series/270/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=270", "date": "2018-06-27T16:31:01", "name": "[v3,01/23] net/softnic: restructuring", "version": 3, "mbox": "http://patchwork.dpdk.org/series/270/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41716/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A81D11C295;\n\tWed, 27 Jun 2018 18:32:24 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id B21801C18F\n\tfor <dev@dpdk.org>; Wed, 27 Jun 2018 18:31:55 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Jun 2018 09:31:55 -0700", "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby fmsmga005.fm.intel.com with ESMTP; 27 Jun 2018 09:31:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,279,1526367600\"; d=\"scan'208\";a=\"240789772\"", "From": "Jasvinder Singh <jasvinder.singh@intel.com>", "To": "dev@dpdk.org", "Cc": "cristian.dumitrescu@intel.com,\n\tbernard.iremonger@intel.com", "Date": "Wed, 27 Jun 2018 17:31:21 +0100", "Message-Id": "<20180627163123.135686-22-jasvinder.singh@intel.com>", "X-Mailer": "git-send-email 2.9.3", "In-Reply-To": "<20180627163123.135686-1-jasvinder.singh@intel.com>", "References": "<20180615165224.25004-2-jasvinder.singh@intel.com>\n\t<20180627163123.135686-1-jasvinder.singh@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 21/23] net/softnic: start and stop function", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Implements softnic start and stop function.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic.c | 49 ++++++++++++++++++++-----\n drivers/net/softnic/rte_eth_softnic_internals.h | 6 +++\n drivers/net/softnic/rte_eth_softnic_pipeline.c | 12 ++++++\n drivers/net/softnic/rte_eth_softnic_swq.c | 16 ++++++++\n 4 files changed, 73 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex b5624d4..e5c6094 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -152,6 +152,26 @@ pmd_tx_queue_setup(struct rte_eth_dev *dev,\n static int\n pmd_dev_start(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tint status;\n+\n+\t/* TM */\n+\tif (tm_used(dev)) {\n+\t\tstatus = tm_start(p);\n+\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n+\n+\t/* Firmware */\n+\tstatus = cli_script_process(p,\n+\t\tp->params.firmware,\n+\t\tconn_params_default.msg_in_len_max,\n+\t\tconn_params_default.msg_out_len_max);\n+\tif (status)\n+\t\treturn status;\n+\n+\t/* Link UP */\n \tdev->data->dev_link.link_status = ETH_LINK_UP;\n \n \treturn 0;\n@@ -160,21 +180,30 @@ pmd_dev_start(struct rte_eth_dev *dev)\n static void\n pmd_dev_stop(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\n+\t/* Link DOWN */\n \tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n+\n+\t/* Firmware */\n+\tpipeline_disable_all(p);\n+\tpipeline_free(p);\n+\ttable_action_profile_free(p);\n+\tport_in_action_profile_free(p);\n+\ttap_free(p);\n+\ttmgr_free(p);\n+\tlink_free(p);\n+\tswq_free_keep_rxq_txq(p);\n+\tmempool_free(p);\n+\n+\t/* TM */\n+\ttm_stop(p);\n }\n \n static void\n-pmd_dev_close(struct rte_eth_dev *dev)\n+pmd_dev_close(struct rte_eth_dev *dev __rte_unused)\n {\n-\tuint32_t i;\n-\n-\t/* RX queues */\n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n-\t\trte_ring_free((struct rte_ring *)dev->data->rx_queues[i]);\n-\n-\t/* TX queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n-\t\trte_ring_free((struct rte_ring *)dev->data->tx_queues[i]);\n+\treturn;\n }\n \n static int\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex f3d3c20..fb04277 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -530,6 +530,9 @@ swq_init(struct pmd_internals *p);\n void\n swq_free(struct pmd_internals *p);\n \n+void\n+swq_free_keep_rxq_txq(struct pmd_internals *p);\n+\n struct swq *\n swq_find(struct pmd_internals *p,\n \tconst char *name);\n@@ -659,6 +662,9 @@ pipeline_init(struct pmd_internals *p);\n void\n pipeline_free(struct pmd_internals *p);\n \n+void\n+pipeline_disable_all(struct pmd_internals *p);\n+\n struct pipeline *\n pipeline_find(struct pmd_internals *p, const char *name);\n \ndiff --git a/drivers/net/softnic/rte_eth_softnic_pipeline.c b/drivers/net/softnic/rte_eth_softnic_pipeline.c\nindex f1a2925..d1e8e06 100644\n--- a/drivers/net/softnic/rte_eth_softnic_pipeline.c\n+++ b/drivers/net/softnic/rte_eth_softnic_pipeline.c\n@@ -61,6 +61,18 @@ pipeline_free(struct pmd_internals *p)\n \t}\n }\n \n+void\n+pipeline_disable_all(struct pmd_internals *p)\n+{\n+\tstruct pipeline *pipeline;\n+\n+\tTAILQ_FOREACH(pipeline, &p->pipeline_list, node)\n+\t\tif (pipeline->enabled)\n+\t\t\tthread_pipeline_disable(p,\n+\t\t\t\tpipeline->thread_id,\n+\t\t\t\tpipeline->name);\n+}\n+\n struct pipeline *\n pipeline_find(struct pmd_internals *p,\n \tconst char *name)\ndiff --git a/drivers/net/softnic/rte_eth_softnic_swq.c b/drivers/net/softnic/rte_eth_softnic_swq.c\nindex 3e810f3..1d81c6c 100644\n--- a/drivers/net/softnic/rte_eth_softnic_swq.c\n+++ b/drivers/net/softnic/rte_eth_softnic_swq.c\n@@ -33,6 +33,22 @@ swq_free(struct pmd_internals *p)\n \t}\n }\n \n+void\n+swq_free_keep_rxq_txq(struct pmd_internals *p)\n+{\n+\tstruct swq *swq;\n+\n+\tTAILQ_FOREACH(swq, &p->swq_list, node) {\n+\t\tif ((strncmp(swq->name, \"RXQ\", strlen(\"RXQ\")) == 0) ||\n+\t\t\t(strncmp(swq->name, \"TXQ\", strlen(\"TXQ\")) == 0))\n+\t\t\tcontinue;\n+\n+\t\tTAILQ_REMOVE(&p->swq_list, swq, node);\n+\t\trte_ring_free(swq->r);\n+\t\tfree(swq);\n+\t}\n+}\n+\n struct swq *\n swq_find(struct pmd_internals *p,\n \tconst char *name)\n", "prefixes": [ "v3", "21/23" ] }{ "id": 41716, "url": "