Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41856/?format=api
http://patchwork.dpdk.org/api/patches/41856/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180628215235.106069-9-yong.liu@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628215235.106069-9-yong.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628215235.106069-9-yong.liu@intel.com", "date": "2018-06-28T21:52:32", "name": "[v3,08/11] net/virtio: add in-order Rx/Tx into selection", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7600e50a2b065bf7b05fd781c5802434f5bef85", "submitter": { "id": 17, "url": "http://patchwork.dpdk.org/api/people/17/?format=api", "name": "Marvin Liu", "email": "yong.liu@intel.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180628215235.106069-9-yong.liu@intel.com/mbox/", "series": [ { "id": 296, "url": "http://patchwork.dpdk.org/api/series/296/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=296", "date": "2018-06-28T21:52:24", "name": "support in-order feature", "version": 3, "mbox": "http://patchwork.dpdk.org/series/296/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41856/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3F88E1B43E;\n\tThu, 28 Jun 2018 16:07:08 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 80FBF1B3A5\n\tfor <dev@dpdk.org>; Thu, 28 Jun 2018 16:06:56 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t28 Jun 2018 07:06:55 -0700", "from dpdk-test32.sh.intel.com ([10.67.119.193])\n\tby FMSMGA003.fm.intel.com with ESMTP; 28 Jun 2018 07:06:54 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,283,1526367600\"; d=\"scan'208\";a=\"60850388\"", "From": "Marvin Liu <yong.liu@intel.com>", "To": "maxime.coquelin@redhat.com,\n\ttiwei.bie@intel.com", "Cc": "zhihong.wang@intel.com,\n\tdev@dpdk.org,\n\tMarvin Liu <yong.liu@intel.com>", "Date": "Fri, 29 Jun 2018 05:52:32 +0800", "Message-Id": "<20180628215235.106069-9-yong.liu@intel.com>", "X-Mailer": "git-send-email 2.17.0", "In-Reply-To": "<20180628215235.106069-1-yong.liu@intel.com>", "References": "<20180628215235.106069-1-yong.liu@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 08/11] net/virtio: add in-order Rx/Tx into\n\tselection", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "After IN_ORDER Rx/Tx paths added, need to update Rx/Tx path selection\nlogic.\n\nRx path select logic: If IN_ORDER is disabled will select normal Rx\npath. If IN_ORDER is enabled, Rx offload and merge-able are disabled\nwill select simple Rx path. Otherwise will select IN_ORDER Rx path.\n\nTx path select logic: If IN_ORDER is disabled will select normal Tx\npath. If IN_ORDER is enabled and merge-able is disabled will select\nsimple Tx path. Otherwise will select IN_ORDER Tx path.\n\nSigned-off-by: Marvin Liu <yong.liu@intel.com>", "diff": "diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c\nindex df50a571a..2b3d65f80 100644\n--- a/drivers/net/virtio/virtio_ethdev.c\n+++ b/drivers/net/virtio/virtio_ethdev.c\n@@ -1320,6 +1320,11 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)\n \t\tPMD_INIT_LOG(INFO, \"virtio: using simple Rx path on port %u\",\n \t\t\teth_dev->data->port_id);\n \t\teth_dev->rx_pkt_burst = virtio_recv_pkts_vec;\n+\t} else if (hw->use_inorder_rx) {\n+\t\tPMD_INIT_LOG(INFO,\n+\t\t\t\"virtio: using inorder mergeable buffer Rx path on port %u\",\n+\t\t\teth_dev->data->port_id);\n+\t\teth_dev->rx_pkt_burst = &virtio_recv_mergeable_pkts_inorder;\n \t} else if (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {\n \t\tPMD_INIT_LOG(INFO,\n \t\t\t\"virtio: using mergeable buffer Rx path on port %u\",\n@@ -1335,6 +1340,10 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev)\n \t\tPMD_INIT_LOG(INFO, \"virtio: using simple Tx path on port %u\",\n \t\t\teth_dev->data->port_id);\n \t\teth_dev->tx_pkt_burst = virtio_xmit_pkts_simple;\n+\t} else if (hw->use_inorder_tx) {\n+\t\tPMD_INIT_LOG(INFO, \"virtio: using inorder Tx path on port %u\",\n+\t\t\teth_dev->data->port_id);\n+\t\teth_dev->tx_pkt_burst = virtio_xmit_pkts_inorder;\n \t} else {\n \t\tPMD_INIT_LOG(INFO, \"virtio: using standard Tx path on port %u\",\n \t\t\teth_dev->data->port_id);\n@@ -1871,24 +1880,24 @@ virtio_dev_configure(struct rte_eth_dev *dev)\n \n \trte_spinlock_init(&hw->state_lock);\n \n-\thw->use_simple_rx = 1;\n-\thw->use_simple_tx = 1;\n-\n #if defined RTE_ARCH_ARM64 || defined RTE_ARCH_ARM\n \tif (!rte_cpu_get_flag_enabled(RTE_CPUFLAG_NEON)) {\n \t\thw->use_simple_rx = 0;\n \t\thw->use_simple_tx = 0;\n \t}\n #endif\n-\tif (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {\n-\t\thw->use_simple_rx = 0;\n-\t\thw->use_simple_tx = 0;\n+\tif (vtpci_with_feature(hw, VIRTIO_F_IN_ORDER)) {\n+\t\tif (vtpci_with_feature(hw, VIRTIO_NET_F_MRG_RXBUF)) {\n+\t\t\thw->use_inorder_rx = 1;\n+\t\t\thw->use_inorder_tx = 1;\n+\t\t} else {\n+\t\t\thw->use_simple_tx = 1;\n+\t\t\tif (!(rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |\n+\t\t\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM)))\n+\t\t\t\thw->use_simple_rx = 1;\n+\t\t}\n \t}\n \n-\tif (rx_offloads & (DEV_RX_OFFLOAD_UDP_CKSUM |\n-\t\t\t DEV_RX_OFFLOAD_TCP_CKSUM))\n-\t\thw->use_simple_rx = 0;\n-\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "08/11" ] }{ "id": 41856, "url": "