Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41868/?format=api
http://patchwork.dpdk.org/api/patches/41868/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180628201549.3507-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180628201549.3507-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180628201549.3507-6-ajit.khaparde@broadcom.com", "date": "2018-06-28T20:15:31", "name": "[v2,05/23] net/bnxt: fix dev close operation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "447959d4e868c239d0828d3de7eeaca2d873c4c3", "submitter": { "id": 501, "url": "http://patchwork.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180628201549.3507-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 300, "url": "http://patchwork.dpdk.org/api/series/300/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=300", "date": "2018-06-28T20:15:29", "name": "bnxt patchset", "version": 2, "mbox": "http://patchwork.dpdk.org/series/300/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41868/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41868/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 899D61B537;\n\tThu, 28 Jun 2018 22:16:13 +0200 (CEST)", "from rnd-relay.smtp.broadcom.com (rnd-relay.smtp.broadcom.com\n\t[192.19.229.170]) by dpdk.org (Postfix) with ESMTP id 90AD31B4FE;\n\tThu, 28 Jun 2018 22:15:58 +0200 (CEST)", "from nis-sj1-27.broadcom.com (nis-sj1-27.lvn.broadcom.net\n\t[10.75.144.136])\n\tby rnd-relay.smtp.broadcom.com (Postfix) with ESMTP id 2333430C023;\n\tThu, 28 Jun 2018 13:15:54 -0700 (PDT)", "from C02VPB22HTD6.dhcp.broadcom.net (c02vpb22htd6.dhcp.broadcom.net\n\t[10.136.50.120])\n\tby nis-sj1-27.broadcom.com (Postfix) with ESMTP id 9F544AC079C;\n\tThu, 28 Jun 2018 13:15:53 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.10.3 rnd-relay.smtp.broadcom.com 2333430C023", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n\ts=dkimrelay; t=1530216954;\n\tbh=vPh4sI9l5Vh7IXgKeUuIQ2In5uRYFSAY6ckiqxBXULk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=bEDRI3mPlU4UPIqIwhgvy89eZc2BC63G7ZGMWcrhAFEqTtWw4Qz0BrTY4npkwKNW6\n\t6dTXCFaOb5TiM6JeCQCLae+fBRsOWnRwOeJiyyUTX5gjy+ZponyvReiIJS7yePOx/P\n\t26HLrODjRZqHDkyuZFmYbFr7zbXdtQwYD1fvvCJo=", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com,\n\tstable@dpdk.org", "Date": "Thu, 28 Jun 2018 13:15:31 -0700", "Message-Id": "<20180628201549.3507-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.15.2 (Apple Git-101.1)", "In-Reply-To": "<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "References": "<f02289d7-4111-ab00-9ce9-00dd5c8b3c18@intel.com>\n\t<20180628201549.3507-1-ajit.khaparde@broadcom.com>", "Subject": "[dpdk-dev] [PATCH v2 05/23] net/bnxt: fix dev close operation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "We are not cleaning up all the memory and also not unregistering\nthe driver during device close operation. This patch fixes the issue.\n\nFixes: 893074951314 (\"net/bnxt: free memory in close operation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n--\nv1->v2: Remove incorrectly added RTE_PCI_DRV_INTR_RMV.\n---\n drivers/net/bnxt/bnxt_ethdev.c | 21 +++++++++++++++++----\n 1 file changed, 17 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 33560db0d..233a7c312 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -152,6 +152,7 @@ static const struct rte_pci_id bnxt_pci_id_map[] = {\n static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask);\n static void bnxt_print_link_info(struct rte_eth_dev *eth_dev);\n static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu);\n+static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);\n \n /***********************/\n \n@@ -668,6 +669,8 @@ static void bnxt_dev_close_op(struct rte_eth_dev *eth_dev)\n \t\trte_free(bp->grp_info);\n \t\tbp->grp_info = NULL;\n \t}\n+\n+\tbnxt_dev_uninit(eth_dev);\n }\n \n static void bnxt_mac_addr_remove_op(struct rte_eth_dev *eth_dev,\n@@ -3116,7 +3119,6 @@ static int bnxt_init_board(struct rte_eth_dev *eth_dev)\n \treturn rc;\n }\n \n-static int bnxt_dev_uninit(struct rte_eth_dev *eth_dev);\n \n #define ALLOW_FUNC(x)\t\\\n \t{ \\\n@@ -3408,13 +3410,15 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev)\n }\n \n static int\n-bnxt_dev_uninit(struct rte_eth_dev *eth_dev) {\n+bnxt_dev_uninit(struct rte_eth_dev *eth_dev)\n+{\n \tstruct bnxt *bp = eth_dev->data->dev_private;\n \tint rc;\n \n \tif (rte_eal_process_type() != RTE_PROC_PRIMARY)\n \t\treturn -EPERM;\n \n+\tPMD_DRV_LOG(DEBUG, \"Calling Device uninit\\n\");\n \tbnxt_disable_int(bp);\n \tbnxt_free_int(bp);\n \tbnxt_free_mem(bp);\n@@ -3428,8 +3432,17 @@ bnxt_dev_uninit(struct rte_eth_dev *eth_dev) {\n \t}\n \trc = bnxt_hwrm_func_driver_unregister(bp, 0);\n \tbnxt_free_hwrm_resources(bp);\n-\trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n-\trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\n+\n+\tif (bp->tx_mem_zone) {\n+\t\trte_memzone_free((const struct rte_memzone *)bp->tx_mem_zone);\n+\t\tbp->tx_mem_zone = NULL;\n+\t}\n+\n+\tif (bp->rx_mem_zone) {\n+\t\trte_memzone_free((const struct rte_memzone *)bp->rx_mem_zone);\n+\t\tbp->rx_mem_zone = NULL;\n+\t}\n+\n \tif (bp->dev_stopped == 0)\n \t\tbnxt_dev_close_op(eth_dev);\n \tif (bp->pf.vf_info)\n", "prefixes": [ "v2", "05/23" ] }{ "id": 41868, "url": "