Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41925/?format=api
{ "id": 41925, "url": "http://patchwork.dpdk.org/api/patches/41925/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180629092944.15576-13-johndale@cisco.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180629092944.15576-13-johndale@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180629092944.15576-13-johndale@cisco.com", "date": "2018-06-29T09:29:41", "name": "[v2,12/15] net/enic: check maximum packet size in Tx prepare handler", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fcbe3d367505da06bce6d3b88c5064ecf7d76c0f", "submitter": { "id": 359, "url": "http://patchwork.dpdk.org/api/people/359/?format=api", "name": "John Daley (johndale)", "email": "johndale@cisco.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180629092944.15576-13-johndale@cisco.com/mbox/", "series": [ { "id": 308, "url": "http://patchwork.dpdk.org/api/series/308/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=308", "date": "2018-06-29T09:29:29", "name": "enic PMD fixes and performance improvements", "version": 2, "mbox": "http://patchwork.dpdk.org/series/308/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41925/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41925/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D4DEF1B4B9;\n\tFri, 29 Jun 2018 11:34:56 +0200 (CEST)", "from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72])\n\tby dpdk.org (Postfix) with ESMTP id A3E811B4B7\n\tfor <dev@dpdk.org>; Fri, 29 Jun 2018 11:34:55 +0200 (CEST)", "from alln-core-5.cisco.com ([173.36.13.138])\n\tby rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t29 Jun 2018 09:34:55 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id w5T9YsqC007885;\n\tFri, 29 Jun 2018 09:34:54 GMT", "by cisco.com (Postfix, from userid 392789)\n\tid A741520F2001; Fri, 29 Jun 2018 02:34:54 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=966; q=dns/txt; s=iport;\n\tt=1530264895; x=1531474495;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=dfUISO493J5eaymq4Drw0MBFdMxaZk9SL30WXWDExfs=;\n\tb=S/czW26HTmakAXquoac318uJkdDsZ7MvsXLTfu7KUF2aQ2KqJ15g9uYU\n\tlit7l0dpZ/gG1cTC2kqfwq0CjYzVCfD49MbxPJBhxhaQjoN0EB9pjorY1\n\tGUqX8YXEQpmiQ90nCSKStKSX8cxVDlNyeKFfWqAdlfbs107hyJpeYViDG o=;", "X-IronPort-AV": "E=Sophos;i=\"5.51,285,1526342400\"; d=\"scan'208\";a=\"416957367\"", "From": "John Daley <johndale@cisco.com>", "To": "ferruh.yigit@intel.com", "Cc": "dev@dpdk.org, Hyong Youb Kim <hyonkim@cisco.com>", "Date": "Fri, 29 Jun 2018 02:29:41 -0700", "Message-Id": "<20180629092944.15576-13-johndale@cisco.com>", "X-Mailer": "git-send-email 2.16.2", "In-Reply-To": "<20180629092944.15576-1-johndale@cisco.com>", "References": "<20180628031940.17397-1-johndale@cisco.com>\n\t<20180629092944.15576-1-johndale@cisco.com>", "Subject": "[dpdk-dev] [PATCH v2 12/15] net/enic: check maximum packet size in\n\tTx prepare handler", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Hyong Youb Kim <hyonkim@cisco.com>\n\nThe default tx handler checks the maximum packet size. Check it in the\nprepare handler too. WQ stops working if the app/driver tries to send\noversized packets, so these checks are unavoidable.\n\nSigned-off-by: Hyong Youb Kim <hyonkim@cisco.com>\nReviewed-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_rxtx.c | 4 ++++\n 1 file changed, 4 insertions(+)", "diff": "diff --git a/drivers/net/enic/enic_rxtx.c b/drivers/net/enic/enic_rxtx.c\nindex 7dec486fe..04a77fcb4 100644\n--- a/drivers/net/enic/enic_rxtx.c\n+++ b/drivers/net/enic/enic_rxtx.c\n@@ -563,6 +563,10 @@ uint16_t enic_prep_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \n \tfor (i = 0; i != nb_pkts; i++) {\n \t\tm = tx_pkts[i];\n+\t\tif (unlikely(m->pkt_len > ENIC_TX_MAX_PKT_SIZE)) {\n+\t\t\trte_errno = EINVAL;\n+\t\t\treturn i;\n+\t\t}\n \t\tol_flags = m->ol_flags;\n \t\tif (ol_flags & wq->tx_offload_notsup_mask) {\n \t\t\trte_errno = ENOTSUP;\n", "prefixes": [ "v2", "12/15" ] }