Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41976/?format=api
{ "id": 41976, "url": "http://patchwork.dpdk.org/api/patches/41976/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530286025-4399-1-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530286025-4399-1-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530286025-4399-1-git-send-email-arybchenko@solarflare.com", "date": "2018-06-29T15:27:05", "name": "net/sfc: discard packets with bad CRC on EF10 ESSB Rx", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1985e316e115906650a03651c6c4ac20fc8bf346", "submitter": { "id": 607, "url": "http://patchwork.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530286025-4399-1-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 327, "url": "http://patchwork.dpdk.org/api/series/327/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=327", "date": "2018-06-29T15:27:05", "name": "net/sfc: discard packets with bad CRC on EF10 ESSB Rx", "version": 1, "mbox": "http://patchwork.dpdk.org/series/327/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41976/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41976/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E23041B50E;\n\tFri, 29 Jun 2018 17:27:15 +0200 (CEST)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 3A1F51B505;\n\tFri, 29 Jun 2018 17:27:14 +0200 (CEST)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 11D4C28006D; Fri, 29 Jun 2018 15:27:13 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1044.25; Fri, 29 Jun 2018 08:27:10 -0700", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1044.25 via Frontend Transport; Fri, 29 Jun 2018 08:27:10 -0700", "from uklogin.uk.solarflarecom.com (uklogin.uk.solarflarecom.com\n\t[10.17.10.10])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw5TFR9iZ026047; Fri, 29 Jun 2018 16:27:09 +0100", "from uklogin.uk.solarflarecom.com (localhost.localdomain\n\t[127.0.0.1])\n\tby uklogin.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tw5TFR9qs004439; Fri, 29 Jun 2018 16:27:09 +0100" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "<stable@dpdk.org>", "Date": "Fri, 29 Jun 2018 16:27:05 +0100", "Message-ID": "<1530286025-4399-1-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.2.3", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-MDID": "1530286033-TIkOoqZ7s0zC", "Subject": "[dpdk-dev] [PATCH] net/sfc: discard packets with bad CRC on EF10\n\tESSB Rx", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fixes: 390f9b8d82c9 (\"net/sfc: support equal stride super-buffer Rx mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\nReviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_ef10_essb_rx.c | 7 +++++++\n drivers/net/sfc/sfc_ef10_rx_ev.h | 6 +++++-\n 2 files changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ef10_essb_rx.c b/drivers/net/sfc/sfc_ef10_essb_rx.c\nindex 5f5af602c..a3b988fcf 100644\n--- a/drivers/net/sfc/sfc_ef10_essb_rx.c\n+++ b/drivers/net/sfc/sfc_ef10_essb_rx.c\n@@ -322,6 +322,12 @@ sfc_ef10_essb_rx_get_pending(struct sfc_ef10_essb_rxq *rxq,\n \t\t\tconst efx_qword_t *qwordp;\n \t\t\tuint16_t pkt_len;\n \n+\t\t\t/* Buffers to be discarded have 0 in packet type */\n+\t\t\tif (unlikely(m->packet_type == 0)) {\n+\t\t\t\trte_mempool_put(rxq->refill_mb_pool, m);\n+\t\t\t\tgoto next_buf;\n+\t\t\t}\n+\n \t\t\trx_pkts[n_rx_pkts++] = m;\n \n \t\t\t/* Parse pseudo-header */\n@@ -357,6 +363,7 @@ sfc_ef10_essb_rx_get_pending(struct sfc_ef10_essb_rxq *rxq,\n \t\t\t\tEFX_QWORD_FIELD(*qwordp,\n \t\t\t\t\t\tES_EZ_ESSB_RX_PREFIX_MARK);\n \n+next_buf:\n \t\t\tm = sfc_ef10_essb_next_mbuf(rxq, m);\n \t\t} while (todo_bufs-- > 0);\n \t}\ndiff --git a/drivers/net/sfc/sfc_ef10_rx_ev.h b/drivers/net/sfc/sfc_ef10_rx_ev.h\nindex 615bd29b4..37b40056e 100644\n--- a/drivers/net/sfc/sfc_ef10_rx_ev.h\n+++ b/drivers/net/sfc/sfc_ef10_rx_ev.h\n@@ -37,8 +37,10 @@ sfc_ef10_rx_ev_to_offloads(const efx_qword_t rx_ev, struct rte_mbuf *m,\n \tif (unlikely(rx_ev.eq_u64[0] &\n \t\trte_cpu_to_le_64((1ull << ESF_DZ_RX_ECC_ERR_LBN) |\n \t\t\t\t (1ull << ESF_DZ_RX_ECRC_ERR_LBN) |\n-\t\t\t\t (1ull << ESF_DZ_RX_PARSE_INCOMPLETE_LBN))))\n+\t\t\t\t (1ull << ESF_DZ_RX_PARSE_INCOMPLETE_LBN)))) {\n+\t\t/* Zero packet type is used as a marker to dicard bad packets */\n \t\tgoto done;\n+\t}\n \n #if SFC_EF10_RX_EV_ENCAP_SUPPORT\n \tswitch (EFX_QWORD_FIELD(rx_ev, ESF_EZ_RX_ENCAP_HDR)) {\n@@ -157,6 +159,8 @@ sfc_ef10_rx_ev_to_offloads(const efx_qword_t rx_ev, struct rte_mbuf *m,\n \t\tSFC_ASSERT(false);\n \t}\n \n+\tSFC_ASSERT(l2_ptype != 0);\n+\n done:\n \tm->ol_flags = ol_flags & ol_mask;\n \tm->packet_type = tun_ptype | l2_ptype | l3_ptype | l4_ptype;\n", "prefixes": [] }