Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/41984/?format=api
http://patchwork.dpdk.org/api/patches/41984/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180629172738.2121-5-gavin.hu@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180629172738.2121-5-gavin.hu@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180629172738.2121-5-gavin.hu@arm.com", "date": "2018-06-29T17:27:36", "name": "[v14,4/6] devtools: fix the missing ninja command error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d5052d1206f9eacc63022582bb6e8979d28a02c6", "submitter": { "id": 1018, "url": "http://patchwork.dpdk.org/api/people/1018/?format=api", "name": "Gavin Hu", "email": "gavin.hu@arm.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180629172738.2121-5-gavin.hu@arm.com/mbox/", "series": [ { "id": 330, "url": "http://patchwork.dpdk.org/api/series/330/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=330", "date": "2018-06-29T17:27:32", "name": "Fix the cross compiling errors", "version": 14, "mbox": "http://patchwork.dpdk.org/series/330/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/41984/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/41984/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 54DB11B8B9;\n\tFri, 29 Jun 2018 19:28:04 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 133F91B05F;\n\tFri, 29 Jun 2018 19:27:56 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 837181529;\n\tFri, 29 Jun 2018 10:27:55 -0700 (PDT)", "from net-debian.shanghai.arm.com (net-debian.shanghai.arm.com\n\t[10.169.36.53])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\tC7BF23F5AD; Fri, 29 Jun 2018 10:27:54 -0700 (PDT)" ], "From": "Gavin Hu <gavin.hu@arm.com>", "To": "dev@dpdk.org", "Cc": "nd@arm.com,\n\tgavin.hu@arm.com,\n\tstable@dpdk.org", "Date": "Sat, 30 Jun 2018 01:27:36 +0800", "Message-Id": "<20180629172738.2121-5-gavin.hu@arm.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": "<20180629172738.2121-1-gavin.hu@arm.com>", "References": "<20180625024913.17219-1-gavin.hu@arm.com>\n\t<20180629172738.2121-1-gavin.hu@arm.com>", "Subject": "[dpdk-dev] [PATCH v14 4/6] devtools: fix the missing ninja command\n\terror", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On some linux distributions, eg: CentOS, the ninja executable has a\ndifferent name: ninja-build, this patch is to check and adapt to it\naccordingly.\n\n./devtools/test-meson-builds.sh: line 24: ninja: command not found\n\nFixes: a55277a788 (\"devtools: add test script for meson builds\")\nCc: stable@dpdk.org\n\nSigned-off-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Song Zhu <song.zhu@arm.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n devtools/test-meson-builds.sh | 13 +++++++++++--\n 1 file changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex f2ad05f32..9bb5b93bd 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -10,6 +10,15 @@\n srcdir=$(dirname $(readlink -m $0))/..\n MESON=${MESON:-meson}\n \n+if command -v ninja >/dev/null 2>&1 ; then\n+ ninja_cmd=ninja\n+elif command -v ninja-build >/dev/null 2>&1 ; then\n+ ninja_cmd=ninja-build\n+else\n+ echo \"## ERROR: ninja is missing, please install...\"\n+ exit 1\n+fi\n+\n build () # <directory> <meson options>\n {\n \tbuilddir=$1\n@@ -20,8 +29,8 @@ build () # <directory> <meson options>\n \t\t$MESON $options $srcdir $builddir\n \t\tunset CC\n \tfi\n-\techo \"ninja -C $builddir\"\n-\tninja -C $builddir\n+\techo \"$ninja_cmd -C $builddir\"\n+\t$ninja_cmd -C $builddir\n }\n \n # shared and static linked builds with gcc and clang\n", "prefixes": [ "v14", "4/6" ] }{ "id": 41984, "url": "