Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42031/?format=api
http://patchwork.dpdk.org/api/patches/42031/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180702041801.27072-1-qi.z.zhang@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180702041801.27072-1-qi.z.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180702041801.27072-1-qi.z.zhang@intel.com", "date": "2018-07-02T04:18:01", "name": "net/ixgbe: fix missing NULL point check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a591df5e5a9b32ebdfd0a12411d6330dc1e4f61a", "submitter": { "id": 504, "url": "http://patchwork.dpdk.org/api/people/504/?format=api", "name": "Qi Zhang", "email": "qi.z.zhang@intel.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180702041801.27072-1-qi.z.zhang@intel.com/mbox/", "series": [ { "id": 341, "url": "http://patchwork.dpdk.org/api/series/341/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=341", "date": "2018-07-02T04:18:01", "name": "net/ixgbe: fix missing NULL point check", "version": 1, "mbox": "http://patchwork.dpdk.org/series/341/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42031/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/42031/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B6DB7378B;\n\tMon, 2 Jul 2018 06:17:30 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id A7B8E3772;\n\tMon, 2 Jul 2018 06:17:28 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 Jul 2018 21:17:26 -0700", "from dpdk51.sh.intel.com ([10.67.110.190])\n\tby orsmga008.jf.intel.com with ESMTP; 01 Jul 2018 21:17:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,297,1526367600\"; d=\"scan'208\";a=\"53741677\"", "From": "Qi Zhang <qi.z.zhang@intel.com>", "To": "remy.horton@intel.com", "Cc": "wenzhuo.lu@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>,\n\tstable@dpdk.org", "Date": "Mon, 2 Jul 2018 12:18:01 +0800", "Message-Id": "<20180702041801.27072-1-qi.z.zhang@intel.com>", "X-Mailer": "git-send-email 2.13.6", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix missing NULL point check", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add missing NULL point check in ixgbe_pf_host_uninit, or it may cause\nsegement fault when detach a device. \n\nFixes: cf80ba6e2038 (\"net/ixgbe: add support for representor ports\")\nCc: stable@dpdk.org\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\n---\n drivers/net/ixgbe/ixgbe_pf.c | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_pf.c b/drivers/net/ixgbe/ixgbe_pf.c\nindex 4d199c8..73f0e43 100644\n--- a/drivers/net/ixgbe/ixgbe_pf.c\n+++ b/drivers/net/ixgbe/ixgbe_pf.c\n@@ -128,21 +128,24 @@ void ixgbe_pf_host_uninit(struct rte_eth_dev *eth_dev)\n \n \tPMD_INIT_FUNC_TRACE();\n \n-\tvfinfo = IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private);\n-\n \tRTE_ETH_DEV_SRIOV(eth_dev).active = 0;\n \tRTE_ETH_DEV_SRIOV(eth_dev).nb_q_per_pool = 0;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_vmdq_idx = 0;\n \tRTE_ETH_DEV_SRIOV(eth_dev).def_pool_q_idx = 0;\n \n-\tret = rte_eth_switch_domain_free((*vfinfo)->switch_domain_id);\n-\tif (ret)\n-\t\tPMD_INIT_LOG(WARNING, \"failed to free switch domain: %d\", ret);\n-\n \tvf_num = dev_num_vf(eth_dev);\n \tif (vf_num == 0)\n \t\treturn;\n \n+\tvfinfo = IXGBE_DEV_PRIVATE_TO_P_VFDATA(eth_dev->data->dev_private);\n+\n+\tif (*vfinfo == NULL)\n+\t\treturn;\n+\n+\tret = rte_eth_switch_domain_free((*vfinfo)->switch_domain_id);\n+\tif (ret)\n+\t\tPMD_INIT_LOG(WARNING, \"failed to free switch domain: %d\", ret);\n+\n \trte_free(*vfinfo);\n \t*vfinfo = NULL;\n }\n", "prefixes": [] }{ "id": 42031, "url": "