Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42098/?format=api
http://patchwork.dpdk.org/api/patches/42098/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180702145547.8376-1-remy.horton@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180702145547.8376-1-remy.horton@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180702145547.8376-1-remy.horton@intel.com", "date": "2018-07-02T14:55:47", "name": "[v1] lib/metrics: fix silent fail when uninitialised", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "516cbc459641ee470804bdc8cd99b1afa0da5f6b", "submitter": { "id": 326, "url": "http://patchwork.dpdk.org/api/people/326/?format=api", "name": "Remy Horton", "email": "remy.horton@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180702145547.8376-1-remy.horton@intel.com/mbox/", "series": [ { "id": 356, "url": "http://patchwork.dpdk.org/api/series/356/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=356", "date": "2018-07-02T14:55:47", "name": "[v1] lib/metrics: fix silent fail when uninitialised", "version": 1, "mbox": "http://patchwork.dpdk.org/series/356/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42098/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42098/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 451251B39C;\n\tMon, 2 Jul 2018 16:55:53 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 0A33E7EB4\n\tfor <dev@dpdk.org>; Mon, 2 Jul 2018 16:55:50 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2018 07:55:49 -0700", "from rhorton-mobl1.ger.corp.intel.com (HELO FC23.ir.intel.com)\n\t([163.33.178.248])\n\tby fmsmga005.fm.intel.com with ESMTP; 02 Jul 2018 07:55:48 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,299,1526367600\"; d=\"scan'208\";a=\"242003989\"", "From": "Remy Horton <remy.horton@intel.com>", "To": "dev@dpdk.org", "Cc": "Reshma Pattan <reshma.pattan@intel.com>", "Date": "Mon, 2 Jul 2018 15:55:47 +0100", "Message-Id": "<20180702145547.8376-1-remy.horton@intel.com>", "X-Mailer": "git-send-email 2.9.5", "Subject": "[dpdk-dev] [PATCH v1] lib/metrics: fix silent fail when\n\tuninitialised", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If rte_metrics_init() had not been called and hence the internal\nmetric storage is not allocated, rte_metrics_get_values() and\nrte_metrics_get_name() would silently fail by returning zero\n(i.e. no metrics registered). This patch changes the result of\nthis scenario to an explicit fail by returning -EIO.\n\nFixes: 349950ddb9c5 (\"metrics: add information metrics library\")\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n lib/librte_metrics/rte_metrics.c | 7 +++----\n 1 file changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c\nindex 258f058..fed0a33 100644\n--- a/lib/librte_metrics/rte_metrics.c\n+++ b/lib/librte_metrics/rte_metrics.c\n@@ -200,9 +200,8 @@ rte_metrics_get_names(struct rte_metric_name *names,\n \tint return_value;\n \n \tmemzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);\n-\t/* If not allocated, fail silently */\n \tif (memzone == NULL)\n-\t\treturn 0;\n+\t\treturn -EIO;\n \n \tstats = memzone->addr;\n \trte_spinlock_lock(&stats->lock);\n@@ -238,9 +237,9 @@ rte_metrics_get_values(int port_id,\n \t\treturn -EINVAL;\n \n \tmemzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME);\n-\t/* If not allocated, fail silently */\n \tif (memzone == NULL)\n-\t\treturn 0;\n+\t\treturn -EIO;\n+\n \tstats = memzone->addr;\n \trte_spinlock_lock(&stats->lock);\n \n", "prefixes": [ "v1" ] }{ "id": 42098, "url": "