Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42120/?format=api
http://patchwork.dpdk.org/api/patches/42120/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530552334-22169-1-git-send-email-fiona.trahe@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530552334-22169-1-git-send-email-fiona.trahe@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530552334-22169-1-git-send-email-fiona.trahe@intel.com", "date": "2018-07-02T17:25:34", "name": "common/qat: replace snprintf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "80534979a5039b960e0b8ec5732a0ee0672be9d2", "submitter": { "id": 423, "url": "http://patchwork.dpdk.org/api/people/423/?format=api", "name": "Fiona Trahe", "email": "fiona.trahe@intel.com" }, "delegate": { "id": 22, "url": "http://patchwork.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530552334-22169-1-git-send-email-fiona.trahe@intel.com/mbox/", "series": [ { "id": 363, "url": "http://patchwork.dpdk.org/api/series/363/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=363", "date": "2018-07-02T17:25:34", "name": "common/qat: replace snprintf", "version": 1, "mbox": "http://patchwork.dpdk.org/series/363/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42120/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/42120/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E3E91B55E;\n\tMon, 2 Jul 2018 19:25:59 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 5D5581B553\n\tfor <dev@dpdk.org>; Mon, 2 Jul 2018 19:25:55 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 Jul 2018 10:25:53 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga001.fm.intel.com with ESMTP; 02 Jul 2018 10:25:37 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,299,1526367600\"; d=\"scan'208\";a=\"69056133\"", "From": "Fiona Trahe <fiona.trahe@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,\n\ttomaszx.jozwiak@intel.com", "Date": "Mon, 2 Jul 2018 18:25:34 +0100", "Message-Id": "<1530552334-22169-1-git-send-email-fiona.trahe@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] common/qat: replace snprintf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replaced snprintf with strlcpy for safer string copy\n\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\n---\n drivers/common/qat/qat_device.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/qat/qat_device.c b/drivers/common/qat/qat_device.c\nindex 64f236e..f32d723 100644\n--- a/drivers/common/qat/qat_device.c\n+++ b/drivers/common/qat/qat_device.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2018 Intel Corporation\n */\n \n+#include <rte_string_fns.h>\n+\n #include \"qat_device.h\"\n #include \"adf_transport_access_macros.h\"\n #include \"qat_sym_pmd.h\"\n@@ -116,7 +118,7 @@ qat_pci_device_allocate(struct rte_pci_device *pci_dev)\n \n \tqat_dev = qat_pci_get_dev(qat_dev_id);\n \tmemset(qat_dev, 0, sizeof(*qat_dev));\n-\tsnprintf(qat_dev->name, QAT_DEV_NAME_MAX_LEN, \"%s\", name);\n+\tstrlcpy(qat_dev->name, name, QAT_DEV_NAME_MAX_LEN);\n \tqat_dev->qat_dev_id = qat_dev_id;\n \tqat_dev->pci_dev = pci_dev;\n \tswitch (qat_dev->pci_dev->id.device_id) {\n", "prefixes": [] }{ "id": 42120, "url": "