Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42195/?format=api
{ "id": 42195, "url": "http://patchwork.dpdk.org/api/patches/42195/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/bde8295eb7ab388bb9054d11031a411f27e7feea.1530655929.git.gaetan.rivet@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<bde8295eb7ab388bb9054d11031a411f27e7feea.1530655929.git.gaetan.rivet@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/bde8295eb7ab388bb9054d11031a411f27e7feea.1530655929.git.gaetan.rivet@6wind.com", "date": "2018-07-03T22:15:09", "name": "[v9,26/27] ethdev: process declarative eth devargs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a9b1c6e7357de542e280cd81ad7102af1d9a30e6", "submitter": { "id": 269, "url": "http://patchwork.dpdk.org/api/people/269/?format=api", "name": "Gaëtan Rivet", "email": "gaetan.rivet@6wind.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/bde8295eb7ab388bb9054d11031a411f27e7feea.1530655929.git.gaetan.rivet@6wind.com/mbox/", "series": [ { "id": 383, "url": "http://patchwork.dpdk.org/api/series/383/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=383", "date": "2018-07-03T22:14:43", "name": "Device querying", "version": 9, "mbox": "http://patchwork.dpdk.org/series/383/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42195/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42195/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D0D0B1BEFE;\n\tWed, 4 Jul 2018 00:16:18 +0200 (CEST)", "from mail-wm0-f43.google.com (mail-wm0-f43.google.com\n\t[74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 2DB711BEBD\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 00:16:11 +0200 (CEST)", "by mail-wm0-f43.google.com with SMTP id v25-v6so3822428wmc.0\n\tfor <dev@dpdk.org>; Tue, 03 Jul 2018 15:16:11 -0700 (PDT)", "from bidouze.dev.6wind.com. (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\ti190-v6sm3771084wmd.33.2018.07.03.15.16.09\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 03 Jul 2018 15:16:09 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:in-reply-to:references;\n\tbh=QdFoI4PAYRZ4EyFu4BqTTYdN+Gh8G7Ywbw5IuLjj6nA=;\n\tb=bruDLuXHz9McHIK2p1gDBGc/YpF01z4wipMcx1027ldFiu1IBSADqLm5CXOeFzxoE2\n\tRgU9PLeRiab32b7bk6bAjnoubnW4V6Bg1+KbMHOhDi1fcruHHIaPtcGomULM7u10PDWP\n\toKm1tGIL+LGIXgYi01C5XBlRbHFlPEpPKg8N1iEpRyOmkSUb2KxpWth2i1DRcvSkag6t\n\t13OkZXntgiUhme/+dtl/Qqb12qn649DrfRmYnBijPGgiJBMjFoxnO7RO3tLIfyCR5bFh\n\tjVwrKxpSDIgGmoD/y2DYE+zwhAYOawI/2ilVlBEdsfqHi4KR3Uub1yAD3QnoOzXD3k2k\n\tae4Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:in-reply-to:references;\n\tbh=QdFoI4PAYRZ4EyFu4BqTTYdN+Gh8G7Ywbw5IuLjj6nA=;\n\tb=lNPcjWQbKuH2tyW+Py78towrBtqqFDqfDaL9QlioyeUTVsh9VLZy1Usem2Y+Z55WdS\n\tCflpmFPjUHskSMagL7ZYSChzpbw8l20thz0Gz/lroo9ZT0JCMAYyBvuQldRw1yOslxGv\n\toBbtT6XUoAJ3XG/QBP4EPps0tVk16mYKYXNmmXIa5XD9X7jwRR5epf5CzCQ/WfyInusm\n\tpQ5wH8GhDz3WNYt9ajbMktl5Kvv7kT2Lu4Mt4yvtAflzXlKUW/YEpRa61F2Mzj8jg9C0\n\tIjbBZZ7s/MdAvvuUF1gdrYZj2DAG3/qd5oK6wrE6s+P91QT6+SSILOyiuQ8VqYBf2Rle\n\tgUTQ==", "X-Gm-Message-State": "APt69E2gYbdY4UMvVqAaLCaoN1d9VnzlxH0yPmo8F1jD/l5503HrpNCH\n\tQnLM1J2e4hc7cwHyaGYHdIQL8apH", "X-Google-Smtp-Source": "AAOMgpeLtjW23Gm2qLlrxDsYOI5lrnZhxnum3G59bC+4db4fTY42+a7teLRCljT8kgRxn25J7fAVGw==", "X-Received": "by 2002:a1c:5b88:: with SMTP id\n\tp130-v6mr12386388wmb.69.1530656170537; \n\tTue, 03 Jul 2018 15:16:10 -0700 (PDT)", "From": "Gaetan Rivet <gaetan.rivet@6wind.com>", "To": "dev@dpdk.org", "Cc": "Gaetan Rivet <gaetan.rivet@6wind.com>", "Date": "Wed, 4 Jul 2018 00:15:09 +0200", "Message-Id": "<bde8295eb7ab388bb9054d11031a411f27e7feea.1530655929.git.gaetan.rivet@6wind.com>", "X-Mailer": "git-send-email 2.11.0", "In-Reply-To": [ "<cover.1530655929.git.gaetan.rivet@6wind.com>", "<cover.1530655929.git.gaetan.rivet@6wind.com>" ], "References": [ "<cover.1521124599.git.gaetan.rivet@6wind.com>\n\t<cover.1530655929.git.gaetan.rivet@6wind.com>", "<cover.1530655929.git.gaetan.rivet@6wind.com>" ], "Subject": "[dpdk-dev] [PATCH v9 26/27] ethdev: process declarative eth devargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Process the class-specific arguments in a devargs.\nThis processing takes the form of setting the proper eth_dev fields when\nrelevant.\n\nSigned-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>\n---\n lib/librte_ethdev/eth_private.h | 5 ++++\n lib/librte_ethdev/rte_class_eth.c | 61 +++++++++++++++++++++++++++++++++++++++\n lib/librte_ethdev/rte_ethdev.c | 7 +++++\n 3 files changed, 73 insertions(+)", "diff": "diff --git a/lib/librte_ethdev/eth_private.h b/lib/librte_ethdev/eth_private.h\nindex 0f5c6d5c4..c0c065165 100644\n--- a/lib/librte_ethdev/eth_private.h\n+++ b/lib/librte_ethdev/eth_private.h\n@@ -19,6 +19,11 @@ struct rte_eth_dev *\n eth_find_device(const struct rte_eth_dev *_start, rte_eth_cmp_t cmp,\n \t\tconst void *data);\n \n+/* Generic rte_eth_dev parameters processor. */\n+int\n+rte_eth_dev_args_parse(struct rte_eth_dev *eth_dev,\n+\t\t struct rte_devargs *da);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c\nindex d8d8e8845..f02b6fd6a 100644\n--- a/lib/librte_ethdev/rte_class_eth.c\n+++ b/lib/librte_ethdev/rte_class_eth.c\n@@ -35,6 +35,19 @@ struct eth_dev_match_arg {\n \t\t.kvlist = (k), \\\n \t})\n \n+typedef int (*eth_dev_set_t)(struct rte_eth_dev *edev, const char *value);\n+\n+static enum eth_params\n+ethdev_param_id(const char *key)\n+{\n+\tint i;\n+\n+\tfor (i = 0; i < RTE_ETH_PARAMS_MAX; i++)\n+\t\tif (strcmp(key, eth_params_keys[i]) == 0)\n+\t\t\treturn i;\n+\treturn RTE_ETH_PARAMS_MAX;\n+}\n+\n static int\n eth_dev_match(const struct rte_eth_dev *edev,\n \t const void *_arg)\n@@ -79,6 +92,54 @@ eth_dev_iterate(const void *start,\n \treturn edev;\n }\n \n+static int\n+eth_dev_set_name(struct rte_eth_dev *edev,\n+\t\t const char *value)\n+{\n+\tsnprintf(edev->data->name,\n+\t\t sizeof(edev->data->name),\n+\t\t \"%s\", value);\n+\treturn 0;\n+}\n+\n+static int\n+ethdev_args_process(const char *key,\n+\t\t const char *value,\n+\t\t void *_edev)\n+{\n+\tstatic eth_dev_set_t eth_dev_set[] = {\n+\t\t[RTE_ETH_PARAMS_NAME] = eth_dev_set_name,\n+\t\t[RTE_ETH_PARAMS_MAX] = NULL,\n+\t};\n+\tstruct rte_eth_dev *edev = _edev;\n+\tint param;\n+\n+\tparam = ethdev_param_id(key);\n+\tif (eth_dev_set[param])\n+\t\treturn eth_dev_set[param](edev, value);\n+\treturn 0;\n+}\n+\n+int\n+rte_eth_dev_args_parse(struct rte_eth_dev *edev,\n+\t\t struct rte_devargs *da)\n+{\n+\tstruct rte_kvargs *kvargs = NULL;\n+\n+\tif (da == NULL || da->clsstr == NULL)\n+\t\treturn 0;\n+\n+\tkvargs = rte_kvargs_parse2(da->clsstr, eth_params_keys, \"/\");\n+\tif (kvargs == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"cannot parse argument list\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\tif (rte_kvargs_process(kvargs, NULL, ethdev_args_process, edev))\n+\t\treturn -1;\n+\trte_kvargs_free(kvargs);\n+\treturn 0;\n+}\n+\n struct rte_class rte_class_eth = {\n \t.dev_iterate = eth_dev_iterate,\n };\ndiff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex cce20d9ae..4583509dd 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -41,6 +41,7 @@\n #include \"rte_ethdev.h\"\n #include \"rte_ethdev_driver.h\"\n #include \"ethdev_profile.h\"\n+#include \"eth_private.h\"\n \n static int ethdev_logtype;\n \n@@ -3594,6 +3595,12 @@ rte_eth_dev_create(struct rte_device *device, const char *name,\n \t\t}\n \t}\n \n+\tretval = rte_eth_dev_args_parse(ethdev, device->devargs);\n+\tif (retval) {\n+\t\tRTE_LOG(ERR, EAL, \"ethdev parsing failed\");\n+\t\tgoto probe_failed;\n+\t}\n+\n \tretval = ethdev_init(ethdev, init_params);\n \tif (retval) {\n \t\tRTE_LOG(ERR, EAL, \"ethdev initialisation failed\");\n", "prefixes": [ "v9", "26/27" ] }