Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42218/?format=api
{ "id": 42218, "url": "http://patchwork.dpdk.org/api/patches/42218/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530697431-1244-16-git-send-email-hemant.agrawal@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530697431-1244-16-git-send-email-hemant.agrawal@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530697431-1244-16-git-send-email-hemant.agrawal@nxp.com", "date": "2018-07-04T09:43:51", "name": "[v2,16/16] net/dpaa: implement scatter offload support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "621a53a50518475e35faa72e9664a77b8daf52fe", "submitter": { "id": 477, "url": "http://patchwork.dpdk.org/api/people/477/?format=api", "name": "Hemant Agrawal", "email": "hemant.agrawal@nxp.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530697431-1244-16-git-send-email-hemant.agrawal@nxp.com/mbox/", "series": [ { "id": 390, "url": "http://patchwork.dpdk.org/api/series/390/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=390", "date": "2018-07-04T09:43:37", "name": "[v2,01/16] bus/dpaa: fix phandle support for kernel 4.16", "version": 2, "mbox": "http://patchwork.dpdk.org/series/390/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42218/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E0C121BF4E;\n\tWed, 4 Jul 2018 11:45:55 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30067.outbound.protection.outlook.com [40.107.3.67])\n\tby dpdk.org (Postfix) with ESMTP id DD3301BE8D\n\tfor <dev@dpdk.org>; Wed, 4 Jul 2018 11:45:43 +0200 (CEST)", "from bf-netperf1.ap.freescale.net (14.142.187.166) by\n\tDB4PR04MB0765.eurprd04.prod.outlook.com (2a01:111:e400:984d::18) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.906.25;\n\tWed, 4 Jul 2018 09:45:41 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=knsbvMTCuA0ZS5MYChTXetVDL9hzN5trC0SDaJ3lhBA=;\n\tb=qFX8VhRHjgDFRoZk4K3kFIw9Occ+IYa6R0qpx7Ro/V0+149SY1f6usaV2lGumHMJzq97KeCq7nT0yjb8mbDOZXzBdtM8lujkfTDQc3QvFhKzjoeHqrhkvHctdid5esq+M6g56F7Jxi/e3dZaPpgYeKFte3Ini0fySZBHOSkWow0=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=hemant.agrawal@nxp.com; ", "From": "Hemant Agrawal <hemant.agrawal@nxp.com>", "To": "dev@dpdk.org", "Date": "Wed, 4 Jul 2018 15:13:51 +0530", "Message-Id": "<1530697431-1244-16-git-send-email-hemant.agrawal@nxp.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com>", "References": "<1529574244-18997-1-git-send-email-hemant.agrawal@nxp.com>\n\t<1530697431-1244-1-git-send-email-hemant.agrawal@nxp.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[14.142.187.166]", "X-ClientProxiedBy": "BM1PR0101CA0008.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::18) To DB4PR04MB0765.eurprd04.prod.outlook.com\n\t(2a01:111:e400:984d::18)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "94f6368f-e512-4b50-7eab-08d5e192e85d", "X-MS-Office365-Filtering-HT": "Tenant", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(48565401081)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:DB4PR04MB0765; ", "X-Microsoft-Exchange-Diagnostics": [ "1; DB4PR04MB0765;\n\t3:FsU1lM8Syv3xv+4Cb9MpIAihuX6yLdMlMXjfp6/6nJlpZ08Y3Pf2pa274zQAjkTc6xlS99AWIVPO8qP0Y8+Xvi/n9mTSQSU1gAZelcJGmXUlMY1x4PMYLjt0cwxKVGazAdhCgp2uzF8krSBvcvyOIqUavfqMQo5TZNUWFs0Iu5ID/N6ZRTSirEROd+egdy7eOPl4zeZbMnq7ibV2UoRlZr/GDAGt2iPMwCEomlDK7skreJLKoG8y6oF/1XX3dPE5;\n\t25:cAkcNRN2Ah+1AmdlN30JF7M5edoEDSlimqxhF8VrNO9iV//EkEjqu0szQNMD+mTXhka4HASiyk6iKLgTK9ZbZcTi0ibzetmRL2WF0zX0mJQRDl2IRaSxIGbpJOvcFrdUAGamLuDkERb1skelrtW3m9dTc7Q31ax3qXRvgceyHmADgnhF2vvLPTbFZd0dgfiroQbOWv3zthbePvOx8wrB4xZOzpwP/QJ53PiqiuDwz0z4ZUaqHta26gZueTUIfZjPlNmflNVmAb96esy6xB5pTn8KHX8HcWq9QqnQ4DL8ezSpR03oSSBi1E10QfpsJVFYsHb8r3s3evh1zY6Uyzba+w==;\n\t31:QM6g23huWlTVTpzxDGKuMdwvk1hBu4TQTvI7VcY5bjW2hvqGs7LR2qilero5ZBxXD3HwYfHeWe/A5ot0/E0cgphdiOqL1KQwJAi8LJ0PLYoDEOwRuSiopLX9ePWu1mz5rW4rFnWVMIkpTSJ5bgDxAVvtUTxINaZTbl1LoPeg8xGyKJnKEVH5hJT94Y/igqDz7+6yjxJnH5hm3GcfxLE1XRpojmbEfrjIcNpNe1cXyaY=", "1; DB4PR04MB0765;\n\t20:BV0F0mLp4ok8ZkwWY1zj6ckgdO7aYCt0uCIcB3iNVnFu+ap7MdyTUJYNxI1XN2Vn6BIfgAsjR4dsDk7mPqJC7VbnHPaSVSjbc7sy5Ajewim7FdAaPA/OyoOdSVJaGKzMyXUqTPNwmG61NJ7TLdr/aSGajrNSkgIiPqTK1kvGTmae4281N2ADv+PBtFrYp3oCS6TeeqZLeB2uho6c9wM8gVYQTlJfs3Wl6tMNZJsZsEyFH7islrKS8dRLM0Omvbm4mA/fB29ke8DrRSviM1Ulumv0NSjGQixMrN4It3N9K4Cp1ioBgxVSnL4D9ya8t2QZFOZfwIVjYlh5MInH8lYyxWcDuuiVb38MJzdSPJ0gqQXbkixYHMFT3mjP6UEiKy/b0z4mC7YTAdYZobaDpHkwuK7PGXfrqQzuGzTj8+S98tYzWrEFppsn+cbupUBDdXGOHg9IzbrBaHdpgJRy9E55cEWAb5OfaA2yYmRM3rYNJBRyXMmDXewfCFSsDb2zVJWN;\n\t4:bGwsiqGMbdwdRNpToJhEmEzhVb9UIgKVTtVyAZ7zrf4PIEIOm2HkeVa6JlA//ImiRAqP3/mHfwj70HyKmB2X8h4Ky30oB4i8bcQoBFilyUlpqa4N0WoK6Xy7I4n+6g/Q+eXzYql5NF4OfdSekP5c5Ey4mIf93F44bTQzdCyTzeMkU0vjgblKiY+RkdSYNF0sDMKbQYwEe+yi7LjKmT6246fZ0P7qQZBfJZgYxGuLO87pMkCozn1nCguewJPuGASBA1di7feeP9Ueu8LpAThZT/KB+4nvve6jnr4y2FD+klLyo58DWI6ttvLdQx/T6SaN", "=?us-ascii?Q?1; DB4PR04MB0765;\n\t23:R7+XjrVHoXfxzN4vj9fseGpmmp0L7T34+QZq61py0?=\n\t5Wi2qIUBlbZhvHsDPzqvy8Zsc5m2LFd84QdBnPXFKKF6C/CSp5YBjElYlfp21xEZ9CBeO0KOKAkGEoBW5gSc7641ZsrpnP703PEkjH7LtKazHHQ0PR81GDyLmclkIrWRY4kcoMoWy2dbDc0onfPxXjTYUKG8LdqXtHxrCpM0fN8w5Cs9KMbkhT8WguAguFx4dJMOFPX1uZcmJwdeT5EAg6gcxqBt3dblHgr6mPvYJzgQx6XOWH0Mq/L4msAQg8VePWZtvpL7neWlc6OkcAohG2UxVXnnkR8qX/kODQY2QUbNHqLy/W9lAtRbKguPblOjHvEbvpHUZNudU9RRz/xJesrA05GZyOiXudevDi/D1EGFAXT8S1gUAlxGDW0Jw0hspFF50/byG/wSDDF03ye4//9w0PqfIGn2MpniMZMQEW9fJDrlwJr9Odyh4gyHQLkNCCPy5tJ1CVEJXmc/i0BYalh/QtvrLVAFlpZktoqkShmPj4FZDguGwew39E51zyNkGPFUSCUO237MbER2vpJq38frvsRZxfQlMJAF92jn95sKIT66TrVQ9iC53nrIZS4brN5PXLyFbNQrqT36xLkFc1n5v16vBH9oiKeN68Y+lk8MzqHqjVd3OTQ50NXSilYvrd/cCUKl64sPk285pZ7aFszYeRyFSWsfN/ax638pb3BN6lwrRLpzEfemc29JEhZRwJ66Cde/MuZldhOSJYOJ2vzDh8u6TLaXxvQH59KAqgHP3JLhAA/GJ2iMG9Qlbt4BkgyxpP8+sGR9c5pUvHk1+OmlWSiT5eXZuQd+W2sjgFl/rCVbg3vBc409q9kax2EsjxS7NEct8ZxpWMpaFgB3e0wIZk/WPibwZsvXEpKi+mOzqucpnjpJcq5PDsUQa6mlU5hUZYOAKJgud72u4pDSntSIr9O4YMNXi4orqahqCzBRemy+gyhqNzm0WQnondmi1uawM0FKT/Bav7uprXys3GpP7Mdm+Lzu1KUR33Vi0pv0kWISpZiRZNdA3r3Kck5AKpEwznWwn5od2dQzMtgZ+6wwSX6nRtQwmWQzhQgLNKBHTf5D8DQbf+xhAj0R6oxnA4buJmEdua5uQtTiuPfIOFmNw/yNforsoEB7/EMwAoZ9lcnRiKjcZjdcfcqjQmH1CPnh8iEBkvioYEEYCswW+Hc6PV8oMK0dZvjE30dBrV7MfFtaVOPBnyJX8F7zYi7u/N3/Kt4jYEdBQQz7VuPQ5qLXTh7oz0nAwuKqFtPYfcpCem0hzTyE5+ns8cFmAaOjfXB2MX10OpuDWUmfDO4RxyPASXkGOaosSPYiwKAxlhKsg==", "1; DB4PR04MB0765;\n\t6:G+Nov0YVbHk/0lhnSnoJFynjQdKKN+sfE1bOox8zuOXL84K4Np5MEQIDqHYRq/8zrL5uV/DsnjsvJfcdqtVLZ3D/h1ExWP0r1qQsSbOVjIO+PfQBWQ/9Kq4FFBUFGiNX8SVBb+c6267kauGeNX+fzcxWc0f+fEh5nMsrnWCgEebwPk2Vr/1jg5XmDLcaF6Wc1KOAvmw8qEmekS3eMn1x4lamShizkqUsDnnYTQkQEDXzqEMcAtMvLytqIYleL9QgIuBbkHRRwZWSRLp2Hcjq3Hy7JilRV7KPYLBHbRLEqJqf4unLaGPJFYexjuabEXwW4pvDJoLby5gtdmtLiHE12QbKItRIBhBw76LoXcMijNGAnc3T9xTS4zuMU4fa7scNIbe7d695AXhlYwCWpnFTeJIOG6F6hAJlt6NTen+HE/BcpopdYjPjmD240e+PlXj/363FAlC2T2Rrl6BRRcGnfw==;\n\t5:gdY7t0lL9cpPdhM+I8NRUS3HANTETJVDdsLpaMocbckcPDzAP8VAX11cPDq8h90ZXal9zfe7xM5EzRH0RIAJRMD9rmXuoorTouNaTb5qWZ+nRuNv1hFwu5DfgMkYL2854QtEVp5GpM27qQD7AXNBVehtG1ndUTmhxfDY4BQ7T74=;\n\t24:gtjxshIMoAbHWN++0I9lN2fh0Se+pCjO7WnmSqjAcP16ovz6uji4l+es0AgPdKRTHtDIXMbVtKoomYspwInZ8w0o31xDJ3ze63wzidM3jwM=", "1; DB4PR04MB0765;\n\t7:4/yo8iGpi98cYjQH34CRR8oCMVBezXSpaoX3RpoC9uXKC0RBgg7hvTbCwZUxjTaoqCvt3q8m8lDKwlxWjGD7wnB2U7ENWe+Wa3JSFo6J7fpTGsethPsars7qsY9S86JWRvtcu/yEwlHNE7Jn0kPbC/aj5cUWikoNtmlTh43yMd2K0PVhdZ48g6ZJ5YQDMZuu0zQNI4Utd2AVbwb/8VeasGhaaNL2F0zPf55kdtZxEfeMZ5pEhJ/vWbtuC6nkDTVK" ], "X-MS-TrafficTypeDiagnostic": "DB4PR04MB0765:", "X-Microsoft-Antispam-PRVS": "<DB4PR04MB07651C78052F8113BC8E004789410@DB4PR04MB0765.eurprd04.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(185117386973197);", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011)(7699016);\n\tSRVR:DB4PR04MB0765; BCL:0; PCL:0; RULEID:; SRVR:DB4PR04MB0765; ", "X-Forefront-PRVS": "0723A02764", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(1496009)(396003)(39860400002)(376002)(136003)(346002)(366004)(199004)(189003)(6512007)(11346002)(476003)(386003)(6506007)(55236004)(956004)(2616005)(5660300001)(44832011)(105586002)(575784001)(68736007)(16526019)(53936002)(446003)(50226002)(316002)(6666003)(5009440100003)(36756003)(16586007)(2351001)(6916009)(106356001)(14444005)(186003)(86362001)(26005)(6486002)(97736004)(305945005)(81166006)(7736002)(8936002)(66066001)(8676002)(478600001)(25786009)(51416003)(486006)(76176011)(3846002)(6116002)(81156014)(48376002)(50466002)(52116002)(2906002)(47776003)(2361001)(110426005);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DB4PR04MB0765;\n\tH:bf-netperf1.ap.freescale.net; \n\tFPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "HGLhznvMuO71HAfeGnDdVUD3sBE60VHhzN4XGpxDM7S5fDYbQfIL9V64MoildFYSmHm1nEj/oWTieaMTx3oKMKpn48wzhAOFW2Y2Scw+1QvXbcFmwhWq9D1agLabmEyJrs47Kff2vW5NsyKMDSFJTjwiWWMXo9KUYeSy6fbg+myY2yXnt4h92K7czodqUXNBqTShaQU17H2NX5O7LvL4OB/AeDZeIAdiICMy5JCQaF5N3W5L9qrqv/72WE4TN/on1YWnJJ9VdCYsL4DMGVAydw9vQojLTzZrw4GUF6Hh2LGAbxvjQkCxR61ikUbUVAuSs9ll3Z5UJXg9VFy5IELOURQcUTpgGTJJX5EDUH+5T7M=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jul 2018 09:45:41.8165\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "94f6368f-e512-4b50-7eab-08d5e192e85d", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DB4PR04MB0765", "Subject": "[dpdk-dev] [PATCH v2 16/16] net/dpaa: implement scatter offload\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 75 +++++++++++++++++++++++++++++++++++++-----\n drivers/net/dpaa/dpaa_ethdev.h | 3 +-\n drivers/net/dpaa/dpaa_rxtx.c | 4 +--\n drivers/net/dpaa/dpaa_rxtx.h | 2 --\n 4 files changed, 70 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex 5c0aafb..c49d3a5 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -47,7 +47,8 @@\n \n /* Supported Rx offloads */\n static uint64_t dev_rx_offloads_sup =\n-\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\t\tDEV_RX_OFFLOAD_JUMBO_FRAME |\n+\t\tDEV_RX_OFFLOAD_SCATTER;\n \n /* Rx offloads which cannot be disabled */\n static uint64_t dev_rx_offloads_nodis =\n@@ -55,8 +56,7 @@ static uint64_t dev_rx_offloads_nodis =\n \t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n \t\tDEV_RX_OFFLOAD_TCP_CKSUM |\n \t\tDEV_RX_OFFLOAD_OUTER_IPV4_CKSUM |\n-\t\tDEV_RX_OFFLOAD_CRC_STRIP |\n-\t\tDEV_RX_OFFLOAD_SCATTER;\n+\t\tDEV_RX_OFFLOAD_CRC_STRIP;\n \n /* Supported Tx offloads */\n static uint64_t dev_tx_offloads_sup;\n@@ -148,11 +148,30 @@ dpaa_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n \tuint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN\n \t\t\t\t+ VLAN_TAG_SIZE;\n+\tuint32_t buffsz = dev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM;\n \n \tPMD_INIT_FUNC_TRACE();\n \n \tif (mtu < ETHER_MIN_MTU || frame_size > DPAA_MAX_RX_PKT_LEN)\n \t\treturn -EINVAL;\n+\t/*\n+\t * Refuse mtu that requires the support of scattered packets\n+\t * when this feature has not been enabled before.\n+\t */\n+\tif (dev->data->min_rx_buf_size &&\n+\t\t!dev->data->scattered_rx && frame_size > buffsz) {\n+\t\tDPAA_PMD_ERR(\"SG not enabled, will not fit in one buffer\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\t/* check <seg size> * <max_seg> >= max_frame */\n+\tif (dev->data->min_rx_buf_size && dev->data->scattered_rx &&\n+\t\t(frame_size > buffsz * DPAA_SGT_MAX_ENTRIES)) {\n+\t\tDPAA_PMD_ERR(\"Too big to fit for Max SG list %d\",\n+\t\t\t\tbuffsz * DPAA_SGT_MAX_ENTRIES);\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (frame_size > ETHER_MAX_LEN)\n \t\tdev->data->dev_conf.rxmode.offloads &=\n \t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n@@ -196,13 +215,24 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)\n \tif (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n \t\tif (dev->data->dev_conf.rxmode.max_rx_pkt_len <=\n \t\t DPAA_MAX_RX_PKT_LEN) {\n+\t\t\tDPAA_PMD_DEBUG(\"enabling jumbo\");\n \t\t\tfman_if_set_maxfrm(dpaa_intf->fif,\n \t\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len);\n-\t\t\treturn 0;\n+\t\t\tdev->data->mtu =\n+\t\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len -\n+\t\t\t\tETHER_HDR_LEN - ETHER_CRC_LEN - VLAN_TAG_SIZE;\n \t\t} else {\n-\t\t\treturn -1;\n+\t\t\tDPAA_PMD_ERR(\"enabling jumbo err conf max len=%d \"\n+\t\t\t\t\"supported is %d\",\n+\t\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len,\n+\t\t\t\tDPAA_MAX_RX_PKT_LEN);\n \t\t}\n \t}\n+\tif (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n+\t\tDPAA_PMD_DEBUG(\"enabling scatter mode\");\n+\t\tfman_if_set_sg(dpaa_intf->fif, 1);\n+\t\tdev->data->scattered_rx = 1;\n+\t}\n \treturn 0;\n }\n \n@@ -300,7 +330,6 @@ static void dpaa_eth_dev_info(struct rte_eth_dev *dev,\n \n \tdev_info->max_rx_queues = dpaa_intf->nb_rx_queues;\n \tdev_info->max_tx_queues = dpaa_intf->nb_tx_queues;\n-\tdev_info->min_rx_bufsize = DPAA_MIN_RX_BUF_SIZE;\n \tdev_info->max_rx_pktlen = DPAA_MAX_RX_PKT_LEN;\n \tdev_info->max_mac_addrs = DPAA_MAX_MAC_FILTER;\n \tdev_info->max_hash_mac_addrs = 0;\n@@ -514,6 +543,7 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tstruct qm_mcc_initfq opts = {0};\n \tu32 flags = 0;\n \tint ret;\n+\tu32 buffsz = rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -527,6 +557,27 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \tDPAA_PMD_INFO(\"Rx queue setup for queue index: %d fq_id (0x%x)\",\n \t\t\tqueue_idx, rxq->fqid);\n \n+\t/* Max packet can fit in single buffer */\n+\tif (dev->data->dev_conf.rxmode.max_rx_pkt_len <= buffsz) {\n+\t\t;\n+\t} else if (dev->data->dev_conf.rxmode.enable_scatter) {\n+\t\tif (dev->data->dev_conf.rxmode.max_rx_pkt_len >\n+\t\t\tbuffsz * DPAA_SGT_MAX_ENTRIES) {\n+\t\t\tDPAA_PMD_ERR(\"max RxPkt size %d too big to fit \"\n+\t\t\t\t\"MaxSGlist %d\",\n+\t\t\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len,\n+\t\t\t\tbuffsz * DPAA_SGT_MAX_ENTRIES);\n+\t\t\trte_errno = EOVERFLOW;\n+\t\t\treturn -rte_errno;\n+\t\t}\n+\t} else {\n+\t\tDPAA_PMD_WARN(\"The requested maximum Rx packet size (%u) is\"\n+\t\t \" larger than a single mbuf (%u) and scattered\"\n+\t\t \" mode has not been requested\",\n+\t\t dev->data->dev_conf.rxmode.max_rx_pkt_len,\n+\t\t buffsz - RTE_PKTMBUF_HEADROOM);\n+\t}\n+\n \tif (!dpaa_intf->bp_info || dpaa_intf->bp_info->mp != mp) {\n \t\tstruct fman_if_ic_params icp;\n \t\tuint32_t fd_offset;\n@@ -553,10 +604,13 @@ int dpaa_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\tfman_if_set_bp(dpaa_intf->fif, mp->size,\n \t\t\t dpaa_intf->bp_info->bpid, bp_size);\n \t\tdpaa_intf->valid = 1;\n-\t\tDPAA_PMD_INFO(\"if =%s - fd_offset = %d offset = %d\",\n-\t\t\t dpaa_intf->name, fd_offset,\n-\t\t\tfman_if_get_fdoff(dpaa_intf->fif));\n+\t\tDPAA_PMD_DEBUG(\"if:%s fd_offset = %d offset = %d\",\n+\t\t\t\tdpaa_intf->name, fd_offset,\n+\t\t\t\tfman_if_get_fdoff(dpaa_intf->fif));\n \t}\n+\tDPAA_PMD_DEBUG(\"if:%s sg_on = %d, max_frm =%d\", dpaa_intf->name,\n+\t\tfman_if_get_sg_enable(dpaa_intf->fif),\n+\t\tdev->data->dev_conf.rxmode.max_rx_pkt_len);\n \t/* checking if push mode only, no error check for now */\n \tif (dpaa_push_mode_max_queue > dpaa_push_queue_idx) {\n \t\tdpaa_push_queue_idx++;\n@@ -1304,6 +1358,9 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev)\n \tfman_if_reset_mcast_filter_table(fman_intf);\n \t/* Reset interface statistics */\n \tfman_if_stats_reset(fman_intf);\n+\t/* Disable SG by default */\n+\tfman_if_set_sg(fman_intf, 0);\n+\tfman_if_set_maxfrm(fman_intf, ETHER_MAX_LEN + VLAN_TAG_SIZE);\n \n \treturn 0;\n \ndiff --git a/drivers/net/dpaa/dpaa_ethdev.h b/drivers/net/dpaa/dpaa_ethdev.h\nindex c79b9f8..1e7a656 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.h\n+++ b/drivers/net/dpaa/dpaa_ethdev.h\n@@ -39,9 +39,10 @@\n /* Alignment to use for cpu-local structs to avoid coherency problems. */\n #define MAX_CACHELINE\t\t\t64\n \n-#define DPAA_MIN_RX_BUF_SIZE 512\n #define DPAA_MAX_RX_PKT_LEN 10240\n \n+#define DPAA_SGT_MAX_ENTRIES 16 /* maximum number of entries in SG Table */\n+\n /* RX queue tail drop threshold (CGR Based) in frame count */\n #define CGR_RX_PERFQ_THRESH 256\n \ndiff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c\nindex 168b77e..6e96a80 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.c\n+++ b/drivers/net/dpaa/dpaa_rxtx.c\n@@ -306,8 +306,6 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid)\n \tint i = 0;\n \tuint8_t fd_offset = fd->offset;\n \n-\tDPAA_DP_LOG(DEBUG, \"Received an SG frame\");\n-\n \tvaddr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd));\n \tif (!vaddr) {\n \t\tDPAA_PMD_ERR(\"unable to convert physical address\");\n@@ -349,6 +347,8 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid)\n \t\t}\n \t\tprev_seg = cur_seg;\n \t}\n+\tDPAA_DP_LOG(DEBUG, \"Received an SG frame len =%d, num_sg =%d\",\n+\t\t\tfirst_seg->pkt_len, first_seg->nb_segs);\n \n \tdpaa_eth_packet_info(first_seg, vaddr);\n \trte_pktmbuf_free_seg(temp);\ndiff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h\nindex d3e6351..6de70a7 100644\n--- a/drivers/net/dpaa/dpaa_rxtx.h\n+++ b/drivers/net/dpaa/dpaa_rxtx.h\n@@ -32,8 +32,6 @@\n /* L4 Type field: TCP */\n #define DPAA_L4_PARSE_RESULT_TCP\t0x20\n \n-#define DPAA_SGT_MAX_ENTRIES 16 /* maximum number of entries in SG Table */\n-\n #define DPAA_MAX_DEQUEUE_NUM_FRAMES 63\n \t/** <Maximum number of frames to be dequeued in a single rx call*/\n \n", "prefixes": [ "v2", "16/16" ] }