Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42285/?format=api
{ "id": 42285, "url": "http://patchwork.dpdk.org/api/patches/42285/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180704141037.44021-3-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180704141037.44021-3-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180704141037.44021-3-pablo.de.lara.guarch@intel.com", "date": "2018-07-04T14:10:36", "name": "[v3,3/4] compressdev: replace mbuf scatter gather flag", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7bdcec74a898c1c2d9eec8f4e3e17622d3269fad", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patchwork.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180704141037.44021-3-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 405, "url": "http://patchwork.dpdk.org/api/series/405/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=405", "date": "2018-07-04T14:10:35", "name": "[v3,1/4] doc: cleanup ISA-L PMD feature matrix", "version": 3, "mbox": "http://patchwork.dpdk.org/series/405/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42285/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42285/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C0A9A1BF3E;\n\tThu, 5 Jul 2018 00:16:34 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id CDE111BE98\n\tfor <dev@dpdk.org>; Thu, 5 Jul 2018 00:16:30 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Jul 2018 15:16:25 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby orsmga004.jf.intel.com with ESMTP; 04 Jul 2018 15:16:20 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,309,1526367600\"; d=\"scan'208\";a=\"213483270\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "shally.verma@caviumnetworks.com, ashish.gupta@caviumnetworks.com,\n\tfiona.trahe@intel.com, lee.daly@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Wed, 4 Jul 2018 15:10:36 +0100", "Message-Id": "<20180704141037.44021-3-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180704141037.44021-1-pablo.de.lara.guarch@intel.com>", "References": "<20180627055031.24394-1-pablo.de.lara.guarch@intel.com>\n\t<20180704141037.44021-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 3/4] compressdev: replace mbuf scatter gather\n\tflag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The current mbuf scatter gather feature flag is\ntoo ambiguous, as it is not clear if input and/or output\nbuffers can be scatter gather mbufs or not.\n\nTherefore, three new flags will replace this flag:\n- RTE_COMP_FF_OOP_SGL_IN_SGL_OUT\n- RTE_COMP_FF_OOP_SGL_IN_FB_OUT\n- RTE_COMP_FF_OOP_FB_IN_SGL_OUT\n\nNote that out-of-place flat buffers is supported by default\nand in-place is not supported by the library.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n\nChanges in v3:\n- Replaced Out-of-place with OOP\n- Added new feature flags in default.ini\n\nChanges in v2:\n- Fixed typos\n- Rephrased comments\n\n doc/guides/compressdevs/features/default.ini | 34 +++++++++++++++-------------\n doc/guides/compressdevs/overview.rst | 14 ++++++++++++\n doc/guides/rel_notes/release_18_08.rst | 6 +++++\n lib/librte_compressdev/rte_comp.c | 8 +++++--\n lib/librte_compressdev/rte_comp.h | 30 ++++++++++++++++--------\n 5 files changed, 64 insertions(+), 28 deletions(-)", "diff": "diff --git a/doc/guides/compressdevs/features/default.ini b/doc/guides/compressdevs/features/default.ini\nindex a88414d23..003f3f3a5 100644\n--- a/doc/guides/compressdevs/features/default.ini\n+++ b/doc/guides/compressdevs/features/default.ini\n@@ -6,19 +6,21 @@\n ; the features table in the documentation.\n ;\n [Features]\n-HW Accelerated =\n-CPU SSE =\n-CPU AVX =\n-CPU AVX2 =\n-CPU AVX512 =\n-CPU NEON =\n-Stateful =\n-Pass-through =\n-Chained mbufs =\n-Deflate =\n-LZS =\n-Adler32 =\n-Crc32 =\n-Adler32&Crc32 =\n-Fixed =\n-Dynamic =\n+HW Accelerated =\n+CPU SSE =\n+CPU AVX =\n+CPU AVX2 =\n+CPU AVX512 =\n+CPU NEON =\n+Stateful =\n+Pass-through =\n+OOP SGL In SGL Out =\n+OOP SGL In FB Out =\n+OOP FB In SGL Out =\n+Deflate =\n+LZS =\n+Adler32 =\n+Crc32 =\n+Adler32&Crc32 =\n+Fixed =\n+Dynamic =\ndiff --git a/doc/guides/compressdevs/overview.rst b/doc/guides/compressdevs/overview.rst\nindex b16c36fd6..68205c77d 100644\n--- a/doc/guides/compressdevs/overview.rst\n+++ b/doc/guides/compressdevs/overview.rst\n@@ -15,3 +15,17 @@ Supported Feature Flags\n \n - \"Pass-through\" feature flag refers to the ability of the PMD\n to let mbufs pass-through it, without making any modifications to it.\n+\n+ - \"OOP SGL In SGL Out\" feature flag stands for\n+ \"Out-of-place Scatter-gather list Input, Scatter-gater list Output\",\n+ which means that the input and output mbufs can consist of multiple segments.\n+\n+ - \"OOP SGL In FB Out\" feature flag stands for\n+ \"Out-of-place Scatter-gather list Input, Flat Buffers Output\",\n+ which means that the input mbuf can consist of multiple segments combined\n+ with a single segment mbuf in the output.\n+\n+ - \"OOP FB In SGL Out\" feature flag stands for\n+ \"Out-of-place Flat Buffers Input, Scatter-gather list Output\",\n+ which means that the output mbuf can consist of multiple segments combined\n+ with a single segment mbuf in the input.\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex bc0124295..4ae37cb3b 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -60,6 +60,12 @@ API Changes\n Also, make sure to start the actual text at the margin.\n =========================================================\n \n+* compressdev: Feature flag ``RTE_COMP_FF_MBUF_SCATTER_GATHER`` is\n+ replaced with the following more explicit flags:\n+ - ``RTE_COMP_FF_OOP_SGL_IN_SGL_OUT``\n+ - ``RTE_COMP_FF_OOP_SGL_IN_FB_OUT``\n+ - ``RTE_COMP_FF_OOP_FB_IN_SGL_OUT``\n+\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c\nindex d596ba872..f5bd3a6c0 100644\n--- a/lib/librte_compressdev/rte_comp.c\n+++ b/lib/librte_compressdev/rte_comp.c\n@@ -14,8 +14,12 @@ rte_comp_get_feature_name(uint64_t flag)\n \t\treturn \"STATEFUL_COMPRESSION\";\n \tcase RTE_COMP_FF_STATEFUL_DECOMPRESSION:\n \t\treturn \"STATEFUL_DECOMPRESSION\";\n-\tcase RTE_COMP_FF_MBUF_SCATTER_GATHER:\n-\t\treturn \"MBUF_SCATTER_GATHER\";\n+\tcase RTE_COMP_FF_OOP_SGL_IN_SGL_OUT:\n+\t\treturn \"OOP_SGL_IN_SGL_OUT\";\n+\tcase RTE_COMP_FF_OOP_SGL_IN_FB_OUT:\n+\t\treturn \"OOP_SGL_IN_FB_OUT\";\n+\tcase RTE_COMP_FF_OOP_FB_IN_SGL_OUT:\n+\t\treturn \"OOP_FB_IN_SGL_OUT\";\n \tcase RTE_COMP_FF_MULTI_PKT_CHECKSUM:\n \t\treturn \"MULTI_PKT_CHECKSUM\";\n \tcase RTE_COMP_FF_ADLER32_CHECKSUM:\ndiff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h\nindex 5b513c77e..6660cee82 100644\n--- a/lib/librte_compressdev/rte_comp.h\n+++ b/lib/librte_compressdev/rte_comp.h\n@@ -30,23 +30,33 @@ extern \"C\" {\n /**< Stateful compression is supported */\n #define RTE_COMP_FF_STATEFUL_DECOMPRESSION\t(1ULL << 1)\n /**< Stateful decompression is supported */\n-#define\tRTE_COMP_FF_MBUF_SCATTER_GATHER\t\t(1ULL << 2)\n-/**< Scatter-gather mbufs are supported */\n-#define RTE_COMP_FF_ADLER32_CHECKSUM\t\t(1ULL << 3)\n+#define RTE_COMP_FF_OOP_SGL_IN_SGL_OUT\t\t(1ULL << 2)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are\n+ * supported in input and output\n+ */\n+#define RTE_COMP_FF_OOP_SGL_IN_FB_OUT\t\t(1ULL << 3)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in input, combined with flat buffers (FB) in output\n+ */\n+#define RTE_COMP_FF_OOP_FB_IN_SGL_OUT\t\t(1ULL << 4)\n+/**< Out-of-place Scatter-gather (SGL) mbufs are supported\n+ * in output, combined with flat buffers (FB) in input\n+ */\n+#define RTE_COMP_FF_ADLER32_CHECKSUM\t\t(1ULL << 5)\n /**< Adler-32 Checksum is supported */\n-#define RTE_COMP_FF_CRC32_CHECKSUM\t\t(1ULL << 4)\n+#define RTE_COMP_FF_CRC32_CHECKSUM\t\t(1ULL << 6)\n /**< CRC32 Checksum is supported */\n-#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM\t(1ULL << 5)\n+#define RTE_COMP_FF_CRC32_ADLER32_CHECKSUM\t(1ULL << 7)\n /**< Adler-32/CRC32 Checksum is supported */\n-#define RTE_COMP_FF_MULTI_PKT_CHECKSUM\t\t(1ULL << 6)\n+#define RTE_COMP_FF_MULTI_PKT_CHECKSUM\t\t(1ULL << 8)\n /**< Generation of checksum across multiple stateless packets is supported */\n-#define RTE_COMP_FF_SHA1_HASH\t\t\t(1ULL << 7)\n+#define RTE_COMP_FF_SHA1_HASH\t\t\t(1ULL << 9)\n /**< SHA1 Hash is supported */\n-#define RTE_COMP_FF_SHA2_SHA256_HASH\t\t(1ULL << 8)\n+#define RTE_COMP_FF_SHA2_SHA256_HASH\t\t(1ULL << 10)\n /**< SHA256 Hash of SHA2 family is supported */\n-#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS\t(1ULL << 9)\n+#define RTE_COMP_FF_NONCOMPRESSED_BLOCKS\t(1ULL << 11)\n /**< Creation of non-compressed blocks using RTE_COMP_LEVEL_NONE is supported */\n-#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM\t(1ULL << 10)\n+#define RTE_COMP_FF_SHAREABLE_PRIV_XFORM\t(1ULL << 12)\n /**< Private xforms created by the PMD can be shared\n * across multiple stateless operations. If not set, then app needs\n * to create as many priv_xforms as it expects to have stateless\n", "prefixes": [ "v3", "3/4" ] }