Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42289/?format=api
{ "id": 42289, "url": "http://patchwork.dpdk.org/api/patches/42289/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530769547-8586-1-git-send-email-nithin.dabilpuram@caviumnetworks.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1530769547-8586-1-git-send-email-nithin.dabilpuram@caviumnetworks.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1530769547-8586-1-git-send-email-nithin.dabilpuram@caviumnetworks.com", "date": "2018-07-05T05:45:46", "name": "[v2] app/testpmd: fix buffer leak in tm cmdline", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3beff9389a2725b76ac728460e13976533e9495a", "submitter": { "id": 1070, "url": "http://patchwork.dpdk.org/api/people/1070/?format=api", "name": "Nithin Dabilpuram", "email": "nithin.dabilpuram@caviumnetworks.com" }, "delegate": { "id": 10018, "url": "http://patchwork.dpdk.org/api/users/10018/?format=api", "username": "cristian_dumitrescu", "first_name": "Cristian", "last_name": "Dumitrescu", "email": "cristian.dumitrescu@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530769547-8586-1-git-send-email-nithin.dabilpuram@caviumnetworks.com/mbox/", "series": [ { "id": 408, "url": "http://patchwork.dpdk.org/api/series/408/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=408", "date": "2018-07-05T05:45:46", "name": "[v2] app/testpmd: fix buffer leak in tm cmdline", "version": 2, "mbox": "http://patchwork.dpdk.org/series/408/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42289/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 85ABA1BE5C;\n\tThu, 5 Jul 2018 07:46:25 +0200 (CEST)", "from NAM02-BL2-obe.outbound.protection.outlook.com\n\t(mail-bl2nam02on0088.outbound.protection.outlook.com [104.47.38.88])\n\tby dpdk.org (Postfix) with ESMTP id 184B01BE56\n\tfor <dev@dpdk.org>; Thu, 5 Jul 2018 07:46:24 +0200 (CEST)", "from hyd1351t110.caveonetworks.com.com (115.113.156.2) by\n\tMWHPR07MB3182.namprd07.prod.outlook.com (2603:10b6:300:e1::12) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.906.25; Thu, 5 Jul 2018 05:46:19 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=wH+srUT5KEUWyOezYLA1sIKdUmEFwP/vd1+zTsQoIX8=;\n\tb=XvyW6qoqK3ZssHxtEF3dAVtWdR6W0zDkJ9dmHmVJIeHXgJ2OSaNX3mItPaBWjm7drS4Qui0BKnuH+K+KU7WAX+RNzDgWC1UW5hotEC5Ba5+k5w9V03JS2c70aijIrVWX1a54QSXejwzua2J9yFjhG6vlTt7lLnjCCK6jRbV3F2M=", "Authentication-Results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Nithin.Dabilpuram@cavium.com; ", "From": "Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>", "To": "Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, \n\tBernard Iremonger <bernard.iremonger@intel.com>", "Cc": "dev@dpdk.org, kkanas@caviumnetworks.com,\n\tNithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>", "Date": "Thu, 5 Jul 2018 11:15:46 +0530", "Message-Id": "<1530769547-8586-1-git-send-email-nithin.dabilpuram@caviumnetworks.com>", "X-Mailer": "git-send-email 1.8.3.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[115.113.156.2]", "X-ClientProxiedBy": "BMXPR01CA0030.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:c::16) To MWHPR07MB3182.namprd07.prod.outlook.com\n\t(2603:10b6:300:e1::12)", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "97484c03-a1a6-4c13-62d4-08d5e23aa302", "X-Microsoft-Antispam": "UriScan:; BCL:0; PCL:0;\n\tRULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);\n\tSRVR:MWHPR07MB3182; ", "X-Microsoft-Exchange-Diagnostics": [ "1; MWHPR07MB3182;\n\t3:jRpwmYVf7Mk02Sr8LCgcWSNTgZME8bqpGxThwXO6VYo0tyshnNnuuey1Tf3a7fMdhGpXi8ZuwFHEcQuHcKGCfdVDV2YH8nO2EivAKdvc+EsxnYl/47RbLu8AZK2aFt1jksbZugqZSD7K2HulWrC+rrCLSV5+eFQSdWGvWPLtdc+848qEhVdIxwvywu2D73aKSRpUDnj8ukZZ4Xme8fB9CVq3YErlJjHSquv+45X70TsW+4v3oopYG2KpPzOZrbal;\n\t25:JLKgUmmq490AdEZiH6AXoYoOqyECoIrC00N/7mMQRLClDygAAC74UZDihq2gIwHc55NcxA/BLq8+9pDC85346VpnJs7DRqjJKlihB4plV2Gy9nuxeIwKH3pi0IUEDQPHaN14IitPaS27ZjimMkMtF/mNgh8YTBJtzuuXDIEx5GzCfXNK8nYyEx7IQJiOdSz9vS1fUmn7OyC+bf1CLs49EMSZR7J7Rkyqr9GxKLxdWSi+AbYCsy0LeRuCsUc/2ZJCKi4cwOK/AJMWBVV13CpejU+FTEOIpAt8NPChRBllOn34nyyEtLk7HOyQa3WbvXwnx5jIoREwEx+badpevLpybw==;\n\t31:fDtLW6unNRmRfcY0eXyxMLnAZCBHShkmWjg3xYe+xhlGAE56qCJnQqYc2dGrVKg3N7r4G5ahg72OPbjRpF73uMzRFzmz8aHZzlI/RAneTeqBvfuTTqzt8uxO5sV5V82A9jzCgGKNpHjhtllb4NPVwR6MyK3xXnUB+Czub0IlawtH53jxejR6czwJHXEFNPLIih7N498LM86lvp9JNSGf6Z4P0tACwvmSJhFxjRhJCGk=", "1; MWHPR07MB3182;\n\t20:8AKJ2+WXF0gDlra5s6mlF6Lzpc0RIVPYV2tdfNinKpUrZYZEshhZC3meOSM9L/3ZmaW8az4J/2FhBNsK89dh+sRYI8oCuXhuAvqJyZgRyeRhGcssSptUEgMNM4xDbRV0c2y79XjjKVsVdYKOpEzKqmm8duycPwhP/nZUEonZDH4VLQQS1vJYGjjky3RSstWV44M2YUJq0SA0PRHpqX+YNabSocaEzal68/lmK9Ys2pJi/YHnwZWxJc9jXgohg3R2LaSrKPa8JRTWCu3CeUw+4XTEAuNuLevPB/yhE0PgcBpAycEHGgulCuxfW1PExweJbhfNCnT1iCeFYUChUjBKGPHuixVZSABP4OpyCVahGHpFo0eYgYtbE3fZXgOi35AGmdOm8Wc/3xvGeBZdr9YcGD8f8xfMNXadzuRqZ1LtdMZ2D0QEQF1KM0waYq5zK4ktUoqEC89+NVD8UFwzlOIu50QRn+1cblUcb7mfxNetnmH2gxvNnJqu5yEdD6vIDDs7Md6wNFL00PIL97iBEzUZXjpbLdgeCbQNxpCIrPOLGw/In4cugHZZ6d4hv7shcxyCfn2ybnnq1PZJ4O5FO7EYZTkxExWeoFrUh+rjIAGVWgs=;\n\t4:qn/IFJTgBIkYdv+qFIuRbN+fbdlWGKM4o2S8/iGR0DBTdV3gzuEj48Kz+aslNeSnrLZZi+WC1dPSKMp33ZviYP3wJtKHStsphDBTQ5ZKuOoIsw//hl+kbfe1TPyjT2vpSVqVGULVGmfv+Wgnb6UscfzAgS4FjHT4ItsAhd5/NDBzNS7igoZbxtN1NgxysN7gBEu+ditSwkU3/Tw0CREVkzoAQn4UAmjXOIIkeYJNskTPzPBGMGd+7ixdlZ5zhpSFjmLv21GBCy4z2nTHRjHe96+MOmnu6jSMdUSHGzWe8asyBEto4hOKzJB7Eu8OQrpz", "=?us-ascii?Q?1; MWHPR07MB3182;\n\t23:oOcrWwcEcPPP65JkjEaBjHTcPbKg0lfSr0ERL8bkD?=\n\tw2Jj7gj6sFaPuSE2BgMsa1OrfbGLjFRk4QhwrbViOuI3NVuKAwhAYGeBusptl+mExEL6DH2QaH7sTvRqhd9SyR+aWLemk8IiTgSPG0zDdV3Y3lKa1H8SqakN2ORoZVCWhJGxnmxi7hjbrnBm4t25B6PqEO36mUNhv8r7NdPEuqKywIP9ijsQo5C0yVpHi1tIqxMtWSvm6AO09q/RbSfdMeU7LFZvrOFvnetlBR7swZ8EdRpkcILLrXAksB/W0vcIxlGTz786FWvfIfdYtxEgqgQytcsABp4GT6g6BKfksClPxjeGHhQeAK8xXh10bPk69HpVqNXW55CZpE9GP29dnUmCqE/RsS1R6zzuwT19rJvlkCh4L9rlGZmV0Bg6LZ5SpE3qgjfpilEcuMQNBhm8SkvlHyvToFwqAwMsGcTYkT5PJwp8mRc8HJLYXLW2J1iEU5nteV5O7dNJDG7bDE5kUw8yhxMpzPy403zBtucSI9nrHWPSRWWoXeBhdGCa05V4r1ZqJdcvY3Ho6D5PiItx6/FSdOgemGZjRnktjS7wv3DHbrJnUpYyzZ8jbJR2iqBfiIH9XGvG+ZAt3KfsTl0f0omdjU8NAYQigKvl6yf/noBQOiH6U6PgQNvdmq8B/UYeQp0lWxuKb6pU8Aef03dRRdN7J9QEOJvDSP+Rqcf/BzRSX7Cb3JWlBncMRAlaiwv3GOj6cwA7HgErtEGYVvRCwEOcM4tpyh0pYmD7xTblXfGVCQdiTFXGzX9ZIpjCRJvr3OdqkVLFB2W1kksreWuVMP0ii8aPGm4ZwLQSF/wJiEh2Da+/ae0nfCVa+ui1TufW1JU8WQyHmfv2CrmOqnpGgwrtAK2bW1quGJgniSnzG4d431Guig3WD9xteeA2UNf4QkMqi27vAKHYUfOoaYBBVZl9H8r25ICXr/fPiFdnSFXWvdhUov3nxxnhcXknztI9d0oDn3PWynQStQ9k9NQ5PHNICijgSzx+dLYzS4EZwbk42lYFiUSLkMikd4o9JcMMmkfR/+Jes5rMPwnEUbVR7NMnpkV4512d6QqFQI7N5Tn1DD36PWJ1F/ofXXHLCZSdIXBFv63Afo76S1gmJ7Clgmd+c4iqqa+8k77jZlK++YtWYOQTxbm1dgBOj7IVct7ckFwGRrH3zzI7A6ICmUP5Lq4AtZDwI4GYE2XbstyP81niQ==", "1; MWHPR07MB3182;\n\t6:lBGgRa/hY8tsn9Ll0vlEsKuJV2dujzshwoppPrFlS1JUBb9SulZOLCAdrqr7Oo6Pdh5M+lJ7k8K4OSjMw9hTJMQVR4EmV9IvSod1JjoV+RZGA/aPwlbckGW924WhwdToKzDz16QOv6D7T1gEnJLLZSnu2CDqQ4kdcNMoZJEFarOnndwe9Ki+3nDSe21IpDBCv0u5CNiO6i4IY6qYfdhPlwzufdK3MWwuZU8m7qEQisefNYmmz6Sd72U7wp12hrwrNhAFWpuabW78yKRVBe49xeiYOg7/mEGImYjMhqb9UZLzX3croighc/5Roiy/NC6TPMCsitO2GGSEUhYxHuRWICeHY0F4RfpOD1I7gHvroB2AEwoD+vUFLgZ6682Jks2C1KiTpf3jUoyAiNNVhDs2OoWrvEIYFAxkuvFOqSbfGQQlo1we7Z5AyWpE8fdwSDlT6fcSTno958+Wo13nBM6pRw==;\n\t5:wsJmcLKWOSRQ22/GCC02cxwDsIx9jlmk2uRGwBzyWZdQGUUFsbJMCF8oujCRVB6PwpH4gWHlbH0FFIwYy2msyaToYvEwxjvY+4AgPfZ3lmPhmmKoSs2i/iKXsvTW6iHwjjbOX9b1jhVnV3pzNMEtigspsX5quS2pOPW1WJRINRg=;\n\t24:9bMmBd+puOLTeyjwj5X1DHjK4cUXXSsMNyMTLMNgF4haac5gqcc4kmbpdnyhZaXHX3EwCldO0KZVz1AiZG2v0z8goGDiMr1DS2HsFst+P7g=", "1; MWHPR07MB3182;\n\t7:/biosDPpbeVw5CLUbNzcu1FU9XYTNokFFk7QgRtVmoC6DxRgzsspKrZSZV25vQgFG2ArWdN8kB5i8hAHLu9M0b+NQ+hpaglizfQF9AhSxjIKsmzmavDOxR9aCNIW0m5PsYZ1/NO3OOlIGGWwpDecA38VPpzyUFhGo6RJ9XRwNpag//b/Atg5a1Q5IJCrFoSCmaNbGVwrxa73yFhnbe/PuSbfJT1I4Iid+JwxMkNAy7ym3n0J1yJQA2x+H/DWxdqP" ], "X-MS-TrafficTypeDiagnostic": "MWHPR07MB3182:", "X-Microsoft-Antispam-PRVS": "<MWHPR07MB31822337A76D3C322D71B61A9B400@MWHPR07MB3182.namprd07.prod.outlook.com>", "X-Exchange-Antispam-Report-Test": "UriScan:(228905959029699);", "X-MS-Exchange-SenderADCheck": "1", "X-Exchange-Antispam-Report-CFA-Test": "BCL:0; PCL:0;\n\tRULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(3231254)(944501410)(52105095)(10201501046)(3002001)(149027)(150027)(6041310)(20161123560045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016);\n\tSRVR:MWHPR07MB3182; BCL:0; PCL:0; RULEID:; SRVR:MWHPR07MB3182; ", "X-Forefront-PRVS": "0724FCD4CD", "X-Forefront-Antispam-Report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(346002)(136003)(376002)(39860400002)(396003)(199004)(189003)(52116002)(8676002)(386003)(110136005)(66066001)(25786009)(47776003)(6506007)(50466002)(2906002)(106356001)(105586002)(44832011)(51416003)(50226002)(6512007)(68736007)(478600001)(48376002)(97736004)(72206003)(81166006)(16586007)(316002)(81156014)(6486002)(4326008)(4720700003)(2616005)(6666003)(42882007)(305945005)(956004)(8936002)(55236004)(107886003)(7736002)(476003)(486006)(3846002)(53936002)(5660300001)(16526019)(186003)(6116002)(26005)(36756003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR07MB3182;\n\tH:hyd1351t110.caveonetworks.com.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "Received-SPF": "None (protection.outlook.com: cavium.com does not designate\n\tpermitted sender hosts)", "X-Microsoft-Antispam-Message-Info": "2yXuqFbQHsFPx+Q1vvsV3X6sIGueIPN4Hvr1nflPYgJRI0GZCkiWRYaFgqxyEIKSpMTAAMrNnXr7b06mh5QLocCZkgPM9qAIWjPI1Zw9N+zkulv6Oa0bWgQrrCdMp5O4w3uf02A3KfXo+a5BdI/WPIvJpZMq6QN9S9Ny39BKwgQCOADWqyxFL7Mrp4CYArCAgM1St0VfUtmeJmSMir7hJ4UbPluWMKkh325knpO3pQAGPAa5obW+dPuX99S48abhQVLO/nkoc83nNE7sHd2euzvDRPMnYl7ktdcd2QQ/47+XFAyJkJVAmAomB2CMweXgl2OuhFAEiPtjELNNbOLvJkkZpfnVIdd0/NZMB+9aB3g=", "SpamDiagnosticOutput": "1:99", "SpamDiagnosticMetadata": "NSPM", "X-OriginatorOrg": "caviumnetworks.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 Jul 2018 05:46:19.4189\n\t(UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "97484c03-a1a6-4c13-62d4-08d5e23aa302", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "711e4ccf-2e9b-4bcf-a551-4094005b6194", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MWHPR07MB3182", "Subject": "[dpdk-dev] [PATCH v2] app/testpmd: fix buffer leak in tm cmdline", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Free the buffer allocated for shared_shaper_id array in\ncase of configuration without shared shapers.\n\nSigned-off-by: Nithin Dabilpuram <nithin.dabilpuram@caviumnetworks.com>\nAcked-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\nv2 changes:\n- Modify subject to use proper keyword for test-pmd\n- Change author email address\n\n app/test-pmd/cmdline_tm.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c\nindex c904e44..7c1601f 100644\n--- a/app/test-pmd/cmdline_tm.c\n+++ b/app/test-pmd/cmdline_tm.c\n@@ -1599,10 +1599,12 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result,\n \t\tnp.shaper_profile_id = res->shaper_profile_id;\n \n \tnp.n_shared_shapers = n_shared_shapers;\n-\tif (np.n_shared_shapers)\n+\tif (np.n_shared_shapers) {\n \t\tnp.shared_shaper_id = &shared_shaper_id[0];\n-\telse\n-\t\tnp.shared_shaper_id = NULL;\n+\t} else {\n+\t\tfree(shared_shaper_id);\n+\t\tshared_shaper_id = NULL;\n+\t}\n \n \tnp.nonleaf.n_sp_priorities = res->n_sp_priorities;\n \tnp.stats_mask = res->stats_mask;\n@@ -1758,10 +1760,12 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result,\n \n \tnp.n_shared_shapers = n_shared_shapers;\n \n-\tif (np.n_shared_shapers)\n+\tif (np.n_shared_shapers) {\n \t\tnp.shared_shaper_id = &shared_shaper_id[0];\n-\telse\n-\t\tnp.shared_shaper_id = NULL;\n+\t} else {\n+\t\tfree(shared_shaper_id);\n+\t\tshared_shaper_id = NULL;\n+\t}\n \n \tnp.leaf.cman = res->cman_mode;\n \tnp.leaf.wred.wred_profile_id = res->wred_profile_id;\n", "prefixes": [ "v2" ] }