Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42291,
    "url": "http://patchwork.dpdk.org/api/patches/42291/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1530774188-2369-1-git-send-email-beilei.xing@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1530774188-2369-1-git-send-email-beilei.xing@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1530774188-2369-1-git-send-email-beilei.xing@intel.com",
    "date": "2018-07-05T07:03:08",
    "name": "net/i40e: fix fail to set TPID with AQ command",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "5ba337aa49e8d1431874a3a16e65dd9dc17ef00f",
    "submitter": {
        "id": 410,
        "url": "http://patchwork.dpdk.org/api/people/410/?format=api",
        "name": "Xing, Beilei",
        "email": "beilei.xing@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1530774188-2369-1-git-send-email-beilei.xing@intel.com/mbox/",
    "series": [
        {
            "id": 410,
            "url": "http://patchwork.dpdk.org/api/series/410/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=410",
            "date": "2018-07-05T07:03:08",
            "name": "net/i40e: fix fail to set TPID with AQ command",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/410/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/42291/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/42291/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F4531BE09;\n\tThu,  5 Jul 2018 09:02:41 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 15B511BDEE;\n\tThu,  5 Jul 2018 09:02:39 +0200 (CEST)",
            "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jul 2018 00:02:38 -0700",
            "from unknown (HELO dpdk9.sh.intel.com) ([10.67.118.52])\n\tby FMSMGA003.fm.intel.com with ESMTP; 05 Jul 2018 00:02:37 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,311,1526367600\"; d=\"scan'208\";a=\"62404469\"",
        "From": "Beilei Xing <beilei.xing@intel.com>",
        "To": "qi.z.zhang@intel.com",
        "Cc": "dev@dpdk.org, jingjing.wu@intel.com, james.zheng@intel.com,\n\tstable@dpdk.org",
        "Date": "Thu,  5 Jul 2018 15:03:08 +0800",
        "Message-Id": "<1530774188-2369-1-git-send-email-beilei.xing@intel.com>",
        "X-Mailer": "git-send-email 2.5.5",
        "Subject": "[dpdk-dev] [PATCH] net/i40e: fix fail to set TPID with AQ command",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "TPID can be set by set_switch_config AdminQ command on\nnew FW release. But find fail to set 0x88A8 on some NICs.\nAccording to the datasheet, Switch Tag value should not\nbe identical to either the First Tag or Second Tag values.\nSo set something other than common Ethertype for internal\nswitching.\n\nFixes: 73cd7d6dc8e1 (\"net/i40e: use set switch AQ instead of register setting\")\nCc: stable@dpdk.org\n\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 7 +++++++\n 1 file changed, 7 insertions(+)",
    "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex c47b9f5..93b8d6e 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -1242,6 +1242,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused)\n \thw->bus.func = pci_dev->addr.function;\n \thw->adapter_stopped = 0;\n \n+\t/*\n+\t * Switch Tag value should not be identical to either the First Tag\n+\t * or Second Tag values. So set something other than common Ethertype\n+\t * for internal switching.\n+\t */\n+\thw->switch_tag = 0xffff;\n+\n \t/* Check if need to support multi-driver */\n \ti40e_support_multi_driver(dev);\n \n",
    "prefixes": []
}