Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42386,
    "url": "http://patchwork.dpdk.org/api/patches/42386/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180705154754.147420-22-jasvinder.singh@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180705154754.147420-22-jasvinder.singh@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180705154754.147420-22-jasvinder.singh@intel.com",
    "date": "2018-07-05T15:47:52",
    "name": "[v4,21/23] net/softnic: start and stop function",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "da0f52441eff850a9b436466bf2c03c0adcd43c9",
    "submitter": {
        "id": 285,
        "url": "http://patchwork.dpdk.org/api/people/285/?format=api",
        "name": "Jasvinder Singh",
        "email": "jasvinder.singh@intel.com"
    },
    "delegate": {
        "id": 10018,
        "url": "http://patchwork.dpdk.org/api/users/10018/?format=api",
        "username": "cristian_dumitrescu",
        "first_name": "Cristian",
        "last_name": "Dumitrescu",
        "email": "cristian.dumitrescu@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180705154754.147420-22-jasvinder.singh@intel.com/mbox/",
    "series": [
        {
            "id": 421,
            "url": "http://patchwork.dpdk.org/api/series/421/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=421",
            "date": "2018-07-05T15:47:32",
            "name": "[v4,01/23] net/softnic: restructuring",
            "version": 4,
            "mbox": "http://patchwork.dpdk.org/series/421/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/42386/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/42386/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 833241BFCC;\n\tThu,  5 Jul 2018 17:48:51 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 8FB551BEAD\n\tfor <dev@dpdk.org>; Thu,  5 Jul 2018 17:48:23 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Jul 2018 08:48:23 -0700",
            "from silpixa00381635.ir.intel.com (HELO\n\tsilpixa00381635.ger.corp.intel.com) ([10.237.222.149])\n\tby orsmga003.jf.intel.com with ESMTP; 05 Jul 2018 08:48:22 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,312,1526367600\"; d=\"scan'208\";a=\"64674509\"",
        "From": "Jasvinder Singh <jasvinder.singh@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "cristian.dumitrescu@intel.com",
        "Date": "Thu,  5 Jul 2018 16:47:52 +0100",
        "Message-Id": "<20180705154754.147420-22-jasvinder.singh@intel.com>",
        "X-Mailer": "git-send-email 2.9.3",
        "In-Reply-To": "<20180705154754.147420-1-jasvinder.singh@intel.com>",
        "References": "<20180627163123.135686-2-jasvinder.singh@intel.com>\n\t<20180705154754.147420-1-jasvinder.singh@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v4 21/23] net/softnic: start and stop function",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Implements softnic start and stop function.\n\nSigned-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>\nSigned-off-by: Jasvinder Singh <jasvinder.singh@intel.com>\n---\n drivers/net/softnic/rte_eth_softnic.c           | 49 ++++++++++++++++++++-----\n drivers/net/softnic/rte_eth_softnic_internals.h |  6 +++\n drivers/net/softnic/rte_eth_softnic_pipeline.c  | 12 ++++++\n drivers/net/softnic/rte_eth_softnic_swq.c       | 16 ++++++++\n 4 files changed, 73 insertions(+), 10 deletions(-)",
    "diff": "diff --git a/drivers/net/softnic/rte_eth_softnic.c b/drivers/net/softnic/rte_eth_softnic.c\nindex db84bd4..933f08d 100644\n--- a/drivers/net/softnic/rte_eth_softnic.c\n+++ b/drivers/net/softnic/rte_eth_softnic.c\n@@ -152,6 +152,26 @@ pmd_tx_queue_setup(struct rte_eth_dev *dev,\n static int\n pmd_dev_start(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\tint status;\n+\n+\t/* TM */\n+\tif (tm_used(dev)) {\n+\t\tstatus = tm_start(p);\n+\n+\t\tif (status)\n+\t\t\treturn status;\n+\t}\n+\n+\t/* Firmware */\n+\tstatus = softnic_cli_script_process(p,\n+\t\tp->params.firmware,\n+\t\tconn_params_default.msg_in_len_max,\n+\t\tconn_params_default.msg_out_len_max);\n+\tif (status)\n+\t\treturn status;\n+\n+\t/* Link UP */\n \tdev->data->dev_link.link_status = ETH_LINK_UP;\n \n \treturn 0;\n@@ -160,21 +180,30 @@ pmd_dev_start(struct rte_eth_dev *dev)\n static void\n pmd_dev_stop(struct rte_eth_dev *dev)\n {\n+\tstruct pmd_internals *p = dev->data->dev_private;\n+\n+\t/* Link DOWN */\n \tdev->data->dev_link.link_status = ETH_LINK_DOWN;\n+\n+\t/* Firmware */\n+\tsoftnic_pipeline_disable_all(p);\n+\tsoftnic_pipeline_free(p);\n+\tsoftnic_table_action_profile_free(p);\n+\tsoftnic_port_in_action_profile_free(p);\n+\tsoftnic_tap_free(p);\n+\tsoftnic_tmgr_free(p);\n+\tsoftnic_link_free(p);\n+\tsoftnic_softnic_swq_free_keep_rxq_txq(p);\n+\tsoftnic_mempool_free(p);\n+\n+\t/* TM */\n+\ttm_stop(p);\n }\n \n static void\n-pmd_dev_close(struct rte_eth_dev *dev)\n+pmd_dev_close(struct rte_eth_dev *dev __rte_unused)\n {\n-\tuint32_t i;\n-\n-\t/* RX queues */\n-\tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n-\t\trte_ring_free((struct rte_ring *)dev->data->rx_queues[i]);\n-\n-\t/* TX queues */\n-\tfor (i = 0; i < dev->data->nb_tx_queues; i++)\n-\t\trte_ring_free((struct rte_ring *)dev->data->tx_queues[i]);\n+\treturn;\n }\n \n static int\ndiff --git a/drivers/net/softnic/rte_eth_softnic_internals.h b/drivers/net/softnic/rte_eth_softnic_internals.h\nindex a7bf1df..aaccae8 100644\n--- a/drivers/net/softnic/rte_eth_softnic_internals.h\n+++ b/drivers/net/softnic/rte_eth_softnic_internals.h\n@@ -530,6 +530,9 @@ softnic_swq_init(struct pmd_internals *p);\n void\n softnic_swq_free(struct pmd_internals *p);\n \n+void\n+softnic_softnic_swq_free_keep_rxq_txq(struct pmd_internals *p);\n+\n struct softnic_swq *\n softnic_swq_find(struct pmd_internals *p,\n \tconst char *name);\n@@ -659,6 +662,9 @@ softnic_pipeline_init(struct pmd_internals *p);\n void\n softnic_pipeline_free(struct pmd_internals *p);\n \n+void\n+softnic_pipeline_disable_all(struct pmd_internals *p);\n+\n struct pipeline *\n softnic_pipeline_find(struct pmd_internals *p, const char *name);\n \ndiff --git a/drivers/net/softnic/rte_eth_softnic_pipeline.c b/drivers/net/softnic/rte_eth_softnic_pipeline.c\nindex 63d4bd7..45136a4 100644\n--- a/drivers/net/softnic/rte_eth_softnic_pipeline.c\n+++ b/drivers/net/softnic/rte_eth_softnic_pipeline.c\n@@ -61,6 +61,18 @@ softnic_pipeline_free(struct pmd_internals *p)\n \t}\n }\n \n+void\n+softnic_pipeline_disable_all(struct pmd_internals *p)\n+{\n+\tstruct pipeline *pipeline;\n+\n+\tTAILQ_FOREACH(pipeline, &p->pipeline_list, node)\n+\t\tif (pipeline->enabled)\n+\t\t\tsoftnic_thread_pipeline_disable(p,\n+\t\t\t\tpipeline->thread_id,\n+\t\t\t\tpipeline->name);\n+}\n+\n struct pipeline *\n softnic_pipeline_find(struct pmd_internals *p,\n \tconst char *name)\ndiff --git a/drivers/net/softnic/rte_eth_softnic_swq.c b/drivers/net/softnic/rte_eth_softnic_swq.c\nindex c46cad9..1944fbb 100644\n--- a/drivers/net/softnic/rte_eth_softnic_swq.c\n+++ b/drivers/net/softnic/rte_eth_softnic_swq.c\n@@ -33,6 +33,22 @@ softnic_swq_free(struct pmd_internals *p)\n \t}\n }\n \n+void\n+softnic_softnic_swq_free_keep_rxq_txq(struct pmd_internals *p)\n+{\n+\tstruct softnic_swq *swq;\n+\n+\tTAILQ_FOREACH(swq, &p->swq_list, node) {\n+\t\tif ((strncmp(swq->name, \"RXQ\", strlen(\"RXQ\")) == 0) ||\n+\t\t\t(strncmp(swq->name, \"TXQ\", strlen(\"TXQ\")) == 0))\n+\t\t\tcontinue;\n+\n+\t\tTAILQ_REMOVE(&p->swq_list, swq, node);\n+\t\trte_ring_free(swq->r);\n+\t\tfree(swq);\n+\t}\n+}\n+\n struct softnic_swq *\n softnic_swq_find(struct pmd_internals *p,\n \tconst char *name)\n",
    "prefixes": [
        "v4",
        "21/23"
    ]
}