Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42496/?format=api
{ "id": 42496, "url": "http://patchwork.dpdk.org/api/patches/42496/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180706025430.21342-4-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180706025430.21342-4-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180706025430.21342-4-pablo.de.lara.guarch@intel.com", "date": "2018-07-06T02:54:30", "name": "[v4,4/4] compressdev: add huffman encoding flags", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9b1940cf3fd368e11fd9f27e18c2b944d8a7a5a2", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 22, "url": "http://patchwork.dpdk.org/api/users/22/?format=api", "username": "pdelarag", "first_name": "Pablo", "last_name": "de Lara Guarch", "email": "pablo.de.lara.guarch@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180706025430.21342-4-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 452, "url": "http://patchwork.dpdk.org/api/series/452/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=452", "date": "2018-07-06T02:54:27", "name": "[v4,1/4] doc: cleanup ISA-L PMD feature matrix", "version": 4, "mbox": "http://patchwork.dpdk.org/series/452/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42496/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42496/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9F47C1BECF;\n\tFri, 6 Jul 2018 13:00:38 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id D10C31BB7F\n\tfor <dev@dpdk.org>; Fri, 6 Jul 2018 13:00:33 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Jul 2018 04:00:32 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby fmsmga002.fm.intel.com with ESMTP; 06 Jul 2018 04:00:11 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,315,1526367600\"; d=\"scan'208\";a=\"64690059\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "shally.verma@caviumnetworks.com, ashish.gupta@caviumnetworks.com,\n\tfiona.trahe@intel.com, lee.daly@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Fri, 6 Jul 2018 03:54:30 +0100", "Message-Id": "<20180706025430.21342-4-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.14.4", "In-Reply-To": "<20180706025430.21342-1-pablo.de.lara.guarch@intel.com>", "References": "<20180627055031.24394-1-pablo.de.lara.guarch@intel.com>\n\t<20180706025430.21342-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH v4 4/4] compressdev: add huffman encoding flags", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added Huffman fixed and dynamic encoding feature flags,\nso an application can query if a device supports\nthese two types, when performing DEFLATE compression.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\nAcked-by: Fiona Trahe <fiona.trahe@intel.com>\n---\n\nv4/v3:\n- No change\n\nv2:\n- Fixed typo\n\n drivers/compress/isal/isal_compress_pmd_ops.c | 4 +++-\n lib/librte_compressdev/rte_comp.c | 4 ++++\n lib/librte_compressdev/rte_comp.h | 4 ++++\n test/test/test_compressdev.c | 16 ++++++++++++++++\n 4 files changed, 27 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/compress/isal/isal_compress_pmd_ops.c b/drivers/compress/isal/isal_compress_pmd_ops.c\nindex 970a0413b..585f22802 100644\n--- a/drivers/compress/isal/isal_compress_pmd_ops.c\n+++ b/drivers/compress/isal/isal_compress_pmd_ops.c\n@@ -12,7 +12,9 @@\n static const struct rte_compressdev_capabilities isal_pmd_capabilities[] = {\n \t{\n \t\t.algo = RTE_COMP_ALGO_DEFLATE,\n-\t\t.comp_feature_flags =\tRTE_COMP_FF_SHAREABLE_PRIV_XFORM,\n+\t\t.comp_feature_flags =\tRTE_COMP_FF_SHAREABLE_PRIV_XFORM |\n+\t\t\t\t\tRTE_COMP_FF_HUFFMAN_FIXED |\n+\t\t\t\t\tRTE_COMP_FF_HUFFMAN_DYNAMIC,\n \t\t.window_size = {\n \t\t\t.min = 15,\n \t\t\t.max = 15,\ndiff --git a/lib/librte_compressdev/rte_comp.c b/lib/librte_compressdev/rte_comp.c\nindex 97ea0d922..98ad0cfd9 100644\n--- a/lib/librte_compressdev/rte_comp.c\n+++ b/lib/librte_compressdev/rte_comp.c\n@@ -36,6 +36,10 @@ rte_comp_get_feature_name(uint64_t flag)\n \t\treturn \"SHA2_SHA256_HASH\";\n \tcase RTE_COMP_FF_SHAREABLE_PRIV_XFORM:\n \t\treturn \"SHAREABLE_PRIV_XFORM\";\n+\tcase RTE_COMP_FF_HUFFMAN_FIXED:\n+\t\treturn \"HUFFMAN_FIXED\";\n+\tcase RTE_COMP_FF_HUFFMAN_DYNAMIC:\n+\t\treturn \"HUFFMAN_DYNAMIC\";\n \tdefault:\n \t\treturn NULL;\n \t}\ndiff --git a/lib/librte_compressdev/rte_comp.h b/lib/librte_compressdev/rte_comp.h\nindex 274b5eadf..1f66945ee 100644\n--- a/lib/librte_compressdev/rte_comp.h\n+++ b/lib/librte_compressdev/rte_comp.h\n@@ -63,6 +63,10 @@ extern \"C\" {\n * to create as many priv_xforms as it expects to have stateless\n * operations in-flight.\n */\n+#define RTE_COMP_FF_HUFFMAN_FIXED\t\t(1ULL << 13)\n+/**< Fixed huffman encoding is supported */\n+#define RTE_COMP_FF_HUFFMAN_DYNAMIC\t\t(1ULL << 14)\n+/**< Dynamic huffman encoding is supported */\n \n /** Status of comp operation */\n enum rte_comp_op_status {\ndiff --git a/test/test/test_compressdev.c b/test/test/test_compressdev.c\nindex 640942bac..f960963a4 100644\n--- a/test/test/test_compressdev.c\n+++ b/test/test/test_compressdev.c\n@@ -846,6 +846,14 @@ test_compressdev_deflate_stateless_fixed(void)\n \tconst char *test_buffer;\n \tuint16_t i;\n \tint ret;\n+\tconst struct rte_compressdev_capabilities *capab;\n+\n+\tcapab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);\n+\tTEST_ASSERT(capab != NULL, \"Failed to retrieve device capabilities\");\n+\n+\tif ((capab->comp_feature_flags & RTE_COMP_FF_HUFFMAN_FIXED) == 0)\n+\t\treturn -ENOTSUP;\n+\n \tstruct rte_comp_xform *compress_xform =\n \t\t\trte_malloc(NULL, sizeof(struct rte_comp_xform), 0);\n \n@@ -905,6 +913,14 @@ test_compressdev_deflate_stateless_dynamic(void)\n \tstruct rte_comp_xform *compress_xform =\n \t\t\trte_malloc(NULL, sizeof(struct rte_comp_xform), 0);\n \n+\tconst struct rte_compressdev_capabilities *capab;\n+\n+\tcapab = rte_compressdev_capability_get(0, RTE_COMP_ALGO_DEFLATE);\n+\tTEST_ASSERT(capab != NULL, \"Failed to retrieve device capabilities\");\n+\n+\tif ((capab->comp_feature_flags & RTE_COMP_FF_HUFFMAN_DYNAMIC) == 0)\n+\t\treturn -ENOTSUP;\n+\n \tif (compress_xform == NULL) {\n \t\tRTE_LOG(ERR, USER1,\n \t\t\t\"Compress xform could not be created\\n\");\n", "prefixes": [ "v4", "4/4" ] }