Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42505/?format=api
{ "id": 42505, "url": "http://patchwork.dpdk.org/api/patches/42505/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/9782368c814417e812260de99a5c4f83055d959d.1530881548.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9782368c814417e812260de99a5c4f83055d959d.1530881548.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9782368c814417e812260de99a5c4f83055d959d.1530881548.git.anatoly.burakov@intel.com", "date": "2018-07-06T13:17:26", "name": "[RFC,05/11] malloc: enable retrieving statistics from named heaps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "eba418f20fb0ca75e43a39c2b1b229645e8d39bb", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/9782368c814417e812260de99a5c4f83055d959d.1530881548.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 453, "url": "http://patchwork.dpdk.org/api/series/453/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=453", "date": "2018-07-06T13:17:21", "name": "Support externally allocated memory in DPDK", "version": 1, "mbox": "http://patchwork.dpdk.org/series/453/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42505/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A8B671BF13;\n\tFri, 6 Jul 2018 15:17:50 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 6AA681BE41\n\tfor <dev@dpdk.org>; Fri, 6 Jul 2018 15:17:38 +0200 (CEST)", "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Jul 2018 06:17:35 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga006.jf.intel.com with ESMTP; 06 Jul 2018 06:17:34 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw66DHX3P027482; Fri, 6 Jul 2018 14:17:33 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w66DHXYk003783;\n\tFri, 6 Jul 2018 14:17:33 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w66DHX6t003775;\n\tFri, 6 Jul 2018 14:17:33 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,316,1526367600\"; d=\"scan'208\";a=\"55598237\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "srinath.mannam@broadcom.com, scott.branden@broadcom.com,\n\tajit.khaparde@broadcom.com", "Date": "Fri, 6 Jul 2018 14:17:26 +0100", "Message-Id": "<9782368c814417e812260de99a5c4f83055d959d.1530881548.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1530881548.git.anatoly.burakov@intel.com>", "<cover.1530881548.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1530881548.git.anatoly.burakov@intel.com>", "<cover.1530881548.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [RFC 05/11] malloc: enable retrieving statistics from\n\tnamed heaps", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add internal functions to look up heap by name, and enable\ndumping statistics for a specified named heap.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/include/rte_malloc.h | 19 +++++++++++--\n lib/librte_eal/common/malloc_heap.c | 31 ++++++++++++++++++++++\n lib/librte_eal/common/malloc_heap.h | 6 +++++\n lib/librte_eal/common/rte_malloc.c | 17 ++++++++++++\n lib/librte_eal/rte_eal_version.map | 1 +\n 5 files changed, 72 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_malloc.h b/lib/librte_eal/common/include/rte_malloc.h\nindex a9fb7e452..7cbcd3184 100644\n--- a/lib/librte_eal/common/include/rte_malloc.h\n+++ b/lib/librte_eal/common/include/rte_malloc.h\n@@ -256,13 +256,28 @@ rte_malloc_validate(const void *ptr, size_t *size);\n * @param socket_stats\n * A structure which provides memory to store statistics\n * @return\n- * Null on error\n- * Pointer to structure storing statistics on success\n+ * 0 on success\n+ * -1 on error\n */\n int\n rte_malloc_get_socket_stats(int socket,\n \t\tstruct rte_malloc_socket_stats *socket_stats);\n \n+/**\n+ * Get heap statistics for the specified heap.\n+ *\n+ * @param socket\n+ * An unsigned integer specifying the socket to get heap statistics for\n+ * @param socket_stats\n+ * A structure which provides memory to store statistics\n+ * @return\n+ * 0 on success\n+ * -1 on error\n+ */\n+int __rte_experimental\n+rte_malloc_get_stats_from_heap(const char *heap_name,\n+\t\tstruct rte_malloc_socket_stats *socket_stats);\n+\n /**\n * Dump statistics.\n *\ndiff --git a/lib/librte_eal/common/malloc_heap.c b/lib/librte_eal/common/malloc_heap.c\nindex 8f22c062b..8437d33b3 100644\n--- a/lib/librte_eal/common/malloc_heap.c\n+++ b/lib/librte_eal/common/malloc_heap.c\n@@ -614,6 +614,37 @@ malloc_heap_free_pages(void *aligned_start, size_t aligned_len)\n \treturn 0;\n }\n \n+int\n+malloc_heap_find_named_heap_idx(const char *heap_name)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\tint heap_idx;\n+\n+\tif (heap_name == NULL)\n+\t\treturn -1;\n+\tif (strnlen(heap_name, RTE_HEAP_NAME_MAX_LEN) == RTE_HEAP_NAME_MAX_LEN)\n+\t\treturn -1;\n+\tfor (heap_idx = rte_socket_count(); heap_idx < RTE_MAX_HEAPS;\n+\t\t\theap_idx++) {\n+\t\tstruct malloc_heap *heap = &mcfg->malloc_heaps[heap_idx];\n+\t\tif (strncmp(heap->name, heap_name, RTE_HEAP_NAME_MAX_LEN) == 0)\n+\t\t\treturn heap_idx;\n+\t}\n+\treturn -1;\n+}\n+\n+struct malloc_heap *\n+malloc_heap_find_named_heap(const char *heap_name)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\tint heap_idx;\n+\n+\theap_idx = malloc_heap_find_named_heap_idx(heap_name);\n+\tif (heap_idx < 0)\n+\t\treturn NULL;\n+\treturn &mcfg->malloc_heaps[heap_idx];\n+}\n+\n int\n malloc_heap_free(struct malloc_elem *elem)\n {\ndiff --git a/lib/librte_eal/common/malloc_heap.h b/lib/librte_eal/common/malloc_heap.h\nindex 03b801415..4f3137260 100644\n--- a/lib/librte_eal/common/malloc_heap.h\n+++ b/lib/librte_eal/common/malloc_heap.h\n@@ -29,6 +29,12 @@ void *\n malloc_heap_alloc(const char *type, size_t size, int socket, unsigned int flags,\n \t\tsize_t align, size_t bound, bool contig);\n \n+int\n+malloc_heap_find_named_heap_idx(const char *name);\n+\n+struct malloc_heap *\n+malloc_heap_find_named_heap(const char *name);\n+\n int\n malloc_heap_free(struct malloc_elem *elem);\n \ndiff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c\nindex 75d6e0b4d..2508abdb1 100644\n--- a/lib/librte_eal/common/rte_malloc.c\n+++ b/lib/librte_eal/common/rte_malloc.c\n@@ -165,6 +165,23 @@ rte_malloc_get_socket_stats(int socket,\n \t\t\tsocket_stats);\n }\n \n+/*\n+ * Function to retrieve data for heap on given socket\n+ */\n+int __rte_experimental\n+rte_malloc_get_stats_from_heap(const char *heap_name,\n+\t\tstruct rte_malloc_socket_stats *socket_stats)\n+{\n+\tstruct malloc_heap *heap;\n+\n+\theap = malloc_heap_find_named_heap(heap_name);\n+\n+\tif (heap == NULL)\n+\t\treturn -1;\n+\n+\treturn malloc_heap_get_stats(heap, socket_stats);\n+}\n+\n /*\n * Function to dump contents of all heaps\n */\ndiff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map\nindex e7fb37b2a..786df1e39 100644\n--- a/lib/librte_eal/rte_eal_version.map\n+++ b/lib/librte_eal/rte_eal_version.map\n@@ -278,6 +278,7 @@ EXPERIMENTAL {\n \trte_fbarray_set_used;\n \trte_log_register_type_and_pick_level;\n \trte_malloc_dump_heaps;\n+\trte_malloc_get_stats_from_heap;\n \trte_mem_alloc_validator_register;\n \trte_mem_alloc_validator_unregister;\n \trte_mem_event_callback_register;\n", "prefixes": [ "RFC", "05/11" ] }