Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42510,
    "url": "http://patchwork.dpdk.org/api/patches/42510/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180706132119.9013-1-remy.horton@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180706132119.9013-1-remy.horton@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180706132119.9013-1-remy.horton@intel.com",
    "date": "2018-07-06T13:21:19",
    "name": "[v1] lib/metrics: add check for invalid metric keys",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "d046430951bf84719a2e02a439d45b95af296ac5",
    "submitter": {
        "id": 326,
        "url": "http://patchwork.dpdk.org/api/people/326/?format=api",
        "name": "Remy Horton",
        "email": "remy.horton@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180706132119.9013-1-remy.horton@intel.com/mbox/",
    "series": [
        {
            "id": 454,
            "url": "http://patchwork.dpdk.org/api/series/454/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=454",
            "date": "2018-07-06T13:21:19",
            "name": "[v1] lib/metrics: add check for invalid metric keys",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/454/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/42510/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/42510/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3E3891BEB2;\n\tFri,  6 Jul 2018 15:21:24 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 63F361BEA2\n\tfor <dev@dpdk.org>; Fri,  6 Jul 2018 15:21:22 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t06 Jul 2018 06:21:21 -0700",
            "from rhorton-mobl1.ger.corp.intel.com (HELO FC23.ir.intel.com)\n\t([163.33.178.248])\n\tby orsmga003.jf.intel.com with ESMTP; 06 Jul 2018 06:21:20 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,316,1526367600\"; d=\"scan'208\";a=\"64907830\"",
        "From": "Remy Horton <remy.horton@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Fri,  6 Jul 2018 14:21:19 +0100",
        "Message-Id": "<20180706132119.9013-1-remy.horton@intel.com>",
        "X-Mailer": "git-send-email 2.9.5",
        "Subject": "[dpdk-dev] [PATCH v1] lib/metrics: add check for invalid metric keys",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patchset adds a check to rte_metrics_update_values()\nthat prevents the updating of metrics when presented with\nan invalid metric key. Previously, doing the latter could\nresult in a crash.\n\nFixes: 349950ddb9c5 (\"metrics: add information metrics library\")\n\nSigned-off-by: Remy Horton <remy.horton@intel.com>\n---\n lib/librte_metrics/rte_metrics.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c\nindex 258f058..b5638f5 100644\n--- a/lib/librte_metrics/rte_metrics.c\n+++ b/lib/librte_metrics/rte_metrics.c\n@@ -159,6 +159,11 @@ rte_metrics_update_values(int port_id,\n \tstats = memzone->addr;\n \n \trte_spinlock_lock(&stats->lock);\n+\n+\tif (key >= stats->cnt_stats) {\n+\t\trte_spinlock_unlock(&stats->lock);\n+\t\treturn -EINVAL;\n+\t}\n \tidx_metric = key;\n \tcnt_setsize = 1;\n \twhile (idx_metric < stats->cnt_stats) {\n",
    "prefixes": [
        "v1"
    ]
}