Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 42671,
    "url": "http://patchwork.dpdk.org/api/patches/42671/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180710103727.209243-1-shaopeng.he@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180710103727.209243-1-shaopeng.he@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180710103727.209243-1-shaopeng.he@intel.com",
    "date": "2018-07-10T10:37:27",
    "name": "net/i40e: fix tx queue setup after stop queue",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "e1cdae00a2512e8170527a7e328216239bc09d3c",
    "submitter": {
        "id": 226,
        "url": "http://patchwork.dpdk.org/api/people/226/?format=api",
        "name": "He, Shaopeng",
        "email": "shaopeng.he@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180710103727.209243-1-shaopeng.he@intel.com/mbox/",
    "series": [
        {
            "id": 484,
            "url": "http://patchwork.dpdk.org/api/series/484/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=484",
            "date": "2018-07-10T10:37:27",
            "name": "net/i40e: fix tx queue setup after stop queue",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/484/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/42671/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/42671/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8FA171B3B5;\n\tTue, 10 Jul 2018 08:44:46 +0200 (CEST)",
            "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 730FF1B3B4\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 08:44:45 +0200 (CEST)",
            "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t09 Jul 2018 23:44:43 -0700",
            "from shermansrv-s2600wft.sh.intel.com ([10.67.110.237])\n\tby fmsmga001.fm.intel.com with ESMTP; 09 Jul 2018 23:44:43 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,333,1526367600\"; d=\"scan'208\";a=\"71022521\"",
        "From": "Shaopeng He <shaopeng.he@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "qi.z.zhang@intel.com,\n\tShaopeng He <shaopeng.he@intel.com>",
        "Date": "Tue, 10 Jul 2018 06:37:27 -0400",
        "Message-Id": "<20180710103727.209243-1-shaopeng.he@intel.com>",
        "X-Mailer": "git-send-email 2.17.0",
        "Subject": "[dpdk-dev] [PATCH] net/i40e: fix tx queue setup after stop queue",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Currently, i40e_dev_tx_queue_setup_runtime checks simple tx and treats\nmbuf fast free offloading as No-simple, which is classified as simple tx\nin i40e_set_tx_function_flag. This inconsistent behavior causes tx queue\nsetup fail after queue was stopped. This patch fixes this bug.\n\nFixes: 399421100e08 (\"net/i40e: fix missing mbuf fast free offload\")\n\nSigned-off-by: Shaopeng He <shaopeng.he@intel.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 6032d5541..2bbb82fc3 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -2087,7 +2087,7 @@ i40e_dev_tx_queue_setup_runtime(struct rte_eth_dev *dev,\n \t}\n \t/* check simple tx conflict */\n \tif (ad->tx_simple_allowed) {\n-\t\tif (txq->offloads != 0 ||\n+\t\tif ((txq->offloads & ~DEV_TX_OFFLOAD_MBUF_FAST_FREE) != 0 ||\n \t\t\t\ttxq->tx_rs_thresh < RTE_PMD_I40E_TX_MAX_BURST) {\n \t\t\tPMD_DRV_LOG(ERR, \"No-simple tx is required.\");\n \t\t\treturn -EINVAL;\n",
    "prefixes": []
}