Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/42717/?format=api
{ "id": 42717, "url": "http://patchwork.dpdk.org/api/patches/42717/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1531234465-31339-1-git-send-email-thiery.ouattara@outscale.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1531234465-31339-1-git-send-email-thiery.ouattara@outscale.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1531234465-31339-1-git-send-email-thiery.ouattara@outscale.com", "date": "2018-07-10T14:54:25", "name": "eal: allow start two dpdk with no-huge option", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "802c27673dd6a9a23c7b78f26f9b52c0adc75161", "submitter": { "id": 1074, "url": "http://patchwork.dpdk.org/api/people/1074/?format=api", "name": "Thiery Ouattara", "email": "thiery.ouattara@outscale.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1531234465-31339-1-git-send-email-thiery.ouattara@outscale.com/mbox/", "series": [ { "id": 496, "url": "http://patchwork.dpdk.org/api/series/496/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=496", "date": "2018-07-10T14:54:25", "name": "eal: allow start two dpdk with no-huge option", "version": 1, "mbox": "http://patchwork.dpdk.org/series/496/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/42717/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/42717/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0E7881B448;\n\tTue, 10 Jul 2018 16:54:06 +0200 (CEST)", "from mail-wm0-f99.google.com (mail-wm0-f99.google.com\n\t[74.125.82.99]) by dpdk.org (Postfix) with ESMTP id 642801B058\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 16:54:04 +0200 (CEST)", "by mail-wm0-f99.google.com with SMTP id v3-v6so21085894wmh.0\n\tfor <dev@dpdk.org>; Tue, 10 Jul 2018 07:54:04 -0700 (PDT)", "from ip-10-9-15-30.eu-west-2.compute.eu-west-2.compute.internal\n\t(ows-109-232-238-189.eu-west-2.compute.outscale.com.\n\t[109.232.238.189]) by smtp-relay.gmail.com with ESMTPS id\n\tj18-v6sm674262wro.16.2018.07.10.07.54.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 10 Jul 2018 07:54:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=outscale-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=8gUai8slRTZq06anEFFWyW75QNck659l/1BKH8ZexLE=;\n\tb=oXq+q8uufW+cHnUGjCCqvKtYRzCogZcKEASPm6IQHYn4L/ig40iv0ST4/a8/uE8Yua\n\t7oi/T9LAajI9Jo4NAS0ZBt27uO+LqQuu/3RsGm3Zi8ScIWRvM6Lnw4bx++f2usd3ff5c\n\tJoHVgRr9xoPXY2o2q79gmKZyWToFsH5enEgyFm3OWiDzVod6RDBS/WdU/WQtiygF7j50\n\t6nqXwbZSLnBmqj2QqenlXPfM6tWoS/elvp6IeEXFKEp1RM3a/UQFFlvONc0S7gPUMEgi\n\taW4ThgYBOSTUEGQ1w/HlYcYoPg2P1ZW8keWrte0l5if2PnLTNZSVOv0bUUWaO3uVEZ3j\n\tlKvQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=8gUai8slRTZq06anEFFWyW75QNck659l/1BKH8ZexLE=;\n\tb=stL0sOIYLQuRJbFbCKa8dVb+uhBk6bmRN2YBaaMN/sHwZIlo/xo6Lt7LBaJUkv0o+9\n\toJhKhgMEXgndd8ig8d+BGFdATLHWxuKvcb8PqFSoc9M4RtrcS+rWUHbmAOnG0W3TAv6o\n\tx6dmBfZIiv53GKtAoKt6qYnhiZcEzS1Ds9daf3TAVgUAM2bbyCTMQc8TzbLPPqRFHgtH\n\tinr9l36VWnraqHSUGPvOU31Set2Xli/VYn8B/k4TUBt7LqS3j21YLTnfKTw6XeuxPK/2\n\tIjOFluDNp4Yf7MhUlW+ibB7OnEN6TdWPuCnjL3ImRJ3i0mZ7oVRNLb+aS9N/zmFU0teB\n\toHaA==", "X-Gm-Message-State": "APt69E36+OZyuHmYl7AVe+Hv9vg8c/yc8wUlDmv+S/WcGLSR0z+MN/va\n\tdJwthT1689naggGgVpMN/IWHtaDJduQYy8WEU/YsGGwKBB6xiQ==", "X-Google-Smtp-Source": "AAOMgpd72j85VeWbJb3MgWDeeoWwJYjK/izadrsG6ybWdqxcUfETtHJOLp13czd/4UjBLkEo+fE8i14774ai", "X-Received": "by 2002:a1c:4489:: with SMTP id\n\tr131-v6mr14335949wma.128.1531234444217; \n\tTue, 10 Jul 2018 07:54:04 -0700 (PDT)", "X-Relaying-Domain": "outscale.com", "From": "thiery.ouattara@outscale.com", "To": "dev@dpdk.org", "Cc": "thiery.ouattara@outscale.com,\n\tanatoly.burakov@intel.com", "Date": "Tue, 10 Jul 2018 16:54:25 +0200", "Message-Id": "<1531234465-31339-1-git-send-email-thiery.ouattara@outscale.com>", "X-Mailer": "git-send-email 1.9.1", "Subject": "[dpdk-dev] [PATCH] eal: allow start two dpdk with no-huge option", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Kignelman OUATTARA <thiery.ouattara@outscale.com>\n\nin last version (v18.02), we was using no-huge option to\nstart 2 dpdk instances simultanusly (for testing purpose).\n\nbut since v18.05 when we start 2 instances:\n- the first dpdk app start normaly\n- the 2nd can't start because LOCK_EX option is set in\n flock(fd, LOCK_EX | LOCK_NB).\n\nSo i did this patch to change LOCK_EX to LOCK_SH if no-huge\noption is set.\n\nSigned-off-by: Kignelman OUATTARA <thiery.ouattara@outscale.com>\n---\n lib/librte_eal/common/eal_common_fbarray.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_fbarray.c b/lib/librte_eal/common/eal_common_fbarray.c\nindex 019f84c..7a7b9af 100644\n--- a/lib/librte_eal/common/eal_common_fbarray.c\n+++ b/lib/librte_eal/common/eal_common_fbarray.c\n@@ -414,6 +414,7 @@ struct used_mask {\n \tstruct used_mask *msk;\n \tvoid *data = NULL;\n \tint fd = -1;\n+\tint lock_opt = LOCK_EX;\n \n \tif (arr == NULL) {\n \t\trte_errno = EINVAL;\n@@ -436,6 +437,9 @@ struct used_mask {\n \n \teal_get_fbarray_path(path, sizeof(path), name);\n \n+\tif (internal_config.no_hugetlbfs)\n+\t\tlock_opt = LOCK_SH;\n+\n \t/*\n \t * Each fbarray is unique to process namespace, i.e. the filename\n \t * depends on process prefix. Try to take out a lock and see if we\n@@ -447,7 +451,7 @@ struct used_mask {\n \t\t\t\tpath, strerror(errno));\n \t\trte_errno = errno;\n \t\tgoto fail;\n-\t} else if (flock(fd, LOCK_EX | LOCK_NB)) {\n+\t} else if (flock(fd, lock_opt | LOCK_NB)) {\n \t\tRTE_LOG(DEBUG, EAL, \"%s(): couldn't lock %s: %s\\n\", __func__,\n \t\t\t\tpath, strerror(errno));\n \t\trte_errno = EBUSY;\n", "prefixes": [] }