Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43040/?format=api
{ "id": 43040, "url": "http://patchwork.dpdk.org/api/patches/43040/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/e04ddc9e8663d452a649a8590c38300439643cef.1531478258.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<e04ddc9e8663d452a649a8590c38300439643cef.1531478258.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/e04ddc9e8663d452a649a8590c38300439643cef.1531478258.git.anatoly.burakov@intel.com", "date": "2018-07-13T10:44:48", "name": "[v2] eal: move runtime config file to new location", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c0000ba582f8419805760eb56b5511542a1c403b", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/e04ddc9e8663d452a649a8590c38300439643cef.1531478258.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 562, "url": "http://patchwork.dpdk.org/api/series/562/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=562", "date": "2018-07-13T10:44:48", "name": "[v2] eal: move runtime config file to new location", "version": 2, "mbox": "http://patchwork.dpdk.org/series/562/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43040/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43040/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9DA685B1C;\n\tFri, 13 Jul 2018 12:44:53 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 8D3265B1A\n\tfor <dev@dpdk.org>; Fri, 13 Jul 2018 12:44:52 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t13 Jul 2018 03:44:50 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 13 Jul 2018 03:44:48 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw6DAimpL013138; Fri, 13 Jul 2018 11:44:48 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w6DAimL6003710;\n\tFri, 13 Jul 2018 11:44:48 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w6DAimq5003706;\n\tFri, 13 Jul 2018 11:44:48 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,347,1526367600\"; d=\"scan'208\";a=\"56597457\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "Neil Horman <nhorman@tuxdriver.com>,\n\tJohn McNamara <john.mcnamara@intel.com>,\n\tMarko Kovacevic <marko.kovacevic@intel.com>, thomas@monjalon.net,\n\tbruce.richardson@intel.com, harry.van.haaren@intel.com", "Date": "Fri, 13 Jul 2018 11:44:48 +0100", "Message-Id": "<e04ddc9e8663d452a649a8590c38300439643cef.1531478258.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<abb7d1fd951fd34792fbb0a394cbcfaad1a4ad43.1527780522.git.anatoly.burakov@intel.com>", "References": "<abb7d1fd951fd34792fbb0a394cbcfaad1a4ad43.1527780522.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] eal: move runtime config file to new location", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As per deprecation notice [1], move DPDK runtime config to default\nDPDK runtime data location. Also, remove the deprecation notice and\nupdate release notes to indicate the changes.\n\n[1] http://dpdk.org/dev/patchwork/patch/40418/\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n doc/guides/rel_notes/deprecation.rst | 10 ----------\n doc/guides/rel_notes/release_18_08.rst | 7 +++++++\n lib/librte_eal/common/eal_filesystem.h | 10 +++-------\n 3 files changed, 10 insertions(+), 17 deletions(-)", "diff": "diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst\nindex 5de59833d..14714fe94 100644\n--- a/doc/guides/rel_notes/deprecation.rst\n+++ b/doc/guides/rel_notes/deprecation.rst\n@@ -8,16 +8,6 @@ API and ABI deprecation notices are to be posted here.\n Deprecation Notices\n -------------------\n \n-* eal: DPDK runtime configuration file (located at\n- ``/var/run/.<prefix>_config``) will be moved. The new path will be as follows:\n-\n- - if DPDK is running as root, path will be set to\n- ``/var/run/dpdk/<prefix>/config``\n- - if DPDK is not running as root and $XDG_RUNTIME_DIR is set, path will be set\n- to ``$XDG_RUNTIME_DIR/dpdk/<prefix>/config``\n- - if DPDK is not running as root and $XDG_RUNTIME_DIR is not set, path will be\n- set to ``/tmp/dpdk/<prefix>/config``\n-\n * eal: both declaring and identifying devices will be streamlined in v18.08.\n New functions will appear to query a specific port from buses, classes of\n device and device drivers. Device declaration will be made coherent with the\ndiff --git a/doc/guides/rel_notes/release_18_08.rst b/doc/guides/rel_notes/release_18_08.rst\nindex d41546c27..ebe7e6bd6 100644\n--- a/doc/guides/rel_notes/release_18_08.rst\n+++ b/doc/guides/rel_notes/release_18_08.rst\n@@ -129,6 +129,13 @@ API Changes\n - ``RTE_COMP_FF_OOP_SGL_IN_LB_OUT``\n - ``RTE_COMP_FF_OOP_LB_IN_SGL_OUT``\n \n+* Path to runtime config file has changed. The new path is determined as\n+ follows:\n+ - If DPDK is running as root, ``/var/run/dpdk/<prefix>/config``\n+ - If DPDK is not running as root:\n+ - If ``$XDG_RUNTIME_DIR`` is set, ``${XDG_RUNTIME_DIR}/dpdk/<prefix>/config``\n+ - Otherwise, ``/tmp/dpdk/<prefix>/config``\n+\n \n ABI Changes\n -----------\ndiff --git a/lib/librte_eal/common/eal_filesystem.h b/lib/librte_eal/common/eal_filesystem.h\nindex 364f38d13..de05febf4 100644\n--- a/lib/librte_eal/common/eal_filesystem.h\n+++ b/lib/librte_eal/common/eal_filesystem.h\n@@ -12,7 +12,6 @@\n #define EAL_FILESYSTEM_H\n \n /** Path of rte config file. */\n-#define RUNTIME_CONFIG_FMT \"%s/.%s_config\"\n \n #include <stdint.h>\n #include <limits.h>\n@@ -30,17 +29,14 @@ eal_create_runtime_dir(void);\n const char *\n eal_get_runtime_dir(void);\n \n+#define RUNTIME_CONFIG_FNAME \"config\"\n static inline const char *\n eal_runtime_config_path(void)\n {\n \tstatic char buffer[PATH_MAX]; /* static so auto-zeroed */\n-\tconst char *directory = \"/var/run\";\n-\tconst char *home_dir = getenv(\"HOME\");\n \n-\tif (getuid() != 0 && home_dir != NULL)\n-\t\tdirectory = home_dir;\n-\tsnprintf(buffer, sizeof(buffer) - 1, RUNTIME_CONFIG_FMT, directory,\n-\t\t\tinternal_config.hugefile_prefix);\n+\tsnprintf(buffer, sizeof(buffer) - 1, \"%s/%s\", eal_get_runtime_dir(),\n+\t\t\tRUNTIME_CONFIG_FNAME);\n \treturn buffer;\n }\n \n", "prefixes": [ "v2" ] }