Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43230/?format=api
{ "id": 43230, "url": "http://patchwork.dpdk.org/api/patches/43230/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180720114103.18211-1-thomas@monjalon.net/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180720114103.18211-1-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20180720114103.18211-1-thomas@monjalon.net", "date": "2018-07-20T11:41:03", "name": "devtools: fix checkpatch for filename with space", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3de1f8e02a9c45a890d0946b727503a5a515bd7d", "submitter": { "id": 685, "url": "http://patchwork.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180720114103.18211-1-thomas@monjalon.net/mbox/", "series": [ { "id": 688, "url": "http://patchwork.dpdk.org/api/series/688/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=688", "date": "2018-07-20T11:41:03", "name": "devtools: fix checkpatch for filename with space", "version": 1, "mbox": "http://patchwork.dpdk.org/series/688/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43230/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/43230/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9869D29D2;\n\tFri, 20 Jul 2018 13:41:13 +0200 (CEST)", "from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com\n\t[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 529C329AC\n\tfor <dev@dpdk.org>; Fri, 20 Jul 2018 13:41:12 +0200 (CEST)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id BCFBD211E5;\n\tFri, 20 Jul 2018 07:41:11 -0400 (EDT)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Fri, 20 Jul 2018 07:41:11 -0400", "from xps.monjalon.net (unknown [207.232.18.42])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 7A7CC1025D;\n\tFri, 20 Jul 2018 07:41:08 -0400 (EDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tcc:date:from:message-id:subject:to:x-me-sender:x-me-sender\n\t:x-sasl-enc; s=mesmtp; bh=2TDQ8zmms1wMmZ5Lu+p7Q60TZkTJdJRuZFDjND\n\t4bcNQ=; b=T8lMZeGDJ/9Ii0mRRstOCf1Wz80aej2Qi5Fpn871LOLz4+/oma5EXK\n\tBJNF4NN5BEcGJlRPpBc0iEYqusShyf0yMpzKL6FpHGhWzZeBqQ6ugSD0k0FUMMS0\n\tqtTQOG4l1JJ7WXx26Czgrmt7MN7kyq8TizwInVfJhEj5J4UnJ2Dhg=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:date:from:message-id:subject:to\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=2TDQ8zmms1wMmZ5Lu\n\t+p7Q60TZkTJdJRuZFDjND4bcNQ=; b=rYCeEImg3RJU9P6UATEFhuNEp+Z5Dg8P3\n\tqWeIku9FBFdLUWYFreoLXWy+yioLVQnNAbcgaRcs5JwPZm6H2bMr4YJaSdDj3tpq\n\t6NDLPbpgjhF4UG9LFemxlGEJnV4AgJmTX6fVk1g4g27YyYR9uOdN8NSmeYGwG98M\n\tGZBJ3qoteM3BaxdZqR2+S421uvcNevS3eFbznMvhw7HJdrw6pU8RT+1CptvhxKxO\n\tOY+Pe7G8wXqsUakkHcJ8H68AM9xqgq8CUaTlNW1RqR0pBSasGmtVqthaEWqVwbI2\n\tvMx3nSuHmDn6DeFSOEo1K9xhNo3yxi9HbeK5I8T1wo1j6ygoHbKKg==" ], "X-ME-Proxy": "<xmx:VcpRW-22Eqseg0A7HiD1wBEBV-J2Nm00d396U9XAvfUrUaUdsEL81A>\n\t<xmx:VcpRWxb_qQrmdStdcD9td1PVINYNj8cUSwjfM8UoGutDUznjgoft3g>\n\t<xmx:VcpRW-hDYn961N14_KOD16jmdL_LMVYV_bF3G9GGBr3KrsZ5nrJv-w>\n\t<xmx:VcpRW6cL6xk-4g0iIJMbE2ak-5sRmY1zw8sBUR_WAitPNxoY9IS7rg>\n\t<xmx:VcpRW5qVGJaxC_lbqNRvwcQZ0yWHmob6rxpoe2bHGtiTXAIugnUfaw>\n\t<xmx:V8pRW8m_zU-MICo3Ps4uGoAktVCAutQ3JQT4OQUHC92eQO17jRZMqQ>", "X-ME-Sender": "<xms:VcpRWwL7kmc8XLho_8ORwN1yha25QXL8-w7kTAsQPm9Qzu9-CELTkQ>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "nhorman@tuxdriver.com", "Cc": "dev@dpdk.org", "Date": "Fri, 20 Jul 2018 13:41:03 +0200", "Message-Id": "<20180720114103.18211-1-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH] devtools: fix checkpatch for filename with space", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If the patch filename or the temporary file path have a space\nin their name, the script checkpatches.sh does not work.\nThe variables for the filenames must be enclosed in quotes\nin order to preserve spaces.\n\nFixes: 4bec48184e33 (\"devtools: add checks for ABI symbol addition\")\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n\nStrangely, I did a fix for check-symbol-change.sh and I forgot\nto fix checkpatches.sh.\n\n---\n devtools/checkpatches.sh | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex 1439bce94..e97a4f2c9 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -25,7 +25,7 @@ NEW_TYPEDEFS,COMPARISON_TO_NULL\"\n \n clean_tmp_files() {\n \tif echo $tmpinput | grep -q '^checkpatches\\.' ; then\n-\t\trm -f $tmpinput\n+\t\trm -f \"$tmpinput\"\n \tfi\n }\n \n@@ -77,13 +77,13 @@ check () { # <patch> <commit> <title>\n \telif [ -n \"$2\" ] ; then\n \t\ttmpinput=$(mktemp checkpatches.XXXXXX)\n \t\tgit format-patch --find-renames \\\n-\t\t--no-stat --stdout -1 $commit > $tmpinput\n+\t\t--no-stat --stdout -1 $commit > \"$tmpinput\"\n \telse\n \t\ttmpinput=$(mktemp checkpatches.XXXXXX)\n-\t\tcat > $tmpinput\n+\t\tcat > \"$tmpinput\"\n \tfi\n \n-\treport=$($DPDK_CHECKPATCH_PATH $options $tmpinput 2>/dev/null)\n+\treport=$($DPDK_CHECKPATCH_PATH $options \"$tmpinput\" 2>/dev/null)\n \tif [ $? -ne 0 ] ; then\n \t\t$verbose || printf '\\n### %s\\n\\n' \"$3\"\n \t\tprintf '%s\\n' \"$report\" | sed -n '1,/^total:.*lines checked$/p'\n", "prefixes": [] }