Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43248/?format=api
{ "id": 43248, "url": "http://patchwork.dpdk.org/api/patches/43248/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1532112563-19524-1-git-send-email-fiona.trahe@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1532112563-19524-1-git-send-email-fiona.trahe@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1532112563-19524-1-git-send-email-fiona.trahe@intel.com", "date": "2018-07-20T18:49:23", "name": "[v3] crypto/qat: add support for 8 byte 3DES", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5b5cad377fff89d616de82558c0c43f091d2a70d", "submitter": { "id": 423, "url": "http://patchwork.dpdk.org/api/people/423/?format=api", "name": "Fiona Trahe", "email": "fiona.trahe@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1532112563-19524-1-git-send-email-fiona.trahe@intel.com/mbox/", "series": [ { "id": 700, "url": "http://patchwork.dpdk.org/api/series/700/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=700", "date": "2018-07-20T18:49:23", "name": "[v3] crypto/qat: add support for 8 byte 3DES", "version": 3, "mbox": "http://patchwork.dpdk.org/series/700/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43248/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/43248/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id F21B92BF5;\n\tFri, 20 Jul 2018 20:49:46 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 9887D29D2\n\tfor <dev@dpdk.org>; Fri, 20 Jul 2018 20:49:45 +0200 (CEST)", "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t20 Jul 2018 11:49:28 -0700", "from sivswdev01.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.45])\n\tby fmsmga006.fm.intel.com with ESMTP; 20 Jul 2018 11:49:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,380,1526367600\"; d=\"scan'208\";a=\"247491700\"", "From": "Fiona Trahe <fiona.trahe@intel.com>", "To": "dev@dpdk.org", "Cc": "pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,\n\tmarko.kovacevic@intel.com", "Date": "Fri, 20 Jul 2018 19:49:23 +0100", "Message-Id": "<1532112563-19524-1-git-send-email-fiona.trahe@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<20180704102024.28783-1-marko.kovacevic@intel.com>", "References": "<20180704102024.28783-1-marko.kovacevic@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] crypto/qat: add support for 8 byte 3DES", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Added extra case to support 8 byte key size\nfor 3DES CBC. Also changed capabilities to reflect\nthe change.\n\nSigned-off-by: Marko Kovacevic <marko.kovacevic@intel.com>\nSigned-off-by: Fiona Trahe <fiona.trahe@intel.com>\n---\nv3: rebased against QAT refactored code.\n\nv2: Fixed implementation (Fiona)\n\n drivers/crypto/qat/qat_sym_capabilities.h | 2 +-\n drivers/crypto/qat/qat_sym_session.c | 13 +++++++++++--\n drivers/crypto/qat/qat_sym_session.h | 2 ++\n test/test/test_cryptodev_des_test_vectors.h | 6 ++++--\n 4 files changed, 18 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/qat/qat_sym_capabilities.h b/drivers/crypto/qat/qat_sym_capabilities.h\nindex d10a95e..eea08bc 100644\n--- a/drivers/crypto/qat/qat_sym_capabilities.h\n+++ b/drivers/crypto/qat/qat_sym_capabilities.h\n@@ -434,7 +434,7 @@\n \t\t\t\t.algo = RTE_CRYPTO_CIPHER_3DES_CBC,\t\\\n \t\t\t\t.block_size = 8,\t\t\t\\\n \t\t\t\t.key_size = {\t\t\t\t\\\n-\t\t\t\t\t.min = 16,\t\t\t\\\n+\t\t\t\t\t.min = 8,\t\t\t\\\n \t\t\t\t\t.max = 24,\t\t\t\\\n \t\t\t\t\t.increment = 8\t\t\t\\\n \t\t\t\t},\t\t\t\t\t\\\ndiff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c\nindex 4d975ae..1d58220 100644\n--- a/drivers/crypto/qat/qat_sym_session.c\n+++ b/drivers/crypto/qat/qat_sym_session.c\n@@ -1322,11 +1322,19 @@ int qat_sym_session_aead_create_cd_cipher(struct qat_sym_session *cdesc,\n \tif (total_key_size > cipherkeylen) {\n \t\tuint32_t padding_size = total_key_size-cipherkeylen;\n \t\tif ((cdesc->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_3DES)\n-\t\t\t&& (cipherkeylen == QAT_3DES_KEY_SZ_OPT2))\n+\t\t\t&& (cipherkeylen == QAT_3DES_KEY_SZ_OPT2)) {\n \t\t\t/* K3 not provided so use K1 = K3*/\n \t\t\tmemcpy(cdesc->cd_cur_ptr, cipherkey, padding_size);\n-\t\telse\n+\t\t} else if ((cdesc->qat_cipher_alg == ICP_QAT_HW_CIPHER_ALGO_3DES)\n+\t\t\t&& (cipherkeylen == QAT_3DES_KEY_SZ_OPT3)) {\n+\t\t\t/* K2 and K3 not provided so use K1 = K2 = K3*/\n+\t\t\tmemcpy(cdesc->cd_cur_ptr, cipherkey,\n+\t\t\t\tcipherkeylen);\n+\t\t\tmemcpy(cdesc->cd_cur_ptr+cipherkeylen,\n+\t\t\t\tcipherkey, cipherkeylen);\n+\t\t} else\n \t\t\tmemset(cdesc->cd_cur_ptr, 0, padding_size);\n+\n \t\tcdesc->cd_cur_ptr += padding_size;\n \t}\n \tcd_size = cdesc->cd_cur_ptr-(uint8_t *)&cdesc->cd;\n@@ -1695,6 +1703,7 @@ int qat_sym_validate_3des_key(int key_len, enum icp_qat_hw_cipher_algo *alg)\n \tswitch (key_len) {\n \tcase QAT_3DES_KEY_SZ_OPT1:\n \tcase QAT_3DES_KEY_SZ_OPT2:\n+\tcase QAT_3DES_KEY_SZ_OPT3:\n \t\t*alg = ICP_QAT_HW_CIPHER_ALGO_3DES;\n \t\tbreak;\n \tdefault:\ndiff --git a/drivers/crypto/qat/qat_sym_session.h b/drivers/crypto/qat/qat_sym_session.h\nindex 18d77e9..e8f51e5 100644\n--- a/drivers/crypto/qat/qat_sym_session.h\n+++ b/drivers/crypto/qat/qat_sym_session.h\n@@ -23,6 +23,8 @@\n /* 3DES key sizes */\n #define QAT_3DES_KEY_SZ_OPT1 24 /* Keys are independent */\n #define QAT_3DES_KEY_SZ_OPT2 16 /* K3=K1 */\n+#define QAT_3DES_KEY_SZ_OPT3 8 /* K1=K2=K3 */\n+\n \n #define QAT_AES_HW_CONFIG_CBC_ENC(alg) \\\n \tICP_QAT_HW_CIPHER_CONFIG_BUILD(ICP_QAT_HW_CIPHER_CBC_MODE, alg, \\\ndiff --git a/test/test/test_cryptodev_des_test_vectors.h b/test/test/test_cryptodev_des_test_vectors.h\nindex 7479e70..1033456 100644\n--- a/test/test/test_cryptodev_des_test_vectors.h\n+++ b/test/test/test_cryptodev_des_test_vectors.h\n@@ -1233,14 +1233,16 @@ static const struct blockcipher_test_case triple_des_cipheronly_test_cases[] = {\n \t\t.test_data = &triple_des64cbc_test_vector,\n \t\t.op_mask = BLOCKCIPHER_TEST_OP_ENCRYPT,\n \t\t.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |\n-\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_QAT\n \t},\n \t{\n \t\t.test_descr = \"3DES-64-CBC Decryption\",\n \t\t.test_data = &triple_des64cbc_test_vector,\n \t\t.op_mask = BLOCKCIPHER_TEST_OP_DECRYPT,\n \t\t.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_MB |\n-\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |\n+\t\t\tBLOCKCIPHER_TEST_TARGET_PMD_QAT\n \t},\n \t{\n \t\t.test_descr = \"3DES-128-CBC Encryption\",\n", "prefixes": [ "v3" ] }