Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43261,
    "url": "http://patchwork.dpdk.org/api/patches/43261/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180723030557.5815-1-yanglong.wu@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20180723030557.5815-1-yanglong.wu@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20180723030557.5815-1-yanglong.wu@intel.com",
    "date": "2018-07-23T03:05:57",
    "name": "net/ixgbe: fix link status when link is NACK",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4cea7438398e65ac1c834b57c64675d43f86329e",
    "submitter": {
        "id": 879,
        "url": "http://patchwork.dpdk.org/api/people/879/?format=api",
        "name": "Yanglong Wu",
        "email": "yanglong.wu@intel.com"
    },
    "delegate": {
        "id": 1540,
        "url": "http://patchwork.dpdk.org/api/users/1540/?format=api",
        "username": "qzhan15",
        "first_name": "Qi",
        "last_name": "Zhang",
        "email": "qi.z.zhang@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180723030557.5815-1-yanglong.wu@intel.com/mbox/",
    "series": [
        {
            "id": 708,
            "url": "http://patchwork.dpdk.org/api/series/708/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=708",
            "date": "2018-07-23T03:05:57",
            "name": "net/ixgbe: fix link status when link is NACK",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/708/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/43261/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/43261/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4A95814EC;\n\tMon, 23 Jul 2018 05:15:43 +0200 (CEST)",
            "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 613EE98\n\tfor <dev@dpdk.org>; Mon, 23 Jul 2018 05:15:42 +0200 (CEST)",
            "from fmsmga006.fm.intel.com ([10.253.24.20])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t22 Jul 2018 20:15:41 -0700",
            "from wuyanglong.sh.intel.com ([10.67.111.89])\n\tby fmsmga006.fm.intel.com with ESMTP; 22 Jul 2018 20:15:38 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.51,392,1526367600\"; d=\"scan'208\";a=\"247976358\"",
        "From": "Yanglong Wu <yanglong.wu@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "qi.z.zhang@intel.com, dong1.wang@intel.com,\n\tYanglong Wu <yanglong.wu@intel.com>",
        "Date": "Mon, 23 Jul 2018 11:05:57 +0800",
        "Message-Id": "<20180723030557.5815-1-yanglong.wu@intel.com>",
        "X-Mailer": "git-send-email 2.11.0",
        "Subject": "[dpdk-dev] [PATCH] net/ixgbe: fix link status when link is NACK",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Link status should be set as down when link is NACK.\n\nFixes: dc66e5fd01b9 (\"net/ixgbe: improve link state check on VF\")\n\nSigned-off-by: Yanglong Wu <yanglong.wu@intel.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 997683d3b..378ead4b4 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -3933,12 +3933,10 @@ ixgbevf_check_link(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t}\n \n \tif (no_pflink_check) {\n-\t\tif (*speed == IXGBE_LINK_SPEED_UNKNOWN)\n+\t\tif (*speed == IXGBE_LINK_SPEED_UNKNOWN) {\n \t\t\tmac->get_link_status = true;\n-\t\telse\n-\t\t\tmac->get_link_status = false;\n-\n-\t\tgoto out;\n+\t\t\tgoto out;\n+\t\t}\n \t}\n \t/* if the read failed it could just be a mailbox collision, best wait\n \t * until we are called again and don't report an error\n@@ -4013,6 +4011,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tif (diag != 0) {\n \t\tlink.link_speed = ETH_SPEED_NUM_100M;\n \t\tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\n+\t\tlink.link_status = ETH_LINK_DOWN;\n \t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n",
    "prefixes": []
}