Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43439/?format=api
{ "id": 43439, "url": "http://patchwork.dpdk.org/api/patches/43439/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180727172607.16890-1-bluca@debian.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180727172607.16890-1-bluca@debian.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180727172607.16890-1-bluca@debian.org", "date": "2018-07-27T17:26:07", "name": "net/e1000: do not error out if rx_drop_en is set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "20b9d276875f6a7e2fb7cbddf31925bf6410280e", "submitter": { "id": 823, "url": "http://patchwork.dpdk.org/api/people/823/?format=api", "name": "Luca Boccassi", "email": "bluca@debian.org" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180727172607.16890-1-bluca@debian.org/mbox/", "series": [ { "id": 810, "url": "http://patchwork.dpdk.org/api/series/810/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=810", "date": "2018-07-27T17:26:07", "name": "net/e1000: do not error out if rx_drop_en is set", "version": 1, "mbox": "http://patchwork.dpdk.org/series/810/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43439/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43439/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 20D155942;\n\tFri, 27 Jul 2018 19:26:16 +0200 (CEST)", "from mail-wr1-f67.google.com (mail-wr1-f67.google.com\n\t[209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 9408C56A3;\n\tFri, 27 Jul 2018 19:26:15 +0200 (CEST)", "by mail-wr1-f67.google.com with SMTP id c13-v6so5781813wrt.1;\n\tFri, 27 Jul 2018 10:26:15 -0700 (PDT)", "from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d])\n\tby smtp.gmail.com with ESMTPSA id\n\ts2-v6sm7809689wrn.83.2018.07.27.10.26.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 27 Jul 2018 10:26:13 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=8ru1ojlR06hFhSrJSAZGJzOioNF3GZm8mVV8gCPMDVY=;\n\tb=sOmJTpkxxmOyTS7/emf1+ifeESjTu0k3z461lt5yPzOpGcFgCse8djC8vOil7sprnE\n\tCgmZTxn3+/ZV8OxdEKCELqq/4s6YdoT/1fU+fYhbYKcuo5rRV3es78TC9myc3QVy+9z+\n\tWqHPAS/3ZgNiLwVmLXkVsYAO87roO43jJx2PjN2dIHhuflfwM2/8p/8GgK3/EHMAMEq+\n\teJh4NIXWalvk+SN7hbq42rQeRs9Z+BkRzjoK40uFD+krX7zUYjkDw6bHfEqDLypW5K+p\n\tcmiryesERtcyBUFFvJOzUUNWVBu/+SJcwjZuFG7twbBGnusxuLxKYbx6Zpx4Kz3z39OC\n\ts7Ng==", "X-Gm-Message-State": "AOUpUlEEJSsyev8SCSUYabiOeAhoEB8UCNS+cvfuffSAt2izqkq8YHxo\n\tz7sd7RVmwXcQqNfAqPFvy5c+tXpuHzY=", "X-Google-Smtp-Source": "AAOMgpc38txdpB12cBOoCfNYhF3ZhLu1inr4LYZFFkORIxCb1og0lM4s7bboU0FvzgSadQ78AdqgXQ==", "X-Received": "by 2002:a5d:66c4:: with SMTP id\n\tk4-v6mr5598120wrw.154.1532712375085; \n\tFri, 27 Jul 2018 10:26:15 -0700 (PDT)", "From": "Luca Boccassi <bluca@debian.org>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com, Luca Boccassi <bluca@debian.org>, stable@dpdk.org", "Date": "Fri, 27 Jul 2018 18:26:07 +0100", "Message-Id": "<20180727172607.16890-1-bluca@debian.org>", "X-Mailer": "git-send-email 2.18.0", "Subject": "[dpdk-dev] [PATCH] net/e1000: do not error out if rx_drop_en is set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "rx_drop_en is an optimization that does nothing on single-queue\ndevices like e1000. Do not force applications that do not care to\nselect per-devices optimizations flags by returning an error, just\nlog it and carry on.\n\nFixes: 805803445a02 (\"e1000: support EM devices (also known as e1000/e1000e)\")\nCc: stable@dpdk.org\n\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n drivers/net/e1000/em_rxtx.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/e1000/em_rxtx.c b/drivers/net/e1000/em_rxtx.c\nindex a6b3e92a6..81dc41efb 100644\n--- a/drivers/net/e1000/em_rxtx.c\n+++ b/drivers/net/e1000/em_rxtx.c\n@@ -1416,12 +1416,13 @@ eth_em_rx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \n \t/*\n-\t * EM devices don't support drop_en functionality\n+\t * EM devices don't support drop_en functionality.\n+\t * It's an optimization that does nothing on single-queue devices,\n+\t * so just log the issue and carry on.\n \t */\n \tif (rx_conf->rx_drop_en) {\n-\t\tPMD_INIT_LOG(ERR, \"drop_en functionality not supported by \"\n+\t\tPMD_INIT_LOG(NOTICE, \"drop_en functionality not supported by \"\n \t\t\t \"device\");\n-\t\treturn -EINVAL;\n \t}\n \n \t/* Free memory prior to re-allocation if needed. */\n", "prefixes": [] }