Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43440/?format=api
{ "id": 43440, "url": "http://patchwork.dpdk.org/api/patches/43440/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180727181317.7374-1-bluca@debian.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180727181317.7374-1-bluca@debian.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180727181317.7374-1-bluca@debian.org", "date": "2018-07-27T18:13:17", "name": "net/e1000: enable MSI-x for linkup and other events in 82574", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0e2f722035d05b95b2378c921f065b8e4f2b2eae", "submitter": { "id": 823, "url": "http://patchwork.dpdk.org/api/people/823/?format=api", "name": "Luca Boccassi", "email": "bluca@debian.org" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180727181317.7374-1-bluca@debian.org/mbox/", "series": [ { "id": 811, "url": "http://patchwork.dpdk.org/api/series/811/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=811", "date": "2018-07-27T18:13:17", "name": "net/e1000: enable MSI-x for linkup and other events in 82574", "version": 1, "mbox": "http://patchwork.dpdk.org/series/811/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43440/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43440/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 51E3F58CB;\n\tFri, 27 Jul 2018 20:13:24 +0200 (CEST)", "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id E77BC5688\n\tfor <dev@dpdk.org>; Fri, 27 Jul 2018 20:13:22 +0200 (CEST)", "by mail-wm0-f65.google.com with SMTP id y2-v6so6162810wma.1\n\tfor <dev@dpdk.org>; Fri, 27 Jul 2018 11:13:22 -0700 (PDT)", "from localhost ([2a00:23c5:be94:4600:7b12:f8a0:fd52:f87d])\n\tby smtp.gmail.com with ESMTPSA id\n\ts16-v6sm3893269wrq.20.2018.07.27.11.13.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tFri, 27 Jul 2018 11:13:21 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=BDlS+4+DgWIMj9DRrtmRYRSjis1Kfl2pLhjXWO4Lml0=;\n\tb=VbZMzjcE+90P0ZJsaL4238vX8yV0Sta+0wIlHYDXR+dap+nMrH0JsR/Nuff1YK22yH\n\tGpbmu68DlPtH3Lx/GgpCvVGwx4mW628YbnSPo31fFFIUm4Xl/Ir4HN2GkyNzuiAhAQpc\n\t7s5lbiOAPkI5lgIduqOC5IEYlikTiCJVl+jkDlm1rCA+I7kB1Ai+kuc0GZrcoYAetTOi\n\tZoxmPL9wUzEtwCR2j4cZHTIn7/ccCOQT5PCZ6nXkkQTER9W0QtH6HHDBYEh6x0ga+Mnr\n\tzuCkIqRNhNFoMJWGIAIP+QNWzgUU9n3GPwwRAAkqEJzIH8OVPxYPt5VbeCzLARGiGj3V\n\tOaUA==", "X-Gm-Message-State": "AOUpUlFTLYXP0hre7k1mMX2G5OeGUGpd57TSTVA+vFgEbJXCuwmkt273\n\tcSg/ExtwzSkM30ph98Lr01JOHsd+aU4=", "X-Google-Smtp-Source": "AAOMgpfZFOrWikFvNVyn7yGvmyhGKT9jEl8VGfh3nGk9HfGcszU8f5ZdJZAwocMpcK3Abc8lamJ1uw==", "X-Received": "by 2002:a1c:c912:: with SMTP id\n\tf18-v6mr5414080wmb.73.1532715202269; \n\tFri, 27 Jul 2018 11:13:22 -0700 (PDT)", "From": "Luca Boccassi <bluca@debian.org>", "To": "dev@dpdk.org", "Cc": "wenzhuo.lu@intel.com,\n\tLuca Boccassi <bluca@debian.org>", "Date": "Fri, 27 Jul 2018 19:13:17 +0100", "Message-Id": "<20180727181317.7374-1-bluca@debian.org>", "X-Mailer": "git-send-email 2.18.0", "Subject": "[dpdk-dev] [PATCH] net/e1000: enable MSI-x for linkup and other\n\tevents in 82574", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Linux supports 82574 MSI-x interrupt for linkup and other link\nconditions. Enable the same feature in the e1000 PMD in order to\nallow this card to work properly, as it requires interrupt\nhandling for link negotiations among other things.\n\nSigned-off-by: Luca Boccassi <bluca@debian.org>\n---\n\nHi Wenzhuo - just to make it clear, this patch and the previous are\nnot targeted for 18.08, just clearing my queue.\n\n drivers/net/e1000/base/e1000_82571.c | 5 +++++\n drivers/net/e1000/em_ethdev.c | 5 +++--\n 2 files changed, 8 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/e1000/base/e1000_82571.c b/drivers/net/e1000/base/e1000_82571.c\nindex 7c279dbb3..397dd9482 100644\n--- a/drivers/net/e1000/base/e1000_82571.c\n+++ b/drivers/net/e1000/base/e1000_82571.c\n@@ -1257,6 +1257,11 @@ STATIC s32 e1000_init_hw_82571(struct e1000_hw *hw)\n \t */\n \te1000_clear_hw_cntrs_82571(hw);\n \n+\t/* MSI-X configure for 82574 */\n+\tif (mac->type == e1000_82574)\n+\t\tE1000_WRITE_REG(hw, E1000_IVAR,\n+\t\t\t\t(E1000_IVAR_INT_ALLOC_VALID << 16));\n+\n \treturn ret_val;\n }\n \ndiff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c\nindex 7039dc100..bd05e4de0 100644\n--- a/drivers/net/e1000/em_ethdev.c\n+++ b/drivers/net/e1000/em_ethdev.c\n@@ -1444,7 +1444,8 @@ eth_em_interrupt_setup(struct rte_eth_dev *dev)\n \t/* clear interrupt */\n \tE1000_READ_REG(hw, E1000_ICR);\n \tregval = E1000_READ_REG(hw, E1000_IMS);\n-\tE1000_WRITE_REG(hw, E1000_IMS, regval | E1000_ICR_LSC);\n+\tE1000_WRITE_REG(hw, E1000_IMS,\n+\t\t\tregval | E1000_ICR_LSC | E1000_ICR_OTHER);\n \treturn 0;\n }\n \n@@ -1494,7 +1495,7 @@ em_rxq_intr_enable(struct e1000_hw *hw)\n static void\n em_lsc_intr_disable(struct e1000_hw *hw)\n {\n-\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC);\n+\tE1000_WRITE_REG(hw, E1000_IMC, E1000_IMS_LSC | E1000_IMS_OTHER);\n \tE1000_WRITE_FLUSH(hw);\n }\n \n", "prefixes": [] }