Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43605/?format=api
{ "id": 43605, "url": "http://patchwork.dpdk.org/api/patches/43605/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180806181108.5913-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180806181108.5913-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20180806181108.5913-4-stephen@networkplumber.org", "date": "2018-08-06T18:11:08", "name": "[3/3] vmbus: handle eof on irq read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b06cffd3c4ede7ab7273aa048bc9fecbaa3e01a", "submitter": { "id": 27, "url": "http://patchwork.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180806181108.5913-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 919, "url": "http://patchwork.dpdk.org/api/series/919/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=919", "date": "2018-08-06T18:11:05", "name": "vmbus: coverity bug fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/919/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43605/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43605/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D80E21B42F;\n\tMon, 6 Aug 2018 20:11:24 +0200 (CEST)", "from mail-pg1-f195.google.com (mail-pg1-f195.google.com\n\t[209.85.215.195]) by dpdk.org (Postfix) with ESMTP id 15BD31B3A9\n\tfor <dev@dpdk.org>; Mon, 6 Aug 2018 20:11:21 +0200 (CEST)", "by mail-pg1-f195.google.com with SMTP id k3-v6so6578856pgq.5\n\tfor <dev@dpdk.org>; Mon, 06 Aug 2018 11:11:21 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tq78-v6sm23388130pfi.185.2018.08.06.11.11.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 06 Aug 2018 11:11:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Z2CtOy6KdQkaZanqPqxStSpV8o3G43Rg43XLi2pvEZc=;\n\tb=XWsxoqSkLCCcAz+NCve/zlTskXwR9ZSgxsqWJ0RNuESDLL7EcfR2nLi5WQ7vjXHU+Y\n\toVv7oRDuqDeUVtvVBvX5InvRQ92YxiyTNTaY5ESr0eRSFdP5W5FE84IHXwrog+4qQ86D\n\tMSKc8AFOMA13jgNcqc/EY/BTO21q5KIRw79nmnx9+8OgF3tcxzwaSRBHjQbx5bg4nQ2C\n\tnPiWueszZRRFLWbY+fbtHSgm/jDXMGUj13w+J1muhXVS5wkkmM5EQF9jaoz+3Y06RhUK\n\tmRRwn2MI4zkXG4kTsH4GgrfOmupk+qhPJ3TOHPJFO4+ClKR8Hzgy/TB++LFfYr+tDs6/\n\tBF2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Z2CtOy6KdQkaZanqPqxStSpV8o3G43Rg43XLi2pvEZc=;\n\tb=t44iq5hFylqnhTwNOgIm/puQOvxiHiKxVGT8cyE3NP8oOVkaUhiZm2ApXpFpKti1Hz\n\tAx88YOwpL2NCUEg4MyKAlhYTwSlOJ8I71MnYkMhxY8v3KDrqvYABfLe62Yxwxww8QYPy\n\tKaKSIyX4qiO4YXyuhT3K3qoITLSlcpECl/19qUXDzAPQaF1PAmrj84fzI62cvMRxtSsw\n\tTbv9cuI5+uLc6C0MaGToIULSncgGtXH7rHNrHsJbup8513bZgNjO0qIP0JFYJ3bO08TD\n\tpGYoyCh+TlAUPMFTQtq4kP3iCtVNqFSssaYW/j4sippKfy2G5oAzm4vPRyFNh6zcbKtv\n\tAKag==", "X-Gm-Message-State": "AOUpUlG7Il+cJIUEVrklMkxtxvA47nXG3UEBWIaL41ESzp1Q7+YpiixS\n\tvl56hpSaIc2XQT7Ex+zLSQmS3sQSjEM=", "X-Google-Smtp-Source": "AAOMgpefQwtV5Go8bem2bY2ZBYg6SZwiXQ/F59aC/Gp0S77ZfKqRc33Y4TdPNcukzhPcEXL058aGXg==", "X-Received": "by 2002:a65:58c8:: with SMTP id\n\te8-v6mr15261766pgu.96.1533579080818; \n\tMon, 06 Aug 2018 11:11:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Mon, 6 Aug 2018 11:11:08 -0700", "Message-Id": "<20180806181108.5913-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20180806181108.5913-1-stephen@networkplumber.org>", "References": "<20180806181108.5913-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH 3/3] vmbus: handle eof on irq read", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This function is not used by netvsc driver yet.\nStill the code should handle case where device driver returns\nzero (due to rescind).\n\nCoverity issue: 302871\nFixes: 831dba47bd36 (\"bus/vmbus: add Hyper-V virtual bus support\")\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/bus/vmbus/linux/vmbus_uio.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex bc2c6235e6bc..856c6d66785d 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -39,11 +39,17 @@ void vmbus_uio_irq_control(struct rte_vmbus_device *dev, int32_t onoff)\n int vmbus_uio_irq_read(struct rte_vmbus_device *dev)\n {\n \tint32_t count;\n-\n-\tif (read(dev->intr_handle.fd, &count, sizeof(count)) < 0) {\n-\t\tVMBUS_LOG(ERR, \"cannot read to %d:%s\",\n-\t\t\tdev->intr_handle.fd, strerror(errno));\n-\t\tcount = -errno;\n+\tint cc;\n+\n+\tcc = read(dev->intr_handle.fd, &count, sizeof(count));\n+\tif (cc < (int)sizeof(count)) {\n+\t\tif (cc < 0) {\n+\t\t\tVMBUS_LOG(ERR, \"IRQ read failed %s\",\n+\t\t\t\t strerror(errno));\n+\t\t\treturn -errno;\n+\t\t}\n+\t\tVMBUS_LOG(ERR, \"can't read IRQ count\");\n+\t\treturn -EINVAL;\n \t}\n \n \treturn count;\n", "prefixes": [ "3/3" ] }