Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43696,
    "url": "http://patchwork.dpdk.org/api/patches/43696/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1534176226-21911-1-git-send-email-david.marchand@6wind.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1534176226-21911-1-git-send-email-david.marchand@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1534176226-21911-1-git-send-email-david.marchand@6wind.com",
    "date": "2018-08-13T16:03:45",
    "name": "[RFC,1/2] mbuf: add a sanity check on segment metadata",
    "commit_ref": null,
    "pull_url": null,
    "state": "rfc",
    "archived": true,
    "hash": "165bf38a30189dee58df241477ca5050acb4f50b",
    "submitter": {
        "id": 3,
        "url": "http://patchwork.dpdk.org/api/people/3/?format=api",
        "name": "David Marchand",
        "email": "david.marchand@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1534176226-21911-1-git-send-email-david.marchand@6wind.com/mbox/",
    "series": [
        {
            "id": 974,
            "url": "http://patchwork.dpdk.org/api/series/974/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=974",
            "date": "2018-08-13T16:03:45",
            "name": "[RFC,1/2] mbuf: add a sanity check on segment metadata",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/974/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/43696/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/43696/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A80B837A2;\n\tMon, 13 Aug 2018 18:04:26 +0200 (CEST)",
            "from mail-wm0-f65.google.com (mail-wm0-f65.google.com\n\t[74.125.82.65]) by dpdk.org (Postfix) with ESMTP id 9959A10A3\n\tfor <dev@dpdk.org>; Mon, 13 Aug 2018 18:04:25 +0200 (CEST)",
            "by mail-wm0-f65.google.com with SMTP id i134-v6so806409wmf.0\n\tfor <dev@dpdk.org>; Mon, 13 Aug 2018 09:04:25 -0700 (PDT)",
            "from 6wind.com (host.78.145.23.62.rev.coltfrance.com.\n\t[62.23.145.78]) by smtp.gmail.com with ESMTPSA id\n\tm207-v6sm10613247wma.31.2018.08.13.09.04.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 13 Aug 2018 09:04:24 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=vL1TzIqTe1LAOJkHIuM54CcHasjpoqL1GCaSc7X86FQ=;\n\tb=N0cGte2bjjCCSdVj4CYJaXc88nwc1lRIdf8Km2JDa3DmEl+LIT1YjXYNLDeywNabBm\n\t41uir7G3eTpDrT01zBxmz4Vgxi2mj7Oc6GV9zBE854pN8WsL3/l73PVdgIoDFG9tKWX4\n\tYGzMZjwzOcJlNVbIXDWM0nn2vJZeOHhHNkf+O9Ojcn16uPYKXGgpIRsvzLun1+iKoq0/\n\tnVLQSzPlUa2niZYQTnfwi/kHuakKbUZDcFv9uJXjxxL628j9NsjCeN4ZgpHKGM8QHECa\n\tZJ2j3EoolSI6/i3Std08nMQ5FqFL0qYZMsVdYbsbBCbIr2SOAJUdwLAT6+0N1mRywhpu\n\t1eRA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=vL1TzIqTe1LAOJkHIuM54CcHasjpoqL1GCaSc7X86FQ=;\n\tb=sXUPkJULhUU9qMxtWDjwkMntUUgCd4N5eKZdr0CCSsnvvrPKQfBBYGgf4t/vhQ6TKR\n\tHoos4TfAqVEMkl+4kMzf8ghMmtiFJ+Heo+zSdEJN1phcVrcmKLojIjL8m1A4nV3aRvVK\n\t0w3sQmWiGHbarfsgI1d0lgtMgPKgwUPFUSwLZ1seCwel8HfYs11G34F+NV0yp35UBdP6\n\tOZy8ZTVRKztZXiMR8PlRuEnCUyFPKB7uiq9Z+KSDpt06nrlv2OWq4Kmr8SaKN6oarabM\n\tejRTAHWpOBYeggw5KVPXqpXbYOZrHeREZWHMj+9RjVStLkFjbjeyfKgy5KcuyPequqPV\n\tmjaA==",
        "X-Gm-Message-State": "AOUpUlHkrEdfbqyQNRwcrUZ5lo9bPmqw9KfNrLdgyk46axyETHRkm/Pt\n\tld5GdbKkC+aKKnSt/lBpprehCwAsW9w=",
        "X-Google-Smtp-Source": "AA+uWPzbTXNUV16A7VtpXd2rMXhu+eeRqkvlk94yFlS2bZZOjnX6XPf6tE+dalrRfm3Hp4Vnlc//mA==",
        "X-Received": "by 2002:a1c:202:: with SMTP id 2-v6mr8134097wmc.91.1534176265012;\n\tMon, 13 Aug 2018 09:04:25 -0700 (PDT)",
        "From": "David Marchand <david.marchand@6wind.com>",
        "To": "dev@dpdk.org",
        "Cc": "Thomas Monjalon <thomas@monjalon.net>,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>,\n\tOlivier Matz <olivier.matz@6wind.com>",
        "Date": "Mon, 13 Aug 2018 18:03:45 +0200",
        "Message-Id": "<1534176226-21911-1-git-send-email-david.marchand@6wind.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [RFC 1/2] mbuf: add a sanity check on segment metadata",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Add some basic check on the segments offset and length metadata:\nalways funny to have a < 0 tailroom cast to uint16_t ;-).\n\nSigned-off-by: David Marchand <david.marchand@6wind.com>\n---\n lib/librte_mbuf/rte_mbuf.c | 2 ++\n 1 file changed, 2 insertions(+)",
    "diff": "diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c\nindex e714c5a..7eeef12 100644\n--- a/lib/librte_mbuf/rte_mbuf.c\n+++ b/lib/librte_mbuf/rte_mbuf.c\n@@ -200,6 +200,8 @@ rte_mbuf_sanity_check(const struct rte_mbuf *m, int is_header)\n \tpkt_len = m->pkt_len;\n \n \tdo {\n+\t\tif (m->data_off + m->data_len > m->buf_len)\n+\t\t\trte_panic(\"bad segment metadata\\n\");\n \t\tnb_segs -= 1;\n \t\tpkt_len -= m->data_len;\n \t} while ((m = m->next) != NULL);\n",
    "prefixes": [
        "RFC",
        "1/2"
    ]
}