Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43701/?format=api
{ "id": 43701, "url": "http://patchwork.dpdk.org/api/patches/43701/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180814003848.11095-3-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180814003848.11095-3-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180814003848.11095-3-pablo.de.lara.guarch@intel.com", "date": "2018-08-14T00:38:45", "name": "[2/5] crypto/aesni_mb: check for invalid digest size", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ae5886bcb27cc2e50a7a1c1e7656f6c415eaab0c", "submitter": { "id": 9, "url": "http://patchwork.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180814003848.11095-3-pablo.de.lara.guarch@intel.com/mbox/", "series": [ { "id": 976, "url": "http://patchwork.dpdk.org/api/series/976/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=976", "date": "2018-08-14T00:38:43", "name": "AESNI MB PMD changes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/976/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43701/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43701/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 33BA44C88;\n\tTue, 14 Aug 2018 10:45:22 +0200 (CEST)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id AD2692B83\n\tfor <dev@dpdk.org>; Tue, 14 Aug 2018 10:45:17 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Aug 2018 01:45:16 -0700", "from silpixa00399466.ir.intel.com (HELO\n\tsilpixa00399466.ger.corp.intel.com) ([10.237.223.220])\n\tby orsmga004.jf.intel.com with ESMTP; 14 Aug 2018 01:45:15 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,237,1531810800\"; d=\"scan'208\";a=\"224482032\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "declan.doherty@intel.com", "Cc": "dev@dpdk.org,\n\tPablo de Lara <pablo.de.lara.guarch@intel.com>", "Date": "Tue, 14 Aug 2018 01:38:45 +0100", "Message-Id": "<20180814003848.11095-3-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20180814003848.11095-1-pablo.de.lara.guarch@intel.com>", "References": "<20180814003848.11095-1-pablo.de.lara.guarch@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/5] crypto/aesni_mb: check for invalid digest\n\tsize", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When creating a crypto session, check if\nther requested digest size is supported for\nAES-XCBC-MAC and AES-CCM.\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 16 ++++++++++++++++\n 1 file changed, 16 insertions(+)", "diff": "diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\nindex 6fbfab8b8..54dcf7787 100644\n--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c\n@@ -14,6 +14,9 @@\n \n #include \"rte_aesni_mb_pmd_private.h\"\n \n+#define AES_CCM_DIGEST_MIN_LEN 4\n+#define AES_CCM_DIGEST_MAX_LEN 16\n+\n static uint8_t cryptodev_driver_id;\n \n typedef void (*hash_one_block_t)(const void *data, void *digest);\n@@ -122,6 +125,12 @@ aesni_mb_set_session_auth_parameters(const struct aesni_mb_op_fns *mb_ops,\n \tif (xform->auth.algo == RTE_CRYPTO_AUTH_AES_XCBC_MAC) {\n \t\tsess->auth.algo = AES_XCBC;\n \n+\t\tuint16_t xcbc_mac_digest_len =\n+\t\t\tget_truncated_digest_byte_length(AES_XCBC);\n+\t\tif (sess->auth.req_digest_len != xcbc_mac_digest_len) {\n+\t\t\tAESNI_MB_LOG(ERR, \"Invalid digest size\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tsess->auth.gen_digest_len = sess->auth.req_digest_len;\n \t\t(*mb_ops->aux.keyexp.aes_xcbc)(xform->auth.key.data,\n \t\t\t\tsess->auth.xcbc.k1_expanded,\n@@ -387,6 +396,13 @@ aesni_mb_set_session_aead_parameters(const struct aesni_mb_op_fns *mb_ops,\n \tsess->iv.length = xform->aead.iv.length;\n \n \tsess->auth.req_digest_len = xform->aead.digest_length;\n+\t/* CCM digests must be between 4 and 16 and an even number */\n+\tif (sess->auth.req_digest_len < AES_CCM_DIGEST_MIN_LEN ||\n+\t\t\tsess->auth.req_digest_len > AES_CCM_DIGEST_MAX_LEN ||\n+\t\t\t(sess->auth.req_digest_len & 1) == 1) {\n+\t\tAESNI_MB_LOG(ERR, \"Invalid digest size\\n\");\n+\t\treturn -EINVAL;\n+\t}\n \tsess->auth.gen_digest_len = sess->auth.req_digest_len;\n \n \t/* Check key length and choose key expansion function for AES */\n", "prefixes": [ "2/5" ] }