Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43716/?format=api
{ "id": 43716, "url": "http://patchwork.dpdk.org/api/patches/43716/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20180815145439.2513-1-i.maximets@samsung.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20180815145439.2513-1-i.maximets@samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20180815145439.2513-1-i.maximets@samsung.com", "date": "2018-08-15T14:54:39", "name": "vhost: fix zmbufs array leak after NUMA realloc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "137363bccbabc173d5a77e7ec9c85631e5a05559", "submitter": { "id": 323, "url": "http://patchwork.dpdk.org/api/people/323/?format=api", "name": "Ilya Maximets", "email": "i.maximets@samsung.com" }, "delegate": { "id": 2642, "url": "http://patchwork.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20180815145439.2513-1-i.maximets@samsung.com/mbox/", "series": [ { "id": 987, "url": "http://patchwork.dpdk.org/api/series/987/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=987", "date": "2018-08-15T14:54:39", "name": "vhost: fix zmbufs array leak after NUMA realloc", "version": 1, "mbox": "http://patchwork.dpdk.org/series/987/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43716/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 801E53250;\n\tWed, 15 Aug 2018 16:53:45 +0200 (CEST)", "from mailout1.w1.samsung.com (mailout1.w1.samsung.com\n\t[210.118.77.11]) by dpdk.org (Postfix) with ESMTP id E569D2BAF;\n\tWed, 15 Aug 2018 16:53:43 +0200 (CEST)", "from eucas1p1.samsung.com (unknown [182.198.249.206])\n\tby mailout1.w1.samsung.com (KnoxPortal) with ESMTP id\n\t20180815145342euoutp01e8865c5ef7a690807b5f658b91d15266~LFnyxrrmP0898308983euoutp01K;\n\tWed, 15 Aug 2018 14:53:42 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n\teucas1p2.samsung.com (KnoxPortal) with ESMTP id\n\t20180815145342eucas1p267d6fab56e064474e9a0e705e867ec51~LFnyX8w_b0609406094eucas1p2j;\n\tWed, 15 Aug 2018 14:53:42 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n\teusmges2new.samsung.com (EUCPMTA) with SMTP id 4D.88.04294.67E347B5;\n\tWed, 15 Aug 2018 15:53:42 +0100 (BST)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n\teucas1p1.samsung.com (KnoxPortal) with ESMTP id\n\t20180815145341eucas1p15832e119a9d6f3fc54796675a283c44f~LFnxnA2os0902609026eucas1p15;\n\tWed, 15 Aug 2018 14:53:41 +0000 (GMT)", "from eusync1.samsung.com ( [203.254.199.211]) by\n\teusmgms2.samsung.com (EUCPMTA) with SMTP id 0F.1F.04128.57E347B5;\n\tWed, 15 Aug 2018 15:53:41 +0100 (BST)", "from imaximets.rnd.samsung.ru ([106.109.129.180]) by\n\teusync1.samsung.com (Oracle Communications Messaging Server\n\t7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id\n\t<0PDI00IDQC1EJR40@eusync1.samsung.com>; \n\tWed, 15 Aug 2018 15:53:41 +0100 (BST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com\n\t20180815145342euoutp01e8865c5ef7a690807b5f658b91d15266~LFnyxrrmP0898308983euoutp01K", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n\ts=mail20170921; t=1534344822;\n\tbh=bQRyuSgQulcYlWc22hFxoCgIDr8iv6xOD/lyHjAZisg=;\n\th=From:To:Cc:Subject:Date:References:From;\n\tb=dKR2Q9o3vqLlMCqqIV1ViXcrvmC/+bfWFD5HRtnsqwWD0ffuels9gwpHKNn7CmHKk\n\t6ZRG56MrbxGqFmEXt1AsmpjCwVsAUTDIr75rwe+0W3/L9tZEKH/0Puz5IogK04l23Y\n\tWyAJRFCbzOHdExkg2kKEP+LLui3Njmot0n/wboXs=", "X-AuditID": "cbfec7f4-84fff700000010c6-ab-5b743e7673fe", "From": "Ilya Maximets <i.maximets@samsung.com>", "To": "dev@dpdk.org", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>, Tiwei Bie\n\t<tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, Junjie Chen\n\t<junjie.j.chen@intel.com>, Ilya Maximets <i.maximets@samsung.com>,\n\tstable@dpdk.org", "Date": "Wed, 15 Aug 2018 17:54:39 +0300", "Message-id": "<20180815145439.2513-1-i.maximets@samsung.com>", "X-Mailer": "git-send-email 2.17.1", "X-Brightmail-Tracker": [ "H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsWy7djP87pldiXRBk+Ocli8+7SdyeJK+092\n\ti7NHHzNaHOvcw2Lxr+MPu8XWhv9MFpsvTmJyYPf4tWApq8fiPS+ZPN7vu8rm0bdlFWMASxSX\n\tTUpqTmZZapG+XQJXxqKJpgUbOCtmNvSxNzDeYO9i5OSQEDCRuH5iH0sXIxeHkMAKRokHe2Yw\n\tQzifGSX+LfzCAlN1b88fRojEMkaJR6s2sIEkhASamST+7OUEsdkEdCROrT7CCGKLCAhIfO5c\n\tzAbSwCxwj1Fi/ZGnTCAJYQEHibY9T8GmsgioSnSf/c0MYvMKWElM7fzFDLFNXmL1hgNgZ0gI\n\tPGWV+L+ilQ0i4SJx9EkTI4QtLPHq+BaoJ2QkLk/uhjq1XuJ+y0tGiOYORonph/4xQSTsJba8\n\tPgfWwCzAJzFp23SgDRxAcV6JjjYhiBIPiVUPvjJDfBYrcfTuZsYJjBILGBlWMYqnlhbnpqcW\n\tG+WllusVJ+YWl+al6yXn525iBMbX6X/Hv+xg3PUn6RCjAAejEg/vA8OSaCHWxLLiytxDjBIc\n\tzEoivGp8QCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8fFpp0UIC6YklqdmpqQWpRTBZJg5OqQZG\n\t9TUccT/SxLa23XMu93rcwWecMLe1aI/Nmrlzo5+t13bO4v8ptXKW2O4XYj4X2/9FlM3KXNrx\n\t7DDbmnMd+/xZp/LtMtL89TjN+n13yfFXIpErncLmuO5dYCpye2fg1eZjq84smfi7Nu9E7M7J\n\tJY+Y3k/vTOs5sGqv1A2j3fxJEoG73BcEC92SVmIpzkg01GIuKk4EAOJgJlarAgAA", "H4sIAAAAAAAAA+NgFnrNJMWRmVeSWpSXmKPExsVy+t/xy7qldiXRBnv7lS3efdrOZHGl/Se7\n\txdmjjxktjnXuYbH41/GH3WJrw38mi80XJzE5sHv8WrCU1WPxnpdMHu/3XWXz6NuyijGAJYrL\n\tJiU1J7MstUjfLoErY9FE04INnBUzG/rYGxhvsHcxcnJICJhI3Nvzh7GLkYtDSGAJo8SCvy9Y\n\tIJxWJom//5qZQarYBHQkTq0+wghiiwgISHzuXMwGUsQscI9RYt2kJlaQhLCAg0TbnqcsIDaL\n\tgKpE99nfYM28AlYSUzt/MUOsk5dYveEA8wRGrgWMDKsYRVJLi3PTc4uN9IoTc4tL89L1kvNz\n\tNzECg2DbsZ9bdjB2vQs+xCjAwajEw/vAsCRaiDWxrLgy9xCjBAezkgivGh9QiDclsbIqtSg/\n\tvqg0J7X4EKM0B4uSOO95g8ooIYH0xJLU7NTUgtQimCwTB6dUA2N9HJvDbT9zI2X9N1+qH/ut\n\tuZ4kliM/yeKeHbfuhW+T13P9PpPt91ddKFfxYPeHiIUdT0OUQ5U+9L3Q+N6iM99n6r7ICfrr\n\tbbpUS0P/ZsXGeNqe6F/I5Pf67Ju+r13JCxmYNp/4sbHninLPo5chH6YJtfEqvFf3+F3JscYw\n\tl3fpjFDvM0vfbVJiKc5INNRiLipOBACkTxCT/gEAAA==" ], "X-CMS-MailID": "20180815145341eucas1p15832e119a9d6f3fc54796675a283c44f", "X-Msg-Generator": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20180815145341eucas1p15832e119a9d6f3fc54796675a283c44f", "References": "<CGME20180815145341eucas1p15832e119a9d6f3fc54796675a283c44f@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH] vhost: fix zmbufs array leak after NUMA realloc", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "'numa_realloc()' allocates 'zmbufs' even if zero copy mode\nis not configured. This leads to memory leak, because array\nis freed only for zero copy case.\n\nFixes: 2651726defb7 (\"vhost: do deep copy while reallocating queue\")\nCC: stable@dpdk.org\n\nSigned-off-by: Ilya Maximets <i.maximets@samsung.com>\n---\n lib/librte_vhost/vhost_user.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex a2d4c9ffc..9aa1ce118 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -357,11 +357,13 @@ numa_realloc(struct virtio_net *dev, int index)\n \t\tmemcpy(vq, old_vq, sizeof(*vq));\n \t\tTAILQ_INIT(&vq->zmbuf_list);\n \n-\t\tnew_zmbuf = rte_malloc_socket(NULL, vq->zmbuf_size *\n-\t\t\tsizeof(struct zcopy_mbuf), 0, newnode);\n-\t\tif (new_zmbuf) {\n-\t\t\trte_free(vq->zmbufs);\n-\t\t\tvq->zmbufs = new_zmbuf;\n+\t\tif (dev->dequeue_zero_copy) {\n+\t\t\tnew_zmbuf = rte_malloc_socket(NULL, vq->zmbuf_size *\n+\t\t\t\t\tsizeof(struct zcopy_mbuf), 0, newnode);\n+\t\t\tif (new_zmbuf) {\n+\t\t\t\trte_free(vq->zmbufs);\n+\t\t\t\tvq->zmbufs = new_zmbuf;\n+\t\t\t}\n \t\t}\n \n \t\tif (vq_is_packed(dev)) {\n", "prefixes": [] }