Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 43814,
    "url": "http://patchwork.dpdk.org/api/patches/43814/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1535026093-101872-5-git-send-email-ciara.power@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1535026093-101872-5-git-send-email-ciara.power@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1535026093-101872-5-git-send-email-ciara.power@intel.com",
    "date": "2018-08-23T12:08:06",
    "name": "[04/11] telemetry: add parser for client socket messages",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "59feb9bbe9a90ee721dd40dbcfb9e7824bafb2af",
    "submitter": {
        "id": 978,
        "url": "http://patchwork.dpdk.org/api/people/978/?format=api",
        "name": "Power, Ciara",
        "email": "ciara.power@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1535026093-101872-5-git-send-email-ciara.power@intel.com/mbox/",
    "series": [
        {
            "id": 1038,
            "url": "http://patchwork.dpdk.org/api/series/1038/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1038",
            "date": "2018-08-23T12:08:02",
            "name": "introduce telemetry library",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/1038/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/43814/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/43814/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1C0534CBB;\n\tThu, 23 Aug 2018 14:08:36 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 8F7F04C9C\n\tfor <dev@dpdk.org>; Thu, 23 Aug 2018 14:08:30 +0200 (CEST)",
            "from fmsmga005.fm.intel.com ([10.253.24.32])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Aug 2018 05:08:30 -0700",
            "from silpixa00399503.ir.intel.com ([10.237.222.102])\n\tby fmsmga005.fm.intel.com with ESMTP; 23 Aug 2018 05:08:28 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.53,278,1531810800\"; d=\"scan'208\";a=\"256613847\"",
        "From": "Ciara Power <ciara.power@intel.com>",
        "To": "harry.van.haaren@intel.com, brian.archbold@intel.com,\n\temma.kenny@intel.com, ciara.power@intel.com",
        "Cc": "dev@dpdk.org",
        "Date": "Thu, 23 Aug 2018 13:08:06 +0100",
        "Message-Id": "<1535026093-101872-5-git-send-email-ciara.power@intel.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "In-Reply-To": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>",
        "References": "<1535026093-101872-1-git-send-email-ciara.power@intel.com>",
        "Subject": "[dpdk-dev] [PATCH 04/11] telemetry: add parser for client socket\n\tmessages",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch adds the parser file. This is used to parse any\nmessages that are received on any of the client sockets.\n\nCurrently, the unregister functionality works using the parser.\nFunctionality relating to getting statistic values for certain ports\nwill be added in a subsequent patch, however the parsing involved\nfor that command is added in this patch.\n\nSome of the parser code included is in preparation for future\nfunctionality, that is not implemented yet in this patchset.\n\nSigned-off-by: Ciara Power <ciara.power@intel.com>\nSigned-off-by: Brian Archbold <brian.archbold@intel.com>\n---\n lib/librte_telemetry/Makefile                 |   1 +\n lib/librte_telemetry/meson.build              |   4 +-\n lib/librte_telemetry/rte_telemetry.c          |   9 +\n lib/librte_telemetry/rte_telemetry_internal.h |   3 +\n lib/librte_telemetry/rte_telemetry_parser.c   | 585 ++++++++++++++++++++++++++\n lib/librte_telemetry/rte_telemetry_parser.h   |  13 +\n 6 files changed, 613 insertions(+), 2 deletions(-)\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser.c\n create mode 100644 lib/librte_telemetry/rte_telemetry_parser.h",
    "diff": "diff --git a/lib/librte_telemetry/Makefile b/lib/librte_telemetry/Makefile\nindex bda3788..df8fdd9 100644\n--- a/lib/librte_telemetry/Makefile\n+++ b/lib/librte_telemetry/Makefile\n@@ -19,6 +19,7 @@ LIBABIVER := 1\n \n # library source files\n SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) := rte_telemetry.c\n+SRCS-$(CONFIG_RTE_LIBRTE_TELEMETRY) += rte_telemetry_parser.c\n \n # export include files\n SYMLINK-$(CONFIG_RTE_LIBRTE_TELEMETRY)-include := rte_telemetry.h\ndiff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build\nindex 0ccfa36..7450f96 100644\n--- a/lib/librte_telemetry/meson.build\n+++ b/lib/librte_telemetry/meson.build\n@@ -1,8 +1,8 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Intel Corporation\n \n-sources = files('rte_telemetry.c')\n-headers = files('rte_telemetry.h', 'rte_telemetry_internal.h')\n+sources = files('rte_telemetry.c', 'rte_telemetry_parser.c')\n+headers = files('rte_telemetry.h', 'rte_telemetry_internal.h', 'rte_telemetry_parser.h')\n deps += ['metrics', 'ethdev']\n cflags += '-DALLOW_EXPERIMENTAL_API'\n jansson = cc.find_library('jansson', required: true)\ndiff --git a/lib/librte_telemetry/rte_telemetry.c b/lib/librte_telemetry/rte_telemetry.c\nindex e9dd022..c6c6612 100644\n--- a/lib/librte_telemetry/rte_telemetry.c\n+++ b/lib/librte_telemetry/rte_telemetry.c\n@@ -15,6 +15,7 @@\n \n #include \"rte_telemetry.h\"\n #include \"rte_telemetry_internal.h\"\n+#include \"rte_telemetry_parser.h\"\n \n #define BUF_SIZE 1024\n #define ACTION_POST 1\n@@ -272,6 +273,8 @@ rte_telemetry_accept_new_client(struct telemetry_impl *telemetry)\n static int32_t\n rte_telemetry_read_client_sockets(struct telemetry_impl *telemetry)\n {\n+\tint ret;\n+\n \ttelemetry_client *client;\n \tTAILQ_FOREACH(client, &telemetry->client_list_head, client_list) {\n \t\tchar client_buf[BUF_SIZE];\n@@ -279,6 +282,12 @@ rte_telemetry_read_client_sockets(struct telemetry_impl *telemetry)\n \t\tclient_buf[bytes] = '\\0';\n \t\tif (bytes > 0) {\n \t\t\ttelemetry->request_client = client;\n+\t\t\tret = rte_telemetry_parse(telemetry, client_buf);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tTELEMETRY_LOG_WARN(\"Warning - Parse socket \"\n+\t\t\t\t\t\"input failed: %i\\n\", ret);\n+\t\t\t\treturn -1;\n+\t\t\t}\n \t\t}\n \t}\n \treturn 0;\ndiff --git a/lib/librte_telemetry/rte_telemetry_internal.h b/lib/librte_telemetry/rte_telemetry_internal.h\nindex e3292cf..b057794 100644\n--- a/lib/librte_telemetry/rte_telemetry_internal.h\n+++ b/lib/librte_telemetry/rte_telemetry_internal.h\n@@ -58,4 +58,7 @@ int32_t\n rte_telemetry_unregister_client(struct telemetry_impl *telemetry,\n \tconst char *client_path);\n \n+int32_t\n+rte_telemetry_check_port_activity(int port_id);\n+\n #endif\ndiff --git a/lib/librte_telemetry/rte_telemetry_parser.c b/lib/librte_telemetry/rte_telemetry_parser.c\nnew file mode 100644\nindex 0000000..571c991\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry_parser.c\n@@ -0,0 +1,585 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include <stdio.h>\n+#include <stdint.h>\n+#include <string.h>\n+#include <errno.h>\n+#include <jansson.h>\n+\n+#include <rte_metrics.h>\n+#include <rte_common.h>\n+#include <rte_ethdev.h>\n+\n+#include \"rte_telemetry_internal.h\"\n+\n+#define ACTION_GET 0\n+#define ACTION_DELETE 2\n+\n+struct command {\n+\tchar *command_text;\n+\tint (*comm_func_ptr)(struct telemetry_impl *, int, json_t *);\n+} command;\n+\n+static int32_t\n+rte_telemetry_command_clients(struct telemetry_impl *telemetry, int action,\n+\tjson_t *data)\n+{\n+\tint ret;\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (action != ACTION_DELETE) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this \"\n+\t\t\t\"command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tif (!json_is_object(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid data provided for this \"\n+\t\t\t\"command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tjson_t *client_path = json_object_get(data, \"client_path\");\n+\tif (!json_is_string(client_path)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Command value is not a string\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tconst char *client_path_string = json_string_value(client_path);\n+\n+\tret = rte_telemetry_unregister_client(telemetry, client_path_string);\n+\tif (ret < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - could not unregister client\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\treturn 0;\n+\n+einval_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+}\n+\n+static int32_t\n+rte_telemetry_command_ports(struct telemetry_impl *telemetry, int action,\n+\tjson_t *data)\n+{\n+\tint ret;\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (!json_is_null(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Data should be NULL JSON object \"\n+\t\t\t\"for 'ports' command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tif (action != ACTION_GET) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this \"\n+\t\t\t\"command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\treturn 0;\n+\n+einval_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+}\n+\n+static int32_t\n+rte_telemetry_command_ports_details(struct telemetry_impl *telemetry,\n+\tint action, json_t *data)\n+{\n+\tint ret;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (action != ACTION_GET) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this \"\n+\t\t\t\"command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (!json_is_object(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid data provided for this \"\n+\t\t\t\"command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tjson_t *port_ids_json = json_object_get(data, \"ports\");\n+\tif (!json_is_array(port_ids_json)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid Port ID array\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tuint64_t num_port_ids = json_array_size(port_ids_json);\n+\tint port_ids[num_port_ids];\n+\tRTE_SET_USED(port_ids);\n+\tsize_t index;\n+\tjson_t *value;\n+\n+\tjson_array_foreach(port_ids_json, index, value) {\n+\t\tif (!json_is_integer(value)) {\n+\t\t\tTELEMETRY_LOG_WARN(\"Warning - Port ID given is \"\n+\t\t\t\t\"invalid\\n\");\n+\t\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t\t-EINVAL);\n+\t\t\tif (ret < 0)\n+\t\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send \"\n+\t\t\t\t\t\"error\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tport_ids[index] = json_integer_value(value);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int32_t\n+rte_telemetry_command_port_stats(struct telemetry_impl *telemetry, int action,\n+\tjson_t *data)\n+{\n+\tint ret;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (!json_is_null(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Data should be NULL JSON object \"\n+\t\t\t\"for 'port_stats' command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tif (action != ACTION_GET) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this \"\n+\t\t\t\"command\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\treturn 0;\n+\n+einval_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+}\n+\n+static int32_t\n+rte_telemetry_stat_names_to_ids(struct telemetry_impl *telemetry,\n+\tconst char * const *stat_names, uint32_t *stat_ids,\n+\tuint64_t num_stat_names)\n+{\n+\tstruct rte_metric_name *names;\n+\tint ret;\n+\n+\tif (stat_names == NULL) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid stat_names argument\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tif (num_stat_names <= 0) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid num_stat_names \"\n+\t\t\t\"argument\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tint num_metrics = rte_metrics_get_names(NULL, 0);\n+\tif (num_metrics < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Cannot get metrics count\\n\");\n+\t\tgoto eperm_fail;\n+\t} else if (num_metrics == 0) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - No metrics have been \"\n+\t\t\t\"registered\\n\");\n+\t\tgoto eperm_fail;\n+\t}\n+\n+\tnames = malloc(sizeof(struct rte_metric_name) * num_metrics);\n+\tif (names == NULL) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Cannot allocate memory for names\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -ENOMEM);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_metrics_get_names(names, num_metrics);\n+\tif (ret < 0 || ret > num_metrics) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Cannot get metrics names\\n\");\n+\t\tfree(names);\n+\t\tgoto eperm_fail;\n+\t}\n+\n+\tuint32_t i, k;\n+\tk = 0;\n+\tfor (i = 0; i < (uint32_t)num_stat_names; i++) {\n+\t\tuint32_t j;\n+\t\tfor (j = 0; j < (uint32_t)num_metrics; j++) {\n+\t\t\tif (strcmp(stat_names[i], names[j].name) == 0) {\n+\t\t\t\tstat_ids[k] = j;\n+\t\t\t\tk++;\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\tif (k != num_stat_names) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid stat names provided\\n\");\n+\t\tfree(names);\n+\t\tgoto einval_fail;\n+\t}\n+\n+\treturn 0;\n+\n+einval_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+\n+eperm_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EPERM);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+}\n+\n+int32_t\n+rte_telemetry_command_ports_all_stat_values(struct telemetry_impl *telemetry,\n+\t int action, json_t *data)\n+{\n+\tint ret, num_metrics;\n+\tstruct rte_metric_name *names;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (action != ACTION_GET) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (json_is_object(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid data provided for this command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tnum_metrics = rte_metrics_get_names(NULL, 0);\n+\tif (num_metrics < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Cannot get metrics count\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t} else if (num_metrics == 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - No metrics to display (none have been registered)\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EPERM);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tnames = malloc(sizeof(struct rte_metric_name) * num_metrics);\n+\tif (!names) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Cannot allocate memory\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t -ENOMEM);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tuint64_t num_port_ids = 0;\n+\tconst char *stat_names[num_metrics];\n+\tuint32_t stat_ids[num_metrics];\n+\tint p;\n+\n+\tRTE_ETH_FOREACH_DEV(p) {\n+\t\tnum_port_ids++;\n+\t}\n+\tif (!num_port_ids) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - No active ports\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t-EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\tgoto fail;\n+\t}\n+\n+\tret = rte_metrics_get_names(names, num_metrics);\n+\tint i;\n+\tfor (i = 0; i < num_metrics; i++)\n+\t\tstat_names[i] = names[i].name;\n+\n+\tret = rte_telemetry_stat_names_to_ids(telemetry, stat_names, stat_ids,\n+\t\tnum_metrics);\n+\tif (ret < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not convert stat names to IDs\\n\");\n+\t\tgoto fail;\n+\t}\n+\treturn 0;\n+\n+fail:\n+\tfree(names);\n+\treturn -1;\n+}\n+\n+int32_t\n+rte_telemetry_command_ports_stats_values_by_name(struct telemetry_impl\n+\t*telemetry, int action, json_t *data)\n+{\n+\tint ret;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (action != ACTION_GET) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action for this \"\n+\t\t\t\"command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (!json_is_object(data)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid data provided for this \"\n+\t\t\t\"command\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tjson_t *port_ids_json = json_object_get(data, \"ports\");\n+\tjson_t *stat_names_json = json_object_get(data, \"stats\");\n+\tif (!json_is_array(port_ids_json) ||\n+\t\t !json_is_array(stat_names_json)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid input data array(s)\\n\");\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tuint64_t num_port_ids = json_array_size(port_ids_json);\n+\tuint32_t port_ids[num_port_ids];\n+\tsize_t index;\n+\tjson_t *value;\n+\n+\tjson_array_foreach(port_ids_json, index, value) {\n+\t\tif (!json_is_integer(value)) {\n+\t\t\tTELEMETRY_LOG_WARN(\"Warning - Port ID given is not \"\n+\t\t\t\t\"valid\\n\");\n+\t\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t\t-EINVAL);\n+\t\t\tif (ret < 0)\n+\t\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send \"\n+\t\t\t\t\t\"error\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tport_ids[index] = json_integer_value(value);\n+\t\tret = rte_telemetry_check_port_activity(port_ids[index]);\n+\t\tif (ret < 1) {\n+\t\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t\t-EINVAL);\n+\t\t\tif (ret < 0)\n+\t\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send \"\n+\t\t\t\t\"error\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n+\n+\tuint64_t num_stat_names = json_array_size(stat_names_json);\n+\tconst char *stat_names[num_stat_names];\n+\n+\tjson_array_foreach(stat_names_json, index, value) {\n+\t\tif (!json_is_string(value)) {\n+\t\t\tTELEMETRY_LOG_WARN(\"Warning - Stat Name given is not a \"\n+\t\t\t\t\"string\\n\");\n+\t\t\tret = rte_telemetry_send_error_response(telemetry,\n+\t\t\t\t-EINVAL);\n+\t\t\tif (ret < 0)\n+\t\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send \"\n+\t\t\t\t\t\"error\\n\");\n+\t\t\treturn -1;\n+\t\t}\n+\t\tstat_names[index] = json_string_value(value);\n+\t}\n+\n+\tuint32_t stat_ids[num_stat_names];\n+\tret = rte_telemetry_stat_names_to_ids(telemetry, stat_names, stat_ids,\n+\t\tnum_stat_names);\n+\tif (ret < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not convert stat names to \"\n+\t\t\t\"IDs\\n\");\n+\t\treturn -1;\n+\t}\n+\treturn 0;\n+}\n+\n+static int32_t\n+rte_telemetry_parse_command(struct telemetry_impl *telemetry, int action,\n+\tconst char *command, json_t *data)\n+{\n+\tint ret;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tstruct command commands[] = {\n+\t\t{.command_text = \"clients\",\n+\t\t\t .comm_func_ptr = &rte_telemetry_command_clients},\n+\t\t{.command_text = \"ports\",\n+\t\t\t .comm_func_ptr = &rte_telemetry_command_ports},\n+\t\t{.command_text = \"ports_details\",\n+\t\t\t .comm_func_ptr = &rte_telemetry_command_ports_details},\n+\t\t{.command_text = \"port_stats\",\n+\t\t\t .comm_func_ptr = &rte_telemetry_command_port_stats},\n+\t\t{.command_text = \"ports_stats_values_by_name\",\n+\t\t\t .comm_func_ptr =\n+\t\t\t &rte_telemetry_command_ports_stats_values_by_name},\n+\t\t{.command_text = \"ports_all_stat_values\",\n+\t\t\t .comm_func_ptr =\n+\t\t\t &rte_telemetry_command_ports_all_stat_values}\n+\t};\n+\n+\tconst uint32_t num_commands = sizeof(commands)/sizeof(struct command);\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < num_commands; i++) {\n+\t\tif (strcmp(command, commands[i].command_text) == 0) {\n+\t\t\tint ret = commands[i].comm_func_ptr(telemetry, action,\n+\t\t\t\tdata);\n+\t\t\tif (ret < 0) {\n+\t\t\t\tTELEMETRY_LOG_ERR(\"Error - Command Function \"\n+\t\t\t\t\t\"for %s failed\\n\",\n+\t\t\t\t\tcommands[i].command_text);\n+\t\t\t\treturn -1;\n+\t\t\t}\n+\t\t\treturn 0;\n+\t\t}\n+\t}\n+\tTELEMETRY_LOG_WARN(\"Warning - \\\"%s\\\" command not found\\n\", command);\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0)\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\treturn -1;\n+}\n+\n+int32_t\n+rte_telemetry_parse(struct telemetry_impl *telemetry, char *socket_rx_data)\n+{\n+\tint ret;\n+\n+\tif (!telemetry) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Invalid telemetry argument\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tjson_error_t error;\n+\tjson_t *root = json_loads(socket_rx_data, 0, &error);\n+\tif (!root) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Could not load JSON object from \"\n+\t\t\t\"data passed in : %s\\n\", error.text);\n+\t\tret = rte_telemetry_send_error_response(telemetry, -EPERM);\n+\t\tif (ret < 0)\n+\t\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -EPERM;\n+\t} else if (!json_is_object(root)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - JSON Request is not a JSON \"\n+\t\t\t\"object\\n\");\n+\t\tjson_decref(root);\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tjson_t *action = json_object_get(root, \"action\");\n+\tif (!action) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Request does not have action \"\n+\t\t\t\"field\\n\");\n+\t\tgoto einval_fail;\n+\t} else if (!json_is_integer(action)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Action value is not an \"\n+\t\t\t\"integer\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tjson_t *command = json_object_get(root, \"command\");\n+\tif (!command) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Request does not have command \"\n+\t\t\t\"field\\n\");\n+\t\tgoto einval_fail;\n+\t} else if (!json_is_string(command)) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Command value is not a string\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tint action_int = json_integer_value(action);\n+\tif (action_int != ACTION_GET && action_int != ACTION_DELETE) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Invalid action code\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tconst char *command_string = json_string_value(command);\n+\tjson_t *data = json_object_get(root, \"data\");\n+\tif (!data) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Request does not have data \"\n+\t\t\t\"field\\n\");\n+\t\tgoto einval_fail;\n+\t}\n+\n+\tret = rte_telemetry_parse_command(telemetry, action_int, command_string,\n+\t\tdata);\n+\tif (ret < 0) {\n+\t\tTELEMETRY_LOG_WARN(\"Warning - Could not parse command\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+\n+einval_fail:\n+\tret = rte_telemetry_send_error_response(telemetry, -EINVAL);\n+\tif (ret < 0) {\n+\t\tTELEMETRY_LOG_ERR(\"Error - Could not send error\\n\");\n+\t\treturn -EPERM;\n+\t}\n+\treturn -EINVAL;\n+}\ndiff --git a/lib/librte_telemetry/rte_telemetry_parser.h b/lib/librte_telemetry/rte_telemetry_parser.h\nnew file mode 100644\nindex 0000000..63e633d\n--- /dev/null\n+++ b/lib/librte_telemetry/rte_telemetry_parser.h\n@@ -0,0 +1,13 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2018 Intel Corporation\n+ */\n+\n+#include \"rte_telemetry_internal.h\"\n+\n+#ifndef _RTE_TELEMETRY_PARSER_H_\n+#define _RTE_TELEMETRY_PARSER_H_\n+\n+int32_t\n+rte_telemetry_parse(struct telemetry_impl *telemetry, char *socket_rx_data);\n+\n+#endif\n",
    "prefixes": [
        "04/11"
    ]
}