Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/43903/?format=api
{ "id": 43903, "url": "http://patchwork.dpdk.org/api/patches/43903/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com", "date": "2018-08-27T12:24:11", "name": "mem: share legacy and single file segments mode with secondaries", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "10ec4ec8840a1a44ab0a8006e6f76351c1f71e32", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1064, "url": "http://patchwork.dpdk.org/api/series/1064/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1064", "date": "2018-08-27T12:24:11", "name": "mem: share legacy and single file segments mode with secondaries", "version": 1, "mbox": "http://patchwork.dpdk.org/series/1064/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/43903/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/43903/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 60B9B58CB;\n\tMon, 27 Aug 2018 14:24:15 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id C8CF258C6\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 14:24:13 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Aug 2018 05:24:13 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 27 Aug 2018 05:24:12 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw7RCOBxV009592 for <dev@dpdk.org>; Mon, 27 Aug 2018 13:24:11 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w7RCOBm4002385\n\tfor <dev@dpdk.org>; Mon, 27 Aug 2018 13:24:11 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w7RCOBTj002381\n\tfor dev@dpdk.org; Mon, 27 Aug 2018 13:24:11 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,295,1531810800\"; d=\"scan'208\";a=\"80520785\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Mon, 27 Aug 2018 13:24:11 +0100", "Message-Id": "<98f283ce5bcf8973c5c08d13f4fbfe375ded6ebf.1535368896.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH] mem: share legacy and single file segments mode\n\twith secondaries", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, command-line switches for legacy mem mode or single-file\nsegments mode are only stored in internal config. This leads to a\nsituation where these flags have to always match between primary\nand secondary, which is bad for usability.\n\nFix this by storing these flags in the shared config as well, so\nthat secondary process can know if the primary was launched in\nsingle-file segments or legacy mem mode.\n\nThis bumps the EAL ABI, however there's an EAL deprecation notice\nalready in place[1] for a different feature, so that's OK.\n\n[1] http://patches.dpdk.org/patch/43502/\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n .../common/include/rte_eal_memconfig.h | 4 ++++\n lib/librte_eal/linuxapp/eal/Makefile | 2 +-\n lib/librte_eal/linuxapp/eal/eal.c | 20 +++++++++++++++++++\n lib/librte_eal/meson.build | 2 +-\n 4 files changed, 26 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_eal_memconfig.h b/lib/librte_eal/common/include/rte_eal_memconfig.h\nindex aff0688dd..62a21c2dc 100644\n--- a/lib/librte_eal/common/include/rte_eal_memconfig.h\n+++ b/lib/librte_eal/common/include/rte_eal_memconfig.h\n@@ -77,6 +77,10 @@ struct rte_mem_config {\n \t * exact same address the primary process maps it.\n \t */\n \tuint64_t mem_cfg_addr;\n+\n+\t/* legacy mem and single file segments options are shared */\n+\tuint32_t legacy_mem;\n+\tuint32_t single_file_segments;\n } __attribute__((__packed__));\n \n \ndiff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile\nindex fd92c75c2..5c16bc40f 100644\n--- a/lib/librte_eal/linuxapp/eal/Makefile\n+++ b/lib/librte_eal/linuxapp/eal/Makefile\n@@ -10,7 +10,7 @@ ARCH_DIR ?= $(RTE_ARCH)\n EXPORT_MAP := ../../rte_eal_version.map\n VPATH += $(RTE_SDK)/lib/librte_eal/common/arch/$(ARCH_DIR)\n \n-LIBABIVER := 8\n+LIBABIVER := 9\n \n VPATH += $(RTE_SDK)/lib/librte_eal/common\n \ndiff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex e59ac6577..4a55d3b69 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -352,6 +352,24 @@ eal_proc_type_detect(void)\n \treturn ptype;\n }\n \n+/* copies data from internal config to shared config */\n+static void\n+eal_update_mem_config(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\tmcfg->legacy_mem = internal_config.legacy_mem;\n+\tmcfg->single_file_segments = internal_config.single_file_segments;\n+}\n+\n+/* copies data from shared config to internal config */\n+static void\n+eal_update_internal_config(void)\n+{\n+\tstruct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config;\n+\tinternal_config.legacy_mem = mcfg->legacy_mem;\n+\tinternal_config.single_file_segments = mcfg->single_file_segments;\n+}\n+\n /* Sets up rte_config structure with the pointer to shared memory config.*/\n static void\n rte_config_init(void)\n@@ -361,11 +379,13 @@ rte_config_init(void)\n \tswitch (rte_config.process_type){\n \tcase RTE_PROC_PRIMARY:\n \t\trte_eal_config_create();\n+\t\teal_update_mem_config();\n \t\tbreak;\n \tcase RTE_PROC_SECONDARY:\n \t\trte_eal_config_attach();\n \t\trte_eal_mcfg_wait_complete(rte_config.mem_config);\n \t\trte_eal_config_reattach();\n+\t\teal_update_internal_config();\n \t\tbreak;\n \tcase RTE_PROC_AUTO:\n \tcase RTE_PROC_INVALID:\ndiff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build\nindex e1fde15d1..62ef985b9 100644\n--- a/lib/librte_eal/meson.build\n+++ b/lib/librte_eal/meson.build\n@@ -21,7 +21,7 @@ else\n \terror('unsupported system type \"@0@\"'.format(host_machine.system()))\n endif\n \n-version = 8 # the version of the EAL API\n+version = 9 # the version of the EAL API\n allow_experimental_apis = true\n deps += 'compat'\n deps += 'kvargs'\n", "prefixes": [] }