Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/44280/?format=api
{ "id": 44280, "url": "http://patchwork.dpdk.org/api/patches/44280/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/53a660ffd746c81f59fc3e1f35ac2222a7237641.1536073997.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<53a660ffd746c81f59fc3e1f35ac2222a7237641.1536073997.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/53a660ffd746c81f59fc3e1f35ac2222a7237641.1536073997.git.anatoly.burakov@intel.com", "date": "2018-09-04T15:15:44", "name": "[v3,3/9] mem: raise maximum fd limit unconditionally", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e056c52c4fcee157a214c56a47d398f5cfa81ca5", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/53a660ffd746c81f59fc3e1f35ac2222a7237641.1536073997.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 1177, "url": "http://patchwork.dpdk.org/api/series/1177/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=1177", "date": "2018-09-04T15:15:41", "name": "Improve running DPDK without hugetlbfs mounpoint", "version": 3, "mbox": "http://patchwork.dpdk.org/series/1177/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/44280/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/44280/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BFFAB532C;\n\tTue, 4 Sep 2018 17:16:04 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 959072BF7\n\tfor <dev@dpdk.org>; Tue, 4 Sep 2018 17:15:57 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Sep 2018 08:15:57 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga007.jf.intel.com with ESMTP; 04 Sep 2018 08:15:51 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw84FFpv6025472; Tue, 4 Sep 2018 16:15:51 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w84FFpnH022250;\n\tTue, 4 Sep 2018 16:15:51 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w84FFomI022242;\n\tTue, 4 Sep 2018 16:15:50 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.53,329,1531810800\"; d=\"scan'208\";a=\"70244540\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com, ray.kinsella@intel.com, zhihong.wang@intel.com,\n\tmaxime.coquelin@redhat.com, kuralamudhan.ramakrishnan@intel.com", "Date": "Tue, 4 Sep 2018 16:15:44 +0100", "Message-Id": "<53a660ffd746c81f59fc3e1f35ac2222a7237641.1536073997.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": [ "<cover.1536073996.git.anatoly.burakov@intel.com>", "<cover.1536073996.git.anatoly.burakov@intel.com>" ], "References": [ "<cover.1536073996.git.anatoly.burakov@intel.com>", "<cover.1536072550.git.anatoly.burakov@intel.com>\n\t<cover.1536073996.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH v3 3/9] mem: raise maximum fd limit\n\tunconditionally", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Previously, when we allocated hugepages, we closed the fd's corresponding\nto them after we've done our mappings. Since we did mmap(), we didn't\nactually lose the reference, but file descriptors used for mmap() do not\ncount against the fd limit. Since we are going to store all of our fd's,\nwe will hit the fd limit much more often when using smaller page sizes.\n\nFix this to raise the fd limit to maximum unconditionally.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal_memory.c | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c\nindex dbf19499e..dfb537f59 100644\n--- a/lib/librte_eal/linuxapp/eal/eal_memory.c\n+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c\n@@ -17,6 +17,7 @@\n #include <sys/stat.h>\n #include <sys/queue.h>\n #include <sys/file.h>\n+#include <sys/resource.h>\n #include <unistd.h>\n #include <limits.h>\n #include <sys/ioctl.h>\n@@ -2204,6 +2205,25 @@ memseg_secondary_init(void)\n int\n rte_eal_memseg_init(void)\n {\n+\t/* increase rlimit to maximum */\n+\tstruct rlimit lim;\n+\n+\tif (getrlimit(RLIMIT_NOFILE, &lim) == 0) {\n+\t\t/* set limit to maximum */\n+\t\tlim.rlim_cur = lim.rlim_max;\n+\n+\t\tif (setrlimit(RLIMIT_NOFILE, &lim) < 0) {\n+\t\t\tRTE_LOG(DEBUG, EAL, \"Setting maximum number of open files failed: %s\\n\",\n+\t\t\t\t\tstrerror(errno));\n+\t\t} else {\n+\t\t\tRTE_LOG(DEBUG, EAL, \"Setting maximum number of open files to %\"\n+\t\t\t\t\tPRIu64 \"\\n\",\n+\t\t\t\t\t(uint64_t)lim.rlim_cur);\n+\t\t}\n+\t} else {\n+\t\tRTE_LOG(ERR, EAL, \"Cannot get current resource limits\\n\");\n+\t}\n+\n \treturn rte_eal_process_type() == RTE_PROC_PRIMARY ?\n #ifndef RTE_ARCH_64\n \t\t\tmemseg_primary_init_32() :\n", "prefixes": [ "v3", "3/9" ] }